From: Petr Skocik <pskocik@gmail.com>
To: musl@lists.openwall.com
Subject: [musl] Musl's FD_{SET,ISSET,CLR} macros from sys/select.h trigger gcc's -Wsign-conversion warnings
Date: Sun, 2 Aug 2020 20:24:29 +0200 [thread overview]
Message-ID: <959b7861-f028-02cc-5226-d7116aab8e2b@gmail.com> (raw)
Example:
#include <sys/select.h>
void f(int X)
{
fd_set set;
FD_ZERO(&set);
FD_SET(X,&set);
FD_CLR(X+1,&set);
(void)FD_ISSET(X+2,&set);
}
results in
fds.c: In function ‘f’: fds.c:17:2: warning: conversion to ‘long
unsigned int’ from ‘int’ may change the sign of the result
[-Wsign-conversion] 17 | FD_SET(X,&set); | ^~~~~~ fds.c:17:2: warning:
conversion to ‘long unsigned int’ from ‘int’ may change the sign of the
result [-Wsign-conversion] fds.c:18:2: warning: conversion to ‘long
unsigned int’ from ‘int’ may change the sign of the result
[-Wsign-conversion] 18 | FD_CLR(X+1,&set); | ^~~~~~ fds.c:18:2: warning:
conversion to ‘long unsigned int’ from ‘int’ may change the sign of the
result [-Wsign-conversion] fds.c:19:8: warning: conversion to ‘long
unsigned int’ from ‘int’ may change the sign of the result
[-Wsign-conversion] 19 | (void)FD_ISSET(X+2,&set); | ^~~~~~~~
fds.c:19:8: warning: conversion to ‘long unsigned int’ from ‘int’ may
change the sign of the result [-Wsign-conversion]
on `gcc -Wconversion`.
Adding an int-cast before each `sizeof` in the definition of these
macros eliminates the warning:
#define FD_SET(d, s) ((s)->fds_bits[(d)/(8*(int)sizeof(long))] |=
(1UL<<((d)%(8*(int)sizeof(long)))))
#define FD_CLR(d, s) ((s)->fds_bits[(d)/(8*(int)sizeof(long))] &=
~(1UL<<((d)%(8*(int)sizeof(long)))))
#define FD_ISSET(d, s) !!((s)->fds_bits[(d)/(8*(int)sizeof(long))] &
(1UL<<((d)%(8*(int)sizeof(long)))))
You might want to add them.
Regards,
Petr Skocik
next reply other threads:[~2020-08-02 18:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 18:24 Petr Skocik [this message]
2020-08-02 18:53 ` Alexander Monakov
2020-08-02 18:56 ` Alexander Monakov
2020-08-02 19:43 ` Petr Skocik
2020-08-03 5:43 ` Markus Wichmann
2020-08-03 17:47 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=959b7861-f028-02cc-5226-d7116aab8e2b@gmail.com \
--to=pskocik@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).