From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, SUBJ_OBFU_PUNCT_FEW,SUBJ_OBFU_PUNCT_MANY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 28686 invoked from network); 2 Aug 2020 18:29:05 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 2 Aug 2020 18:29:05 -0000 Received: (qmail 23771 invoked by uid 550); 2 Aug 2020 18:29:02 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 21817 invoked from network); 2 Aug 2020 18:24:42 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:disposition-notification-to:date :user-agent:mime-version:content-transfer-encoding:content-language; bh=YjPZCU3qg8OR4vkp/dk38aQTIFRVXULTaXNYxfDwCbE=; b=p46sQhevH+tC/uz7gCVpk5baQM0Ufey41AWdmKJAnXnucHJJygZHnZaEgAaLpQNWDg X2T0H8HQ562aucvs8DkDtlpKGCFT/jzmaO6BWkngzMxlUGAJTTk4eMKvQx/wlKkfKSdV Bv8uM9/YXc5H+X+yq08y73I8P4dddqC8OKdNFV8O7sJCHZEbeYUhz2shE1J5AFaafVtw Q406Bari+ddEKcxPX9GzNDkvScvYalszDXbVkOx3rSI9pWgiMSJ+Mz7RquYxVb88wMQZ 2YMT7ih4NleduKzB4Q48IkRsrNJTD0Ci2spLjodMDl61HKFt7vYYkOmOO7bOXK83vZFc L5aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id :disposition-notification-to:date:user-agent:mime-version :content-transfer-encoding:content-language; bh=YjPZCU3qg8OR4vkp/dk38aQTIFRVXULTaXNYxfDwCbE=; b=sIdVm2k0JnC62VXw4ykgi+oUKqg00jlTTysHemasc7l6A2MbRHR3+Pc56CZy7ToHlj vriKYgmWdQxfskMqQCjH/EKhPpRowlS/QqKXyf2dmFQu0Jh14O+bzz16tad6cpePIj/n Z5e8ouNshAWuPiw9Kuhnpdvv2eZoz46kKLYcjM8T9JXFJ70vQ9Cl0Wfm5IZCzkPYLGlj QJP+PBc9glM+Lyo4NSyO67XUG/JrkWwR1kw9EXwwPEld/hVFphVnKIJJq2XdIS19jjPJ sTCpA3ZtTg2iUug8+xaj2yEDue/p4bkUmPjDsUzLTuYUjcjjnWaCkHtHunNB/mktSppN qmIA== X-Gm-Message-State: AOAM533EZ/TgPBO0Sn9GPviTZ/gW/MBUp5B7t8ODnMRSDi8FcivMYmVN Nh87zP917R4gUdydnhWNIMT9CX44gTE= X-Google-Smtp-Source: ABdhPJz6Ae0BL87LsunJYLv1WhTYkgPmOrM4Nm4+Up0H2dsYEo4fSaa0lTJlf+qguz2heibtDYa1MA== X-Received: by 2002:adf:bb52:: with SMTP id x18mr11694957wrg.325.1596392670326; Sun, 02 Aug 2020 11:24:30 -0700 (PDT) To: musl@lists.openwall.com From: Petr Skocik Message-ID: <959b7861-f028-02cc-5226-d7116aab8e2b@gmail.com> Date: Sun, 2 Aug 2020 20:24:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: [musl] Musl's FD_{SET,ISSET,CLR} macros from sys/select.h trigger gcc's -Wsign-conversion warnings Example: #include void f(int X) {     fd_set set;     FD_ZERO(&set);     FD_SET(X,&set);     FD_CLR(X+1,&set);     (void)FD_ISSET(X+2,&set); } results in fds.c: In function ‘f’: fds.c:17:2: warning: conversion to ‘long unsigned int’ from ‘int’ may change the sign of the result [-Wsign-conversion] 17 | FD_SET(X,&set); | ^~~~~~ fds.c:17:2: warning: conversion to ‘long unsigned int’ from ‘int’ may change the sign of the result [-Wsign-conversion] fds.c:18:2: warning: conversion to ‘long unsigned int’ from ‘int’ may change the sign of the result [-Wsign-conversion] 18 | FD_CLR(X+1,&set); | ^~~~~~ fds.c:18:2: warning: conversion to ‘long unsigned int’ from ‘int’ may change the sign of the result [-Wsign-conversion] fds.c:19:8: warning: conversion to ‘long unsigned int’ from ‘int’ may change the sign of the result [-Wsign-conversion] 19 | (void)FD_ISSET(X+2,&set); | ^~~~~~~~ fds.c:19:8: warning: conversion to ‘long unsigned int’ from ‘int’ may change the sign of the result [-Wsign-conversion] on `gcc -Wconversion`. Adding an int-cast before each `sizeof` in the definition of these macros eliminates the warning:     #define FD_SET(d, s)   ((s)->fds_bits[(d)/(8*(int)sizeof(long))] |= (1UL<<((d)%(8*(int)sizeof(long)))))     #define FD_CLR(d, s)   ((s)->fds_bits[(d)/(8*(int)sizeof(long))] &= ~(1UL<<((d)%(8*(int)sizeof(long)))))     #define FD_ISSET(d, s) !!((s)->fds_bits[(d)/(8*(int)sizeof(long))] & (1UL<<((d)%(8*(int)sizeof(long))))) You might want to add them. Regards, Petr Skocik