Re: [PATCH] nameser.h: explicitely include endian.h

[Bartosz Brachaczek <b.brachaczek@gmail.com>]

On 12/15/2017 5:38 AM, Rich Felker wrote:
> On Mon, Dec 04, 2017 at 12:13:06PM +0100, Jo-Philipp Wich wrote:
>> As nameser.h itself uses endian macros to declare the proper layout of
>> the HEADER structure, it needs to include the endian.h header as well.
>>
>> The issue was found while investigating iodine query packet corruption
>> on little endian musl systems [1].
>>
>> 1: http://lists.infradead.org/pipermail/lede-dev/2017-November/010085.html
>>
>> Signed-off-by: Jo-Philipp Wich <jo@mein.io>
>> ---
>>   include/arpa/nameser.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/arpa/nameser.h b/include/arpa/nameser.h
>> index 581925a4..b315e0f3 100644
>> --- a/include/arpa/nameser.h
>> +++ b/include/arpa/nameser.h
>> @@ -7,6 +7,7 @@ extern "C" {
>>   
>>   #include <stddef.h>
>>   #include <stdint.h>
>> +#include <endian.h>
>>   
>>   #define __NAMESER	19991006
>>   #define NS_PACKETSZ	512
>> -- 
>> 2.11.0
> 
> Thanks. Committing.
> 
> Rich
> 

I believe include/netinet/icmp6.h suffers from the same issue (missing 
endian.h include directive).