From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12250 Path: news.gmane.org!.POSTED!not-for-mail From: Bartosz Brachaczek Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] nameser.h: explicitely include endian.h Date: Fri, 15 Dec 2017 18:54:10 +0100 Message-ID: <976700e2-b63d-7c75-21fa-136e3cf5a9a6@gmail.com> References: <20171204111306.2859-1-jo@mein.io> <20171215043848.GJ1627@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1513360463 19734 195.159.176.226 (15 Dec 2017 17:54:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 15 Dec 2017 17:54:23 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 To: musl@lists.openwall.com Original-X-From: musl-return-12266-gllmg-musl=m.gmane.org@lists.openwall.com Fri Dec 15 18:54:19 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1ePuBf-0004rA-1Q for gllmg-musl@m.gmane.org; Fri, 15 Dec 2017 18:54:19 +0100 Original-Received: (qmail 19747 invoked by uid 550); 15 Dec 2017 17:54:24 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 19726 invoked from network); 15 Dec 2017 17:54:23 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=Kb43EgH74ticzKmpd/v8l3LvJZXj18n0pmpOazcwzyw=; b=ZOGuZjrRghJNtJB18m/3+7u73Ky3f4NVfpnauxJvnEJsagb/Mo124/FLrxVfpHUiHw F+E6603oNY7enscmHioM/PeZar5nXTGGXrwVR5fYKt0DYuGRISWZOtMap/ymvsGon2vV S9Ocn9LFHzQ5eRt436icjcQGd+CYtvjoMOauIRIN6TcvPPvdVdCf+QaWsLl/Tdd9NlW3 2ZNiVw/i95NSsRz3lWmdFmbmhyVhxjCIqCl5SsKw/ySNP/52HW9eabYpmHkAejk2LMn9 air2Mu/J616zKbf9c5w8BkHKv0Izmj/jd0Tq+t6ZcnIq5nwHdl3vlFbhDtTdX+v/gqAa ySJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Kb43EgH74ticzKmpd/v8l3LvJZXj18n0pmpOazcwzyw=; b=cF/XTqP7zE+sQtMniSYMOYW5Fu9sVOc60n7GsE37SacaC+kfDysdkooFBpQ01X3Oa6 RmBXFY6xTHlIZQjzU7m9W1RCpuF3zUyDgbChNXvBKAD+Uf/p31zOO7WmrPA1GH7mILbk mlnqUPR2WPn6CnKu+zr1miaouFPYxxp6JsMhq7YnvmLiqxz8YDMBD2bn5g1s8EIZ7d8b 9pod5Lv8bOkePdnS4jQgmnB3eFlS/zHMeJEwn7Yv1fu/rNKBZQTdLbmyD1cQH0z76ppQ 1X3OnDd4+Jyh0LwMeDIGB/to0s40OLPGoAyUTXdiJnyaMM4OQyPxRfhN767Xiz4GsNRF uquQ== X-Gm-Message-State: AKGB3mJntiIbInNIic8oRH8jzObtLeYdJyxwTnefktsiDtdCOL6xn7lI rNBmuWSD8YAShMAXmACMu06W8bCa X-Google-Smtp-Source: ACJfBoupeazMhbuJvDrSKYpvxo4wI87OtkfqmFMgeSus1xTkW86vSNR6hzBwQdAgZGTVCJ4AF2D6jg== X-Received: by 10.25.156.6 with SMTP id f6mr4460959lfe.0.1513360451977; Fri, 15 Dec 2017 09:54:11 -0800 (PST) In-Reply-To: <20171215043848.GJ1627@brightrain.aerifal.cx> Content-Language: en-US Xref: news.gmane.org gmane.linux.lib.musl.general:12250 Archived-At: On 12/15/2017 5:38 AM, Rich Felker wrote: > On Mon, Dec 04, 2017 at 12:13:06PM +0100, Jo-Philipp Wich wrote: >> As nameser.h itself uses endian macros to declare the proper layout of >> the HEADER structure, it needs to include the endian.h header as well. >> >> The issue was found while investigating iodine query packet corruption >> on little endian musl systems [1]. >> >> 1: http://lists.infradead.org/pipermail/lede-dev/2017-November/010085.html >> >> Signed-off-by: Jo-Philipp Wich >> --- >> include/arpa/nameser.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/arpa/nameser.h b/include/arpa/nameser.h >> index 581925a4..b315e0f3 100644 >> --- a/include/arpa/nameser.h >> +++ b/include/arpa/nameser.h >> @@ -7,6 +7,7 @@ extern "C" { >> >> #include >> #include >> +#include >> >> #define __NAMESER 19991006 >> #define NS_PACKETSZ 512 >> -- >> 2.11.0 > > Thanks. Committing. > > Rich > I believe include/netinet/icmp6.h suffers from the same issue (missing endian.h include directive).