From: Felix Fietkau <nbd@nbd.name>
To: Koen Vandeputte <koen.vandeputte@ncentric.com>,
Syrone Wong <wong.syrone@gmail.com>,
musl@lists.openwall.com
Subject: Re: [LEDE-DEV] [PATCH 1/2] musl: update to 1.1.16+ git HEAD 2017-09-28
Date: Mon, 16 Oct 2017 16:09:16 +0200 [thread overview]
Message-ID: <9f1a274a-1529-a1c3-0de3-d3bab1f7e8fe@nbd.name> (raw)
In-Reply-To: <20171016140355.GR15263@port70.net>
On 2017-10-16 16:03, Szabolcs Nagy wrote:
> * Koen Vandeputte <koen.vandeputte@ncentric.com> [2017-10-16 10:31:11 +0200]:
>> I've proposed to update the musl libc within the LEDE project and received
>> some feedback from Syrone Wong (in cc).
>>
>> According to him, your upstream commit in musl [1] seems to break something.
>> (see below)
>>
>> - Can you confirm this?
>> - Would you have any clue what the reason could be?
> ...
>> [1]
>> "powerpc{64}: fix MAP_NORESERVE and MAP_LOCKED in mman.h"
>> http://git.musl-libc.org/cgit/musl/commit/?id=c10bc61508dc52b8315084e628f36a6c3c2dabb1
>>
>
> these are rarely used mmap flags, i think my patch is correct.
>
> the old value in musl was wrong on powerpc (i think the old
> value did not collide with other map flags so the kernel would
> report EINVAL if these flags were ever used).
I don't think this commit is the cause at all. The bug reporter was
using an ARM device and this commit only touches powerpc header files.
Probably the issue is somewhere between the version that LEDE uses now
and the version with this commit id.
- Felix
next prev parent reply other threads:[~2017-10-16 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1507540908-26635-1-git-send-email-koen.vandeputte@ncentric.com>
[not found] ` <CAEaqfoby9DepJnGG3_sSaKp5WYSPCzuKTRR6DF2-1irwG7Sy2g@mail.gmail.com>
[not found] ` <dd0dcaaf-2c4e-ebed-93d9-1eff350ecad4@ncentric.com>
2017-10-16 14:03 ` Szabolcs Nagy
2017-10-16 14:09 ` Felix Fietkau [this message]
2017-10-16 15:01 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f1a274a-1529-a1c3-0de3-d3bab1f7e8fe@nbd.name \
--to=nbd@nbd.name \
--cc=koen.vandeputte@ncentric.com \
--cc=musl@lists.openwall.com \
--cc=wong.syrone@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).