From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12008 Path: news.gmane.org!.POSTED!not-for-mail From: Felix Fietkau Newsgroups: gmane.linux.lib.musl.general Subject: Re: [LEDE-DEV] [PATCH 1/2] musl: update to 1.1.16+ git HEAD 2017-09-28 Date: Mon, 16 Oct 2017 16:09:16 +0200 Message-ID: <9f1a274a-1529-a1c3-0de3-d3bab1f7e8fe@nbd.name> References: <1507540908-26635-1-git-send-email-koen.vandeputte@ncentric.com> <20171016140355.GR15263@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1508162970 26319 195.159.176.226 (16 Oct 2017 14:09:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 16 Oct 2017 14:09:30 +0000 (UTC) User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 To: Koen Vandeputte , Syrone Wong , musl@lists.openwall.com Original-X-From: musl-return-12021-gllmg-musl=m.gmane.org@lists.openwall.com Mon Oct 16 16:09:26 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1e4656-00061b-1U for gllmg-musl@m.gmane.org; Mon, 16 Oct 2017 16:09:24 +0200 Original-Received: (qmail 26605 invoked by uid 550); 16 Oct 2017 14:09:29 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 26568 invoked from network); 16 Oct 2017 14:09:28 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xOeHPkN+xnoEoC7RMxwDotoqWbQidLvcKQxwQrbwShk=; b=X4FovvCqj9f/k91Ob39hAkb3dr MnIN8UGl/6PS4eQXFjNuLgrvcSamKAFVvG9twZ5M/BI2laKgZACTfUiGgav7MyntGTclHhny4jYFI T6tsmh0BkgzPIUOTED68HL50ZBplA/9YgLbyudb/TcpZDnDkV840P8vKH0s/NdZB+Z7U=; In-Reply-To: <20171016140355.GR15263@port70.net> Content-Language: en-US Xref: news.gmane.org gmane.linux.lib.musl.general:12008 Archived-At: On 2017-10-16 16:03, Szabolcs Nagy wrote: > * Koen Vandeputte [2017-10-16 10:31:11 +0200]: >> I've proposed to update the musl libc within the LEDE project and received >> some feedback from Syrone Wong (in cc). >> >> According to him, your upstream commit in musl [1] seems to break something. >> (see below) >> >> - Can you confirm this? >> - Would you have any clue what the reason could be? > ... >> [1] >> "powerpc{64}: fix MAP_NORESERVE and MAP_LOCKED in mman.h" >> http://git.musl-libc.org/cgit/musl/commit/?id=c10bc61508dc52b8315084e628f36a6c3c2dabb1 >> > > these are rarely used mmap flags, i think my patch is correct. > > the old value in musl was wrong on powerpc (i think the old > value did not collide with other map flags so the kernel would > report EINVAL if these flags were ever used). I don't think this commit is the cause at all. The bug reporter was using an ARM device and this commit only touches powerpc header files. Probably the issue is somewhere between the version that LEDE uses now and the version with this commit id. - Felix