From: Julien Ramseier <j.ramseier@gmail.com>
To: musl@lists.openwall.com
Subject: Re: tre regex in single regcomp.c file
Date: Thu, 16 Jun 2016 17:30:26 +0200 [thread overview]
Message-ID: <A3E99621-443F-47DA-A728-7A97FC2B4DE5@gmail.com> (raw)
In-Reply-To: <20160616152526.GH10893@brightrain.aerifal.cx>
> Le 16 juin 2016 à 17:25, Rich Felker <dalias@libc.org> a écrit :
>>
>> creating internal interfaces for implementing a single
>> self-contained public function (regcomp) is bad design.
>>
>> (even if you split the code up, all the code will be
>> linked together if the public api symbol is referenced
>> otherwise none of the code will be used, so you just
>> create linking overhead and headaches around the internal
>> api between the source files which must obey posix
>> namespace rules etc.)
>
> Yes, the main motivation was to get rid of external namespace
> pollution without renaming all the internal functions to be
> __-prefixed, and also to allow inter-procedural analysis
> optimizations.
>
That makes sense.
Thank you both for the explanations.
- Julien
prev parent reply other threads:[~2016-06-16 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 14:31 Julien Ramseier
2016-06-16 15:12 ` Szabolcs Nagy
2016-06-16 15:25 ` Rich Felker
2016-06-16 15:30 ` Julien Ramseier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A3E99621-443F-47DA-A728-7A97FC2B4DE5@gmail.com \
--to=j.ramseier@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).