From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10885 Path: news.gmane.org!.POSTED!not-for-mail From: Julien Ramseier Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] drop lchmod Date: Wed, 4 Jan 2017 22:23:55 +0100 Message-ID: Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1483565063 8036 195.159.176.226 (4 Jan 2017 21:24:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Jan 2017 21:24:23 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-10898-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jan 04 22:24:20 2017 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1cOt2V-0000ES-97 for gllmg-musl@m.gmane.org; Wed, 04 Jan 2017 22:24:07 +0100 Original-Received: (qmail 25943 invoked by uid 550); 4 Jan 2017 21:24:09 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 25914 invoked from network); 4 Jan 2017 21:24:08 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:subject:message-id:date:to :mime-version; bh=0prVNIIYInZn2waO3wQZh51VUJZVhvjv/iq3T3w+S2s=; b=TY+g3c8cTNQ+ch5H7ZbYcORvEgbAdtYvbR4HuCXKT8HfCu6pBHbJQHXfyzt4SWSFdz 9a+pDk7VCDh/W+lNB99N3RaMM7VzHBwfkoHkwewn65J8gcXzWTGH/5MdT8S/dt+jQ/gz K/xANcBkmemcF6bCWKqd6TFl8+m3rmRqUwjBwDIgTuTEY4ZYeJ9GTH4XGMGX2x8hIoSR T59fo+a6stqnRPDewYgVb1UR5ECH2FXhYhodqe5DHWKbDwSrcRpt7P7aEr2sgSCiRnD+ FWZu9u89fBXC5lcWYRkxICTq0SB6L0VyTCP2BjPn7qO5QC0VR0fLjkoNPI0X6zEJVWMP owCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:subject :message-id:date:to:mime-version; bh=0prVNIIYInZn2waO3wQZh51VUJZVhvjv/iq3T3w+S2s=; b=fjZPsxfKpiErOEE3TvYaD12kitNPtfxAMWbtHWZWX4g/NjN/HXUbR3V6UtyQuLjlK1 du4hjWCEt0rWuSQW+Ox1S+JEExCi2EbrRZJQHmjsW+WPT2EmUZqYMqU+Hd6BHmEJR+hK guOfEfKvLWVUHPodnsNW4evMTCw1wWe+k7hbTCxwewolGN4lJV+TCYrRBQHv3KsrnCy+ vtXDsIddCFQFEqzzu8eUur8jwDx11Nt25I2cZBW232YK0iyZQCwRSz5rglaQfTDFFKvZ KkWfTT4qNzdfutnL83vNZcBwdW3sUfbFfmQRSmeUARgQVhjR8+94ESHrY2t9F8bXeDdo HG1A== X-Gm-Message-State: AIkVDXJDkhI3g1DqTEAjj1tm4h1JhZl6HVzY1xWYepXW2nsj5R3N3SNGQlzo4NxvFdNySg== X-Received: by 10.28.88.11 with SMTP id m11mr57790305wmb.45.1483565036897; Wed, 04 Jan 2017 13:23:56 -0800 (PST) X-Mailer: Apple Mail (2.3124) Xref: news.gmane.org gmane.linux.lib.musl.general:10885 Archived-At: lchmod is not POSIX and not supported on Linux. Keeping it would probably do more harm than good: software checking for its presence (i.e. libarchive) will use it and always fail. diff --git a/include/sys/stat.h b/include/sys/stat.h index 9d09662..0058338 100644 --- a/include/sys/stat.h +++ b/include/sys/stat.h @@ -92,7 +92,6 @@ int futimens(int, const struct timespec [2]); int utimensat(int, const char *, const struct timespec [2], int); #if defined(_GNU_SOURCE) || defined(_BSD_SOURCE) -int lchmod(const char *, mode_t); #define S_IREAD S_IRUSR #define S_IWRITE S_IWUSR #define S_IEXEC S_IXUSR diff --git a/src/stat/lchmod.c b/src/stat/lchmod.c deleted file mode 100644 index f324ba7..0000000 --- a/src/stat/lchmod.c +++ /dev/null @@ -1,8 +0,0 @@ -#define _GNU_SOURCE -#include -#include - -int lchmod(const char *path, mode_t mode) -{ - return fchmodat(AT_FDCWD, path, mode, AT_SYMLINK_NOFOLLOW); -}