RE: [PATCH] MIPS64 atomic_arch.h Clang complains about input type

[Jaydeep Patil <Jaydeep.Patil@imgtec.com>]

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

Added musl@lists.openwall.com<mailto:musl@lists.openwall.com> in Cc

From: Jaydeep Patil
Sent: 08 March 2016 PM 03:38
To: Rich Felker (dalias@libc.org)
Subject: [PATCH] MIPS64 atomic_arch.h Clang complains about input type

Hi Rich,

Clang (3.9.0) generates following error for a_sc_p function in atomic_arch.h:

./arch/mips64/atomic_arch.h:37:29: error: unsupported inline asm: input with type 'long *' matching output with type 'int'

Could you please consider this patch to fix it?
-----

From 3e64da8f5db923a919cd5600e8031c158a0368a2 Mon Sep 17 00:00:00 2001
From: Jaydeep Patil <jaydeep.patil@imgtec.com>
Date: Tue, 8 Mar 2016 10:06:38 +0000
Subject: [PATCH] [MIPS64] Fix Clang error

---
arch/mips64/atomic_arch.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips64/atomic_arch.h b/arch/mips64/atomic_arch.h
index 49d9884..8af6500 100644
--- a/arch/mips64/atomic_arch.h
+++ b/arch/mips64/atomic_arch.h
@@ -29,9 +29,9 @@ static inline void *a_ll_p(volatile long *p)
}

#define a_sc_p a_sc_p
-static inline int a_sc_p(volatile long *p, void *v)
+static inline void *a_sc_p(volatile long *p, void *v)
{
-       int r;
+       void *r;
        __asm__ __volatile__ (
                "scd %0, %1"
                : "=r"(r), "=m"(*p) : "0"(v) : "memory");
--
2.1.4

Thanks,
Jaydeep


[-- Attachment #2: Type: text/html, Size: 6088 bytes --]