Re: Fix for tcsh

[Igmar Palsenberg <igmar@palsenberg.com>]

[-- Attachment #1: Type: text/plain, Size: 1121 bytes --]



> I just want to know what would be right approach to fixing the compile error in tcsh.
> 
> I use the source code at ftp://ftp.astron.com/pub/tcsh/tcsh-6.18.01.tar.gz
> 
> I get the following error:
> gcc -c -g -O2 -I. -I. -D_PATH_TCSHELL='"/usr/local/bin/tcsh"'    sh.proc.c
> sh.proc.c: In function 'pchild':
> sh.proc.c:155:16: error: storage size of 'w' isn't known
> make: *** [sh.proc.o] Error 1
> 
> Those lines are:
> 
> #ifdef BSDWAIT
>     union wait w;
> #else /* !BSDWAIT */
>     int     w;
> #endif /* !BSDWAIT */
> 
> 
> If I just use
> 
> //#ifdef BSDWAIT
> //    union wait w;
> //#else /* !BSDWAIT */
>     int     w;
> //#endif /* !BSDWAIT */
> 
> it compiles and works (for months now without an issue).
> 
> 
> My question really is what should the proper "ifdef" be if I want to send the fix to the tcsh maintainers ?

There isn't one. tcsh needs to provide a test to see if this is present, and currently has stuff hard-coded. The proper fix
would be an test added to configure.in, and remove of the hardcoded stuff in sh.proc.c



Regards,




	Igmar

[-- Attachment #2: Type: text/html, Size: 1875 bytes --]