From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/3447 Path: news.gmane.org!not-for-mail From: Igmar Palsenberg Newsgroups: gmane.linux.lib.musl.general Subject: Re: Fix for tcsh Date: Fri, 21 Jun 2013 11:27:01 +0200 Message-ID: References: Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_22716646-0267-46CA-84D3-45EB44B04FBD" X-Trace: ger.gmane.org 1371806836 16227 80.91.229.3 (21 Jun 2013 09:27:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Jun 2013 09:27:16 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-3451-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jun 21 11:27:17 2013 Return-path: Envelope-to: gllmg-musl@plane.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1Upxci-0003Ed-As for gllmg-musl@plane.gmane.org; Fri, 21 Jun 2013 11:27:16 +0200 Original-Received: (qmail 17445 invoked by uid 550); 21 Jun 2013 09:27:15 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 17434 invoked from network); 21 Jun 2013 09:27:15 -0000 In-Reply-To: X-Mailer: Apple Mail (2.1508) Xref: news.gmane.org gmane.linux.lib.musl.general:3447 Archived-At: --Apple-Mail=_22716646-0267-46CA-84D3-45EB44B04FBD Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=iso-8859-1 > I just want to know what would be right approach to fixing the compile = error in tcsh. >=20 > I use the source code at = ftp://ftp.astron.com/pub/tcsh/tcsh-6.18.01.tar.gz >=20 > I get the following error: > gcc -c -g -O2 -I. -I. -D_PATH_TCSHELL=3D'"/usr/local/bin/tcsh"' = sh.proc.c > sh.proc.c: In function 'pchild': > sh.proc.c:155:16: error: storage size of 'w' isn't known > make: *** [sh.proc.o] Error 1 >=20 > Those lines are: >=20 > #ifdef BSDWAIT > union wait w; > #else /* !BSDWAIT */ > int w; > #endif /* !BSDWAIT */ >=20 >=20 > If I just use >=20 > //#ifdef BSDWAIT > // union wait w; > //#else /* !BSDWAIT */ > int w; > //#endif /* !BSDWAIT */ >=20 > it compiles and works (for months now without an issue). >=20 >=20 > My question really is what should the proper "ifdef" be if I want to = send the fix to the tcsh maintainers ? There isn't one. tcsh needs to provide a test to see if this is present, = and currently has stuff hard-coded. The proper fix would be an test added to configure.in, and remove of the hardcoded = stuff in sh.proc.c Regards, Igmar= --Apple-Mail=_22716646-0267-46CA-84D3-45EB44B04FBD Content-Transfer-Encoding: 7bit Content-Type: text/html; charset=iso-8859-1


I just want to know what would be right approach to fixing the compile error in tcsh.

I use the source code at ftp://ftp.astron.com/pub/tcsh/tcsh-6.18.01.tar.gz

I get the following error:
gcc -c -g -O2 -I. -I. -D_PATH_TCSHELL='"/usr/local/bin/tcsh"'    sh.proc.c
sh.proc.c: In function 'pchild':
sh.proc.c:155:16: error: storage size of 'w' isn't known
make: *** [sh.proc.o] Error 1

Those lines are:

#ifdef BSDWAIT
    union wait w;
#else /* !BSDWAIT */
    int     w;
#endif /* !BSDWAIT */


If I just use

//#ifdef BSDWAIT
//    union wait w;
//#else /* !BSDWAIT */
    int     w;
//#endif /* !BSDWAIT */

it compiles and works (for months now without an issue).


My question really is what should the proper "ifdef" be if I want to send the fix to the tcsh maintainers ?

There isn't one. tcsh needs to provide a test to see if this is present, and currently has stuff hard-coded. The proper fix
would be an test added to configure.in, and remove of the hardcoded stuff in sh.proc.c



Regards,




Igmar
--Apple-Mail=_22716646-0267-46CA-84D3-45EB44B04FBD--