From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 20221 invoked from network); 21 Oct 2021 16:56:54 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 21 Oct 2021 16:56:54 -0000 Received: (qmail 9976 invoked by uid 550); 21 Oct 2021 16:56:51 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 19706 invoked from network); 21 Oct 2021 16:09:46 -0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SS0PAbEJ8X+Qzt+lKAlh8+WNrM5FOYUCd8KtQzJlF4+Tej9+b2fAQVfUnousYqzdgVlA9ukQSk+LGiC7jgM/9Upan0VRlAXzcpTQ6NxVkd86xvSs7f95ymASr+8E+hQEFAOE27zsFkzJdxkrJDJvybcrXrb3IPZsfno5xv89CoK4qSq6vwFH99FwFy+6FNm2kboeVEK5gfdH0gm/mmZlt6i0p5qr/jjVM0s26WgUrSvOsNKlbN8VEPAZi6RvlT075wexX/Y/hURH3UDMgORSkT4UrZBayintckDXlpeRRY7GOm+BblUrABu4k81GJ7bAae6bEUCy8jWtBPuvoSg6vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Emd4+OhKHBbb+ZUybobzsobbpbn25BJqmFRFcP70SZg=; b=IzCihDwJC1RTYf+/w1MitiUNUMmZ53+Nm2O1fdm3MYKxjo1EvQfBf+ftxsP6idiqyvr2aYuXYsrcofu+9F7gtW1aJZHTr4oS/SqfPBqKhqxS72yctIPEL0EfR6r1N2tVqmUQUqt9r1FaTrwTmvQpAfzh3GFYsImbJGe60fSLnIQlD2dg6f0Rc5tJoYA15pNXrGiSY45OeYHVOUSIb/iX+psBawqG+pxbv0Mq0L+c60+5iyjg7zi5RmIzwREYgcnSMVbzPG0+4WXNsouKchWMbGs90cvvH3iLnXz8qAz91Z7jENX7lzhnX1pLT5Q0wCAMpkINUowP6Jslt6ogxm+MGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Emd4+OhKHBbb+ZUybobzsobbpbn25BJqmFRFcP70SZg=; b=H9FS9PCWT3a4wellEw7CfH+0FeIvJyfpB4Kp+DQh7CbJe2jMEZy/5aL/49u/qlouUkgomZlaftIbYiH3IsvCavhgXVBug+4HHcn1RD2yrEVA73tmnGF2V4W2ejizRpTN0bs7d5D2Tv8tUlg/zlvPdZooj3nVoy8X+wbXaItGOns= From: Wesley Wiser To: "musl@lists.openwall.com" Thread-Topic: [PATCH] fix: Use $srcdir in configure test for add-cfi script Thread-Index: AdfGlMEZJ0NIGU4jTLexI8nwaZPDOQ== Date: Thu, 21 Oct 2021 16:09:30 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=6caa8c91-2186-458c-9c0c-891cffe1c912;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2021-10-21T15:57:07Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 04103977-7f42-44a7-e7c3-08d994ad2a3b x-ms-traffictypediagnostic: SA1PR21MB1302: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3fvMf4jFex1i6DTKrVZ7T91vLvTVTdoG+L75BPk4lE+tVmEntyShN7TZYGCLAPP1zHhV9+ERsEUZf3CyFLoqQvRQDlAquV+AXp2/Z0sMM6A5MQjZlyzEDCWtvW6QniMRk8Tq/Sxc3rCmGPsx4I+VzmKz4EzuKvXY4ueiMydNncqO9HqVrNJN7nHt2G3M3iCot3IM9jdG7Kloje/HtC1qFCFkre40ctQxBUs+W7m2tRN8QiaQXhfkxnLOyLOOUyC6rbGV4gY+KH7Vf8BNp4Fucw1GWAKe10ATfuQRPIg+sfQ942lEl16X3QA6/grbOTsYOWL9WkMHFvbBE212CWmq1/VKaEhXoYq84NJo0Wc8/YjVKnKjWVn9pNZxqniaDRP9o7t8+ZzhAZZVV9Ow22Ex0UX0pH0fMen4MPPQc/EOLFZszc/4EyoGgpdj4/Pvv1IhOxdci00UZhtYxiFkE9WgWQRM1n/0BolViiw2I3k3XtokZaMNEGIqCZMJEiwJbXSP3NDJ63IG0oZ+CBlWgKyGANbPXyLM4j3dwRIhPc1GDxCjAvc7AUoYAHxrIZyKLVFYz9a19bUHPBnFEETc/OEUddywt1F4sKEd6uUOWVHwXksgIP2bH4OHuWYcXLe6/MLbqLuoYcNem/+aG+uz1daGSrId9hrt6j2WKEyKf6Io4/vCLG/51WVga5qaZFni48XGP1QQKow5meLCYxraV+o17M/v3oymKOmw6h2cAyTKrA1yrK+EhNpk4MgOjAYiEb1XUw/G3HwcsRAXt0abks4Tdi9DUBhq5stfotd6AH6iRD0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR2101MB1073.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(2906002)(8936002)(7696005)(38070700005)(66446008)(8676002)(5660300002)(316002)(66476007)(83380400001)(66556008)(6916009)(76116006)(66946007)(55016002)(82950400001)(33656002)(82960400001)(6506007)(508600001)(966005)(26005)(64756008)(10290500003)(9686003)(8990500004)(38100700002)(122000001)(71200400001)(86362001)(186003)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZcREiWAejmJTVAa4R8Mns5p0sR8LNspGxlFFLPEnQIjVx6ROSEjCxfPMQAHr?= =?us-ascii?Q?bZ9ohb1FPHFdjWBYea5Dmsns6p7B5Rou6g5dtDbe2D8eDMVnolK3GasFgZr3?= =?us-ascii?Q?r6Bzt5tJzIVi8LCQ6fkjW1nenrg8/VINkQR9ltD3rNcSrF32I5xYlXv10F5z?= =?us-ascii?Q?VoL5tFmVfR7phy/K06ty4FkzXPoe9OPIi/K7oUUjoCo97eG4ZaTDUrp39SuG?= =?us-ascii?Q?dL91+fkZnMY7im8Ybz6CRPSHihdpELQMnkqxs0tMRkgFLl/sfVIzYUVSavKp?= =?us-ascii?Q?+qy7Lq34LK2JgV/eTzybuFLOZonw7+p3HKbkmRwxILy9cvKubD1AJGWa1GoZ?= =?us-ascii?Q?VTnLr1ntfCoo+eBcFApN1ePcmP59Q9+t33tneaYoFBTe3CPbKoygrbO40C2n?= =?us-ascii?Q?jwzNbSsfONRp3E8wX7tVyfulze0gjFt1VhT+DKKwhBZCBEuW+7KBHq3GstxE?= =?us-ascii?Q?XWKrcUMWroQKyTHFsvYY79ZKjNlEmqaljdYLvBHC66apysQdQWPsW6oU9Gnd?= =?us-ascii?Q?udKl5f3AK1q/nOqMtAkM/dUH90510AwZQsgUB2UUXgkX/mCl5XE6bLKs4/8i?= =?us-ascii?Q?XNQrxBoWSnaOevC/jER6lt5Yjt8zkJZx2C4gcyQHAaG/D/kIxFxbjQXhVsON?= =?us-ascii?Q?qgXuCIheYs6hChmK7PHZcJFqbDcfzDNnxMlJGDV4XMJ8Ob/PZwUy2jrvW4i7?= =?us-ascii?Q?/YQyo0Zvnhji4CqYXOLS3J278Fb3j3YuCl1GcJoVp+fTQyFws1C0VlIvcaxI?= =?us-ascii?Q?coKo5JP0DA4H4FIKtqOJLf0nZibb0ytRlh1Mi0Lu7bh3YCEMmKwG/hLmhdRR?= =?us-ascii?Q?S70eIfM6MChfUSwXCiWBFZHTh37UGNfw2lNoP2NL064v3bhLY5RwK/rsnHh+?= =?us-ascii?Q?qPNsPSzuQAHjr1oiYq7HQcqtk+AHIe8uF3pyIYjC7+uDdqr/Ar0zj/g0t+LG?= =?us-ascii?Q?HJ7ab9cVnfgj/sNq5Hcqt7mIvnPJ/qpTTjpYoFnGaTo29JH/yGT/RT/8p8OU?= =?us-ascii?Q?uZx6KOa8DdyXl1+YJvb77idHEwx0eWi25+Axc36AD/AbyxnTfPEjDMu2NhTs?= =?us-ascii?Q?IV10oNLNgdGGf/GLCgCBIhIeDN0cMRHbpsjjiuQVVwQbyu/uK5nUSySMVhmx?= =?us-ascii?Q?HHHInd6FVi5Tiw7dc+wwXmNGQX052YODesNRB/6ZgAwHDb9v1FApoDYnhdKP?= =?us-ascii?Q?g8BeAF9QEixZx/hXjwAVtnKKsnbtyWdCq71fr56FuZR7XIC/17LzGmzH7N8c?= =?us-ascii?Q?f6wsIFrppnlVtnYq+KQtyKyrVrxWzDrPT7yVwKPOTku3c9bZ3pPwdSRN1Z36?= =?us-ascii?Q?ZgReWlMoGUCK09M9P3+kNrBXqNokFBnZzUGPaPGpOKjvPO5T7Z/n3w9ziRcA?= =?us-ascii?Q?nL0V4yf+iiZWy/+6s1gigIAQ81Sw?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL0PR2101MB1073.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04103977-7f42-44a7-e7c3-08d994ad2a3b X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Oct 2021 16:09:30.7548 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wesleywiser@microsoft.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR21MB1302 Subject: [musl] [PATCH] fix: Use $srcdir in configure test for add-cfi script Hello, I noticed while building musl with musl-cross-make[1] that adding --enable-= debug to the MUSL_CONFIG variable did not enable CFI directives even though= I was compiling for a supported platform (x86_64): > checking whether assembler supports CFI directives... no I believe the issue is that configure tests for "tools/add-cfi.$ARCH.awk" i= nstead of "$srcdir/tools/add-cfi.$ARCH.awk". Changing configure as describe= d resolves this and I've confirmed the debugging information is present in = resulting binary. > checking whether assembler supports CFI directives... yes Below is a patch for this change.=20 Regards, Wesley Wiser [1]: https://github.com/richfelker/musl-cross-make --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index e1aefed7..ca5cbc0b 100755 --- a/configure +++ b/configure @@ -409,7 +409,7 @@ test "$debug" =3D yes && CFLAGS_AUTO=3D-g # printf "checking whether we should preprocess assembly to add debugging in= formation... " if fnmatch '-g*|*\ -g*' "$CFLAGS_AUTO $CFLAGS" && - test -f "tools/add-cfi.$ARCH.awk" && + test -f "$srcdir/tools/add-cfi.$ARCH.awk" && printf ".file 1 \"srcfile.s\"\n.line 1\n.cfi_startproc\n.cfi_endproc" |= $CC -g -x assembler -c -o /dev/null 2>/dev/null - then ADD_CFI=3Dyes -- 2.30.2