mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Wesley Wiser <wesleywiser@microsoft.com>
To: "musl@lists.openwall.com" <musl@lists.openwall.com>
Subject: [musl] RE: [PATCH] fix: Use $srcdir in configure test for add-cfi script
Date: Fri, 7 Jan 2022 18:02:57 +0000	[thread overview]
Message-ID: <BL0PR2101MB10735149BB2039EA271DDB7BAA4D9@BL0PR2101MB1073.namprd21.prod.outlook.com> (raw)
In-Reply-To: <BL0PR2101MB10730CDC27981CA9D04DF969AABF9@BL0PR2101MB1073.namprd21.prod.outlook.com>

On Thu, Oct 21, 2021 at 04:09:30PM -0400, Wesley Wiser wrote:
> I noticed while building musl with musl-cross-make[1] that adding --enable-debug to the MUSL_CONFIG variable did not enable CFI directives even though I was compiling for a supported platform (x86_64):
> I believe the issue is that configure tests for "tools/add-cfi.$ARCH.awk" instead of "$srcdir/tools/add-cfi.$ARCH.awk". Changing configure as described resolves this and I've confirmed the debugging information is present in resulting binary.
> Below is a patch for this change. 

Hello all,

Just wanted to follow up and see if there was any feedback on this patch. I can confirm it does resolve the described issue.

Thanks!
Wesley

  reply	other threads:[~2022-01-07 18:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 16:09 [musl] " Wesley Wiser
2022-01-07 18:02 ` Wesley Wiser [this message]
2022-01-07 18:32   ` [musl] " Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BL0PR2101MB10735149BB2039EA271DDB7BAA4D9@BL0PR2101MB1073.namprd21.prod.outlook.com \
    --to=wesleywiser@microsoft.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).