From: "Érico Nogueira" <ericonr@disroot.org>
To: <musl@lists.openwall.com>, <musl@lists.openwall.com>
Subject: Re: [musl] [PATCH 2/2] sbsiglist: fix typo when checking cli args.
Date: Sat, 07 Nov 2020 17:51:56 -0300 [thread overview]
Message-ID: <C6XBUQQYMHAE.20L92X5AYINU8@mussels> (raw)
In-Reply-To: <20201107065143.10191-2-ericonr@disroot.org>
Sorry for the noise, I didn't pay attention while git-send-email'ing and
this ended up on the wrong ML.
On Sat Nov 7, 2020 at 12:51 AM -03, Érico Nogueira wrote:
> From: Érico Rolim <erico.erc@gmail.com>
>
> type_str was being checked twice, and owner_guid_str wasn't checked at
> all. This lead to a possible segfault when only --owner was missing from
> the command line arguments.
> ---
> src/sbsiglist.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/sbsiglist.c b/src/sbsiglist.c
> index 7d396fa..aada63a 100644
> --- a/src/sbsiglist.c
> +++ b/src/sbsiglist.c
> @@ -241,7 +241,7 @@ int main(int argc, char **argv)
> return EXIT_FAILURE;
> }
>
> - if (!type_str) {
> + if (!owner_guid_str) {
> fprintf(stderr, "No owner specified\n");
> usage();
> return EXIT_FAILURE;
> --
> 2.29.2
prev parent reply other threads:[~2020-11-07 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 6:51 [musl] [PATCH 1/2] sbsiglist: add information about short options Érico Nogueira
2020-11-07 6:51 ` [musl] [PATCH 2/2] sbsiglist: fix typo when checking cli args Érico Nogueira
2020-11-07 20:51 ` Érico Nogueira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6XBUQQYMHAE.20L92X5AYINU8@mussels \
--to=ericonr@disroot.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).