From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 23212 invoked from network); 7 Nov 2020 20:52:34 -0000
Received: from mother.openwall.net (195.42.179.200)
  by inbox.vuxu.org with ESMTPUTF8; 7 Nov 2020 20:52:34 -0000
Received: (qmail 11749 invoked by uid 550); 7 Nov 2020 20:52:29 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
List-ID: <musl.lists.openwall.com>
Reply-To: musl@lists.openwall.com
Received: (qmail 11724 invoked from network); 7 Nov 2020 20:52:28 -0000
X-Virus-Scanned: Debian amavisd-new at disroot.org
Content-Transfer-Encoding: quoted-printable
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
	t=1604782336; bh=CcHiTAW/64wFRYfnREgDt+TCAsnZqStnPcVn3X1EwxE=;
	h=Subject:From:To:Date:In-Reply-To;
	b=jIFkp7ujWttXJRGt+ZXjrW8X246nmJqqjfiWQL9ZSCn2JufgFQZ8mQxNX4qIQUEia
	 e5IHsjJpl4YizG0Odrx1wLsWdq4bkheXk4khnLwotJZljtfoqoRjGW5OcytfnkDIZw
	 Ig0JArpASF6KE/evSu2+yW8LCLGed+hlZQjSV6zU4Kv1J6cv5bdldD1QQ1KR/Goyhb
	 GvJCEFA+0LzJjuC5guYDa571UiEwgsD/EJXob4TFi7JCzmJvOq0ZwP2Ljs68qM1c/a
	 MKD6kSFZ/GVhYtbkOHHEKoSpfeUrGRFR08+EdWPnJL4kGUUtnqxWA8B/X228dkEql0
	 NSeAM0QFWbz/w==
Content-Type: text/plain; charset=UTF-8
From: =?utf-8?q?=C3=89rico_Nogueira?= <ericonr@disroot.org>
To: <musl@lists.openwall.com>, <musl@lists.openwall.com>
Date: Sat, 07 Nov 2020 17:51:56 -0300
Message-Id: <C6XBUQQYMHAE.20L92X5AYINU8@mussels>
In-Reply-To: <20201107065143.10191-2-ericonr@disroot.org>
Subject: Re: [musl] [PATCH 2/2] sbsiglist: fix typo when checking cli args.

Sorry for the noise, I didn't pay attention while git-send-email'ing and
this ended up on the wrong ML.

On Sat Nov 7, 2020 at 12:51 AM -03, =C3=89rico Nogueira wrote:
> From: =C3=89rico Rolim <erico.erc@gmail.com>
>
> type_str was being checked twice, and owner_guid_str wasn't checked at
> all. This lead to a possible segfault when only --owner was missing from
> the command line arguments.
> ---
> src/sbsiglist.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/sbsiglist.c b/src/sbsiglist.c
> index 7d396fa..aada63a 100644
> --- a/src/sbsiglist.c
> +++ b/src/sbsiglist.c
> @@ -241,7 +241,7 @@ int main(int argc, char **argv)
> return EXIT_FAILURE;
> }
> =20
> - if (!type_str) {
> + if (!owner_guid_str) {
> fprintf(stderr, "No owner specified\n");
> usage();
> return EXIT_FAILURE;
> --
> 2.29.2