From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 7516 invoked from network); 30 Nov 2020 15:20:42 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 30 Nov 2020 15:20:42 -0000 Received: (qmail 8069 invoked by uid 550); 30 Nov 2020 15:20:38 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 8051 invoked from network); 30 Nov 2020 15:20:37 -0000 X-Virus-Scanned: Debian amavisd-new at disroot.org Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1606749623; bh=tP3OwdEYw4XBr37ZwnQHThG08TfxeqKfw70+FhqBs7I=; h=Subject:From:To:Date:In-Reply-To; b=DI/9zWqEy1+oKqtzR0C14SZ49ZzEu5esYbR91Dif5YUe3wYBgMRDJI1CB+XDYjQdd KCHUPzWTp05AVSSHI3c/pHw0cGk3Pr/GT3n3nCbbslvcG7TSlkSt6QeXL2E7YE4m96 tAAX/lcTmwGSRKyI8/EuTz8F2H16bu4+Z3bqcds1RwBcM7Tm5hTDKfmjk2rHTn9Ymr QJRoPctEQAAFnvBQHpb1rBHH30iyWFVzrhLrp/zqcC/MYShcMSLfaWfHcTNg/U8nf3 7RpQ2aYba0L1TwRr2nFWRXDJXQJqdDpz7afq32qyj1E0QXLyR/BMVeZPy4sPBp55XL M5MXedJjlehVg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 From: =?utf-8?q?=C3=89rico_Nogueira?= To: "Samuel Holland" , , "Dong Brett" Date: Mon, 30 Nov 2020 12:12:50 -0300 Message-Id: In-Reply-To: <551d3310-039f-23c4-608e-5e15e625f638@sholland.org> Subject: Re: [musl] Question on C++ locale On Mon Nov 30, 2020 at 11:39 AM -03, Samuel Holland wrote: > On 11/30/20 7:44 AM, =C3=89rico Nogueira wrote: > > On Mon Nov 30, 2020 at 8:35 AM -03, Szabolcs Nagy wrote: > >> * Dong Brett [2020-11-30 18:41:33 > >> +0800]: > >>> However, the following C++ code does not work (our software uses std:= :locale in C++ standard library for locale related stuff): > >>> #include > >>> #include > >>> #include > >>> using namespace std; > >>> int main() > >>> { > >>> std::locale::global(locale("")); > >>> initscr(); > >>> printw("LC_ALL: %s\n", setlocale(LC_ALL, NULL)); > >>> printw("C++ locale: %s\n", locale().name().c_str()); > >>> printw("CODESET: %s\n", nl_langinfo(CODESET)); > >>> printw("Hello, world!\n"); > >>> printw("=E4=BD=A0=E5=A5=BD=EF=BC=8C=E4=B8=96=E7=95=8C!\n"); > >>> refresh(); > >>> getch(); > >>> endwin(); > >>> return 0; > >>> } > >> > >> fwiw for me even the first line fails. > >> i don't know how c++ locales are supposed to work. > >=20 > > From [1], it seems that C++ locales are supposed to affect the global > > locale as well, so they should call setlocale() when appropriate. > >=20 > > - [1] https://www.cplusplus.com/reference/locale/locale/ > >=20 > > Unfortunately, I assume libstdc++ uses their generic locale support on > > musl... From gcc-10.2.0/libstdc++-v3/config/locale/generic/c_locale.cc= : > >=20 > > void > > locale::facet::_S_create_c_locale(__c_locale& __cloc, const char* __s= , > > __c_locale) > > { > > // Currently, the generic model only supports the "C" locale. > > // See http://gcc.gnu.org/ml/libstdc++/2003-02/msg00345.html > > __cloc =3D 0; > > if (strcmp(__s, "C")) > > __throw_runtime_error(__N("locale::facet::_S_create_c_locale " > > "name not valid")); > > } > >=20 > > I don't know for sure that it's the right thing to do, but I have been > patching > out that error for the last several years[1] and so far I have not > noticed any > negative effects. Adelie, which is very thorough about testing, has also > carried > the patch for a while[2]. > > Samuel > > [1]: > https://github.com/smaeul/portage/blob/c744774a/patches/sys-devel/gcc/gcc= -5.4.0-locale.patch > [2]: https://code.foxkit.us/adelie/packages/-/commit/d09b437d Are those patches correct in functionality? The GNU version is: void locale::facet::_S_create_c_locale(__c_locale& __cloc, const char* __s, __c_locale __old) { __cloc =3D __newlocale(1 << LC_ALL, __s, __old); if (!__cloc) { // This named locale is not supported by the underlying OS. __throw_runtime_error(__N("locale::facet::_S_create_c_locale " "name not valid")); } } It tries to create a locale object, which the generic code doesn't do. In the generic case, _S_create_c_locale is basically a noop, and I'd assume localization wouldn't work, even if it does avoid the runtime abort. I will try it out locally when I get the time.