From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14661 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Brion Vibber Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] Allow %lf in wprintf Date: Wed, 11 Sep 2019 23:09:03 -0700 Message-ID: Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000001df92f059254fa97" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="207842"; mail-complaints-to="usenet@blaine.gmane.org" To: musl@lists.openwall.com Original-X-From: musl-return-14677-gllmg-musl=m.gmane.org@lists.openwall.com Thu Sep 12 08:09:30 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1i8IIM-000ryG-84 for gllmg-musl@m.gmane.org; Thu, 12 Sep 2019 08:09:30 +0200 Original-Received: (qmail 7341 invoked by uid 550); 12 Sep 2019 06:09:27 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 7304 invoked from network); 12 Sep 2019 06:09:26 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wikimedia.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=a0TqVg8Z5IO+OmXKWlEd8QTU9vN+aYSIYS6pb5+wTig=; b=Q2WfTWf6567RND+0nbMVK76TunWoEVB4hyDk7++dos/afWFp8qJXmA9AmlhKv6QOph R9r6rYIJywYuvZb5dWRTbOkaj8YyXIyuezDYbI6KirhQVV1xRBnSME9WM+ZBEPaQdUGa oYJn0M+mYKrjui1+A7fQbAJgQxaMnZJI/ZML8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=a0TqVg8Z5IO+OmXKWlEd8QTU9vN+aYSIYS6pb5+wTig=; b=V3Sa+Yqfir1NQiW8bB6TLQNa2Nbfdjp42cPoc1eYSD4wkEc4emNNmRe6Ez85qMyih7 JvaSWvyD5GJ+LJub1PgMrVZzXTmnsQGczDSdgDjVMvI9FXDlkjAGWds4qoBiLnnP5sI3 sL/9bSOq27wsI33v0YR3fU0s65bwFcPYcWLwwYjnr4Fp/PrzATbR6Ypg6hK+U30apl9r jQtDXjTNGpFv8ay7g2TDaBaUmZ/oRGZ4TEpP8R9dXuBHJ6vK0PILaNROnSgNsNl463tc C1IZ5+1BbKXaxn4krCOSo/HxOHWarC2N6SHjgIbX8a2c1HYIlaEm5VbVluAOOtjurQt+ IZsQ== X-Gm-Message-State: APjAAAXHiF1idOOf1Ivu91PTKWP0SP2r7wd7CqPPBCE0yJ0EwZPUZEe9 AjLoC3OvF849ozng23Z+5TpTZK6dCQ3Vh9J6QkzHPIwyomy+YA== X-Google-Smtp-Source: APXvYqytCM7swArI3W5K0pkqiiBjzLIwekS4G0kWfBTLMRK1oGrUrdytlY9mH40itE7K4il7fe+oDDcukKFDICaIXNQ= X-Received: by 2002:a17:906:3e46:: with SMTP id t6mr33498110eji.104.1568268554714; Wed, 11 Sep 2019 23:09:14 -0700 (PDT) Xref: news.gmane.org gmane.linux.lib.musl.general:14661 Archived-At: --0000000000001df92f059254fa97 Content-Type: multipart/alternative; boundary="0000000000001df92d059254fa95" --0000000000001df92d059254fa95 Content-Type: text/plain; charset="UTF-8" On the emscripten mailing list we got a report that using %lf as a format specifier for doubles worked in printf but not wprintf, which I was able to confirm looking at the musl implementation we're using. It looks like support for %lf in printf was added in 2012 in commit cc3a44666, but didn't get copied to the wprintf implementation so they're just out of sync. I've attached a small patch which copies the same fix to the wprintf side. Please let me know if there's any test cases I should add to, or anything else. Thanks! -- brion --0000000000001df92d059254fa95 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On the emscripten mailing list we got a report that using = %lf as a format specifier for doubles worked in printf but not wprintf, whi= ch I was able to confirm looking at the musl implementation we're using= .

It looks like support for %lf in printf was added in 2= 012 in commit=C2=A0cc3a44666, but didn't get copied to the wprintf impl= ementation so they're just out of sync. I've attached a small patch= which copies the same fix to the wprintf side.

Pl= ease let me know if there's any test cases I should add to, or anything= else. Thanks!

-- brion
--0000000000001df92d059254fa95-- --0000000000001df92f059254fa97 Content-Type: application/octet-stream; name="0001-Fix-lf-in-wprintf.patch" Content-Disposition: attachment; filename="0001-Fix-lf-in-wprintf.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k0gagaqm0 RnJvbSAxNjlhZWFjMzQzNTUyYzlhNWY1MmRmMGYzOThjODQzNzBjZTY4YzQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcmlvbiBWaWJiZXIgPGJyaW9uQHBvYm94LmNvbT4KRGF0ZTog V2VkLCAxMSBTZXAgMjAxOSAyMjo0MzozNCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCAlbGYg aW4gd3ByaW50ZgoKVGhpcyB3YXMgZml4ZWQgZm9yIHByaW50ZiBpbiAyMDEyIHZpYSBjYzNhNDQ2 NjY7IHRvb2sKdGhlIHNhbWUgZml4IGFuZCBhcHBsaWVkIGl0IHRvIHdwcmludGYgaGVyZSBzbyB0 aGV5Cm1hdGNoLgoKUHJldmlvdXNseSwgJWxmIGNhdXNlZCBhIGZhaWx1cmUgdG8gb3V0cHV0Lgot LS0KIHNyYy9zdGRpby92ZndwcmludGYuYyB8IDIgKysKIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9zcmMvc3RkaW8vdmZ3cHJpbnRmLmMgYi9zcmMvc3RkaW8v dmZ3cHJpbnRmLmMKaW5kZXggMGFkZjBiN2EuLjg1YjAzNmMzIDEwMDY0NAotLS0gYS9zcmMvc3Rk aW8vdmZ3cHJpbnRmLmMKKysrIGIvc3JjL3N0ZGlvL3Zmd3ByaW50Zi5jCkBAIC01Myw2ICs1Myw4 IEBAIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBjaGFyIHN0YXRlc1tdWyd6Jy0nQScrMV0gPSB7CiAJ fSwgeyAvKiAxOiBsLXByZWZpeGVkICovCiAJCVMoJ2QnKSA9IExPTkcsIFMoJ2knKSA9IExPTkcs CiAJCVMoJ28nKSA9IFVMT05HLCBTKCd1JykgPSBVTE9ORywgUygneCcpID0gVUxPTkcsIFMoJ1gn KSA9IFVMT05HLAorCQlTKCdlJykgPSBEQkwsIFMoJ2YnKSA9IERCTCwgUygnZycpID0gREJMLCBT KCdhJykgPSBEQkwsCisJCVMoJ0UnKSA9IERCTCwgUygnRicpID0gREJMLCBTKCdHJykgPSBEQkws IFMoJ0EnKSA9IERCTCwKIAkJUygnYycpID0gSU5ULCBTKCdzJykgPSBQVFIsIFMoJ24nKSA9IFBU UiwKIAkJUygnbCcpID0gTExQUkUsCiAJfSwgeyAvKiAyOiBsbC1wcmVmaXhlZCAqLwotLSAKMi4y MC4xCgo= --0000000000001df92f059254fa97--