From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12891 Path: news.gmane.org!.POSTED!not-for-mail From: Phillip Berndt Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Fix TLS layout of TLS variant I when there is a gap above TP Date: Mon, 4 Jun 2018 09:27:19 +0200 Message-ID: References: <20180601235201.GO4418@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1528097131 24239 195.159.176.226 (4 Jun 2018 07:25:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 4 Jun 2018 07:25:31 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-12907-gllmg-musl=m.gmane.org@lists.openwall.com Mon Jun 04 09:25:27 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fPjro-0006AV-PV for gllmg-musl@m.gmane.org; Mon, 04 Jun 2018 09:25:24 +0200 Original-Received: (qmail 6044 invoked by uid 550); 4 Jun 2018 07:27:32 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 6023 invoked from network); 4 Jun 2018 07:27:31 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=hu6YLl9LDjUk679fQo6L2VIybHlxdDpFlmEq9fQGpdw=; b=b8IuQLOcNWnKRErQoPL8qegbsmVq34nwPZbenXFEmYumEukQv5Rg7sVX62sCm1oC32 mPgYHPr+nBQlExB9JXM2O8AhbLpMCqmhfHlbCS8HKNStHxS5UryXKS/rId8qKbJ56pMv 5TZiHVo5yr3vnxZLOyZmc0YI9v1OyeRnK61irbpCf306m/h8OjHhMd7bs2sSKERiwEob k7aYn7b3Djjj9ZhyC8AG/CrM3DslVmxpNjFNl1/WnU5+ykhYRTkaWnMurFWWIMAGYjx1 kUe2i6y3b3oy0eXdK689qc+rrDjm+oohSsWffOgdDnWyPkoME2i5BRcPKzduNdARx0xZ 6c3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=hu6YLl9LDjUk679fQo6L2VIybHlxdDpFlmEq9fQGpdw=; b=FLbqSDeY14/0VMdwgDTS6bOighEM6KEjL2gy1uqEPYu9xD3JDvc7ECDXViF/olNV/g 47r57uB/GoVvOpZ/ALc5PTl/niRepxshY8h4jpPWGrWCQNyeaWFvRk0XtxJ/cviHa05k nM7fUqq7xaou89YNpQf6uCpKLZwm+8fkfpnqO7Bc+9s57wTk5jTIKH3+e0nqHvsJQBMB bRkLhsw+vU85+6W7EPoVjMg5tWxIEkc8NJkqxOmBbxjmLLBo6x/aNbJcbz7eTBlRoZhJ ZC1ygNgr/6IbQzj97mH1GLfGFh+jr+CwjryxZsei77E94Z7BPhfI6HjOWPZMPxp8t4Jt Vufg== X-Gm-Message-State: ALKqPwe+4Ru4U9pYnRN0jyPkk4j30zg0uotu46+x8DWxJT623URfRHuY 84GZOV7NvYeQH+5T3oA450ERfLEOrv/CwifZE2FlgA== X-Google-Smtp-Source: ADUXVKIx/hNjIWmQqXOThThOKkZpOnQKW4pC46RuVntREqwZfKk17z8oQM0+mC+ezrEiB+EdQpty7Jula0Ynu4iy5c0= X-Received: by 2002:a19:de0a:: with SMTP id v10-v6mr11514942lfg.94.1528097239945; Mon, 04 Jun 2018 00:27:19 -0700 (PDT) In-Reply-To: <20180601235201.GO4418@port70.net> Xref: news.gmane.org gmane.linux.lib.musl.general:12891 Archived-At: 2018-06-02 1:52 GMT+02:00 Szabolcs Nagy : > The fix required changing TP_ADJ and __pthread_self on affected > targets (aarch64, arm and sh) and in the tlsdesc asm the offset to > access the dtv changed too. > --- > passed my simple local-exec tests. Confirmed working on real aarch64, too. Awesome work, thanks a lot! (The issue with symbols across different shared objects reusing the same TLS addresses turned out to be on my end: I forgot to compile these tests as -fPIC..) - Phillip