From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12907 Path: news.gmane.org!.POSTED!not-for-mail From: Phillip Berndt Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Fix TLS layout of TLS variant I when there is a gap above TP Date: Mon, 11 Jun 2018 21:02:51 +0200 Message-ID: References: <20180601235201.GO4418@port70.net> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1528743660 27915 195.159.176.226 (11 Jun 2018 19:01:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 11 Jun 2018 19:01:00 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-12923-gllmg-musl=m.gmane.org@lists.openwall.com Mon Jun 11 21:00:56 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fSS3j-0007CN-RN for gllmg-musl@m.gmane.org; Mon, 11 Jun 2018 21:00:55 +0200 Original-Received: (qmail 28473 invoked by uid 550); 11 Jun 2018 19:03:04 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 28455 invoked from network); 11 Jun 2018 19:03:03 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=zDHrsyj7szr1OKircLXfdr62cRq6r1OlS7iZhG1uv4s=; b=KAwsjpcmESZTU20csiX2UZO122+9Zo6/pPubsRh8oLmei56Zy5UJj2Kn2XFcezuKSv 6Mp4CQmdIytJOHR6HERjC0B6JxYOhhb1q1EdzcB9RvMXl3P3NHk4Vzv+Wp9bMXw9dDii 2ZgGQJ66OKfUm9ytf+1sFYyP4Kg/yMENUgWZvGzcWeWK8ac+3k2MeL0Luu4D7dJk6CuL BwXiYpah1G6lciiMR9B41i4VazP8OAVXmhJcGUFMkw+8xDJx3OmIogkbsMkvNORhkcEj Pc3AzcCoZ4o7iPtYdFAVxLhekfX07r4whKWfMsV8JI+rNdKMIE0fnjl2MNJRA+vxD2YZ ND+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=zDHrsyj7szr1OKircLXfdr62cRq6r1OlS7iZhG1uv4s=; b=AOZAL0HBj3BZr47GhxkA6O8VCrv9zSzKEsbCAHk93r9lHG3e+DDShwOtjAMmlSttIZ Mzn8tdJ2DsOjMQ3uUcwGP7D6/TCrOMdJDUthf4VWZ17qWSy3T0J4iNXlHnoOkh1v55Xf GRxrqBC65B2FEyukLUICoO6NxY/NFb12yXMp078TJN0VD1KLhvkBLucGJjsmUifGk4ZG m1+z6hbNDUVZaTQXrMsHSIhguCIZ4rt0sqm9tBKqeR2WLGmDw+T9zLGqKy9V1U6PY5q5 rBlAWsdChwJEvjmcTsIYYNbWqxhcIZ4RtlkAfuLNPVlllowX9k3esQq3WNrKPLwKPdhU R77A== X-Gm-Message-State: APt69E3i6zKbFCsAbYsT56hjOTQoG3487qbj8ooRKhfXahhu83l21jb6 sCFpvIeLIllqCcrnrJjaV52KwKO57m6Te79RKXV99F15 X-Google-Smtp-Source: ADUXVKK7BDpAk65BEcJt+8wKHx9guLWQQBcwiEhteLW84vHNmgOQBCZFrc4yseOHuuvFzU310VMzLf6nOnqlbs0+a+8= X-Received: by 2002:a19:5c94:: with SMTP id u20-v6mr206991lfi.138.1528743772152; Mon, 11 Jun 2018 12:02:52 -0700 (PDT) In-Reply-To: Xref: news.gmane.org gmane.linux.lib.musl.general:12907 Archived-At: 2018-06-04 9:27 GMT+02:00 Phillip Berndt : > 2018-06-02 1:52 GMT+02:00 Szabolcs Nagy : >> The fix required changing TP_ADJ and __pthread_self on affected >> targets (aarch64, arm and sh) and in the tlsdesc asm the offset to >> access the dtv changed too. >> --- >> passed my simple local-exec tests. > > > Confirmed working on real aarch64, too. Awesome work, thanks a lot! > Got an opportunity to test this on real 32-bit arm hardware, fixes the issue there for me as well. Any news on the review & merge of the patch? Best, Phillip