mailing list of musl libc
 help / color / mirror / code / Atom feed
From: William Pitcock <nenolod@dereferenced.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] resolv.conf parser: concatenate multiple search domain lines
Date: Fri, 30 Mar 2018 13:54:11 -0500	[thread overview]
Message-ID: <CA+T2pCH5sYdmxNUBCD1vyaqMvpBHoYNGEs4dxbTAduX+d56aSw@mail.gmail.com> (raw)
In-Reply-To: <20180330132125.GQ1436@brightrain.aerifal.cx>

Hello,

On Fri, Mar 30, 2018 at 8:21 AM, Rich Felker <dalias@libc.org> wrote:
> On Fri, Mar 30, 2018 at 02:27:42PM +0200, Quentin Rameau wrote:
>> Hi William,
>>
>> > Programs such as Docker and Kubernetes write multiple domain search
>> > lines, such as
>> >
>> > search serious-business.big-data.prod.foo.com
>> > search big-data.prod.foo.com
>> > search prod.foo.com
>> >
>> > instead of
>> >
>> > search serious-business.big-data.prod.foo.com big-data.prod.foo.com
>> > prod.foo.com
>> >
>> > Accordingly, we concatenate the namelist together so that the search
>> > path is not truncated.
>>
>> I think this patch should be sent to Docker and Kubernetes instead of
>> pushing a mitigation for their bug in the libc.
>>
>> According to documentation, “The domain and search keywords are
>> mutually exclusive.  If more than one instance of these keywords is
>> present, the last instance wins.”
>>
>> This patch would break existing applications relying on documented
>> behaviour.
>
> I wrote the current behavior based on that documentation. Apparently
> the current glibc behavior does not match the documentation, but I'd
> really rather not go against the documentation unless there's
> agreement from glibc/others that the documentation is wrong and their
> current behavior is desired. Either way I think Docker/Kubernetes
> should fix this, since it's ambiguous what the "right" thing to do is
> and there very well could end up being inconsistent behaviors between
> libcs/versions into the future.

It turns out this problem has been fixed a while ago.  The actual
problem is something else, which I was able to reproduce.
I sent a patch for it, too.

William


      reply	other threads:[~2018-03-30 18:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30 10:51 William Pitcock
2018-03-30 12:27 ` Quentin Rameau
2018-03-30 13:21   ` Rich Felker
2018-03-30 18:54     ` William Pitcock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+T2pCH5sYdmxNUBCD1vyaqMvpBHoYNGEs4dxbTAduX+d56aSw@mail.gmail.com \
    --to=nenolod@dereferenced.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).