From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_MSPIKE_H2 autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 8704 invoked from network); 11 Apr 2023 14:39:25 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 11 Apr 2023 14:39:25 -0000 Received: (qmail 30181 invoked by uid 550); 11 Apr 2023 14:39:21 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 30129 invoked from network); 11 Apr 2023 14:39:20 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1681223948; x=1683815948; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=IC+f5O3BQ+Pny2QGwML412c5nuSzlcfmspy5Plzihzc=; b=ah9H6tH98xLcksPAJvxg9xwQ2OFMc/JSqjIWcrmNlFOiVWEeFrTbvM37AGutheFY7L YAuu+ArWGfknv5OhZgnbAqK9nXH5RXHf5xmp1rkA9m+LXJHtbkSe9aCkz7vVCDmMe7IT nF8pCwSMnONXoq9vnjcLYqM4OVad/Z6scy0sEoM0BMpzO8Q2vXGTV43za1h04ePPryYF c2O6nXLi4DjjpYQZQieRbg4/yijVF0RN1TDZrM+PnXSz7NnSos0N1ttKxhsPpUyfbExY TLeWiDT7DfHO5AojjoJQPMuNg/h26DaFRtVg1k725zdyHiWUoyX76f7ZRiEVYiLi/xMS 6DLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681223948; x=1683815948; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IC+f5O3BQ+Pny2QGwML412c5nuSzlcfmspy5Plzihzc=; b=uiTyJG1lJzcANUgS07YCt4fTw1yjcyJM2ge/0XhrO9ecahJmeArhSAtoJz2bLETonB GdKElAk93pBQTnt6T99MQ9SA+WDOtZAcrsC6KNIiY7mv3QeSTRZnAO9VJX3/2O0qcS8v tFFD5kSIxam6TiTzNJRdRyNztvEWevo1RPIMTOvghmDWJ6NImYQHHeGkSVKZLCodvUGb Ll26JJXbGlbVoqn/7N3PrG1cK9X/G+oeNjFCUFoiHLVKM//q2NAk3XqMM8LBgNOFdUFM +6KUIaoborsY51IxJhZkDycvCF+IiUqJDoPhOZXb6jPBQakpHdlfvh5ih3rit9dAuljK 46Wg== X-Gm-Message-State: AAQBX9fF1mh6xrzjq9SZWW5/z5jjBBuGX5WBdvNZum9Yvg9VdpG7V8f9 RjS8VR4zct6I7h9LhVY30SB8HFTH+iORmGIVZEhsxaG9f3c= X-Google-Smtp-Source: AKy350YL7HIScauITrss76IOVY2heSSjfOnebtK9qejYD9yF1CMYgpKILigV+XSjsF1Bk4+SfwZwqh9qZO/6asLAUmc= X-Received: by 2002:ab0:5481:0:b0:769:593d:b7ec with SMTP id p1-20020ab05481000000b00769593db7ecmr1762178uaa.2.1681223947713; Tue, 11 Apr 2023 07:39:07 -0700 (PDT) MIME-Version: 1.0 References: <20230401050823.2341924-1-matthias.goergens@gmail.com> <20230411143231.GL4163@brightrain.aerifal.cx> In-Reply-To: <20230411143231.GL4163@brightrain.aerifal.cx> From: =?UTF-8?Q?Matthias_G=C3=B6rgens?= Date: Tue, 11 Apr 2023 22:38:57 +0800 Message-ID: To: musl@lists.openwall.com Content-Type: multipart/alternative; boundary="0000000000003101fb05f910743a" Subject: Re: [musl] [PATCH v3] Fix UB in getmntent_r on extremely long lines --0000000000003101fb05f910743a Content-Type: text/plain; charset="UTF-8" On Tue, 11 Apr 2023, 22:32 Rich Felker, wrote: > Can you do this as a one-line change to restart the loop like I > suggested? I know the resulting code arguably isn't as pretty to folks > with an allergy to gotos, but the more important aspect is that the > change history is clear and obvious to anyone who wants to read it, to > see that no change except the one described is being made by the > patch. > Thanks for the quick response on the channel! Sure, I can use the goto, if you prefer that. Btw, I agree that the diff with the loop looks a bit big in the email. But when you look at it with `git show --ignore-all-space` it's about the same size of diff as the goto. (And that's how I typically review history of a repository.) > --0000000000003101fb05f910743a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, 11 Apr 2023, 22:32 Rich Felker, <dalias@libc.org> wrote:
Can you do this as a one-line change to restart the loop like I
suggested? I know the resulting code arguably isn't as pretty to folks<= br> with an allergy to gotos, but the more important aspect is that the
change history is clear and obvious to anyone who wants to read it, to
see that no change except the one described is being made by the
patch.

Thanks for the quick response on the channel!
=
Sure, I can use the goto, if you prefer that.

Btw, I agree that the dif= f with the loop looks a bit big in the email. But when you look at it with = `git show --ignore-all-space` it's about the same size of diff as the g= oto. (And that's how I typically review history of a repository.)
=
--0000000000003101fb05f910743a--