mailing list of musl libc
 help / color / mirror / code / Atom feed
From: ardi <ardillasdelmonte@gmail.com>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: [musl] Do you recommend using fmt_fp() and
Date: Tue, 30 Aug 2022 12:17:50 +0200	[thread overview]
Message-ID: <CA+fZqCU0JtM1h_4yfWQgDmUv6Ln0JjB0tymDNzzPO1Kt9=M5dg@mail.gmail.com> (raw)
In-Reply-To: <20220823173020.GJ7074@brightrain.aerifal.cx>

On Tue, Aug 23, 2022 at 7:30 PM Rich Felker <dalias@libc.org> wrote:
>
> See how strtod.c uses sh_fromstring and how sh_fromstring does not
> define any io callbacks (so that calling __uflow would necessarily
> result in a call to a null or ununitialized function pointer). From
> that, it's clear that it must not be reachable (or the existing code
> in musl would be broken).

Thanks a lot. Understood. While in the process of adapting the code,
I came across the implementation of scalbnl(), and I'm not sure if
I found a mistake or if it's correct: lines 23 to 27 of src/math/scalbnl.c
use MANT_DIG but hardcode it as 113 both when long double is
binary128 and when it's 80bit extended (where MANT_DIG is 64).

By comparison, looking at the source of the scalbn() versions for
float and double, I'd say there's a mistake in the long double version,
but I've never written that function myself, so I'm not in a position
to affirm it for sure.

Kind regards, and thanks a lot,

César

  reply	other threads:[~2022-08-30 10:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18 15:51 ardi
2022-08-19  3:19 ` Rich Felker
2022-08-23 17:00   ` ardi
2022-08-23 17:30     ` Rich Felker
2022-08-30 10:17       ` ardi [this message]
2022-08-30 12:26         ` Rich Felker
2022-09-04 19:52           ` ardi
2022-09-04 21:59             ` Rich Felker
2022-09-05  8:49               ` ardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+fZqCU0JtM1h_4yfWQgDmUv6Ln0JjB0tymDNzzPO1Kt9=M5dg@mail.gmail.com' \
    --to=ardillasdelmonte@gmail.com \
    --cc=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).