From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 14850 invoked from network); 30 Aug 2022 10:18:20 -0000 Received: from second.openwall.net (193.110.157.125) by inbox.vuxu.org with ESMTPUTF8; 30 Aug 2022 10:18:20 -0000 Received: (qmail 20345 invoked by uid 550); 30 Aug 2022 10:18:15 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 20301 invoked from network); 30 Aug 2022 10:18:14 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=pS/r8jOT+SKG91rM0n+fQY1Kkcoy1XtJrfDty8WBlm8=; b=QX24MvycB4K3zBq3crnc+TP0rGrK+AilYAZkwQgJ0LhdsQd6KM7cC/tAWoqw9yRbS+ OETPAeINdh73Ds1swKEZiWYWGGfYF14OrGJqwyDzRGoi7Cgob6FmuLL6/SfYCLBj/xvG cF/bjzoPZXGuzvEXEnUmgIAaVx7fQUlspxp+xwxx4fuSTuh7kyGMqZlLRsWnTwqob8H2 L4vxSdAnyPKLfCdWKlX6cvsVSGpIReiMOIFFXfIDEPPTjtGZt1idOiatYnyNYoOvvZMR H2oO/7R30nvTsJi5K4knCm3qwePPzptmjw4zKbQQhIZdQgIPze8crcS3SQ3Gj77lXK73 7JEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=pS/r8jOT+SKG91rM0n+fQY1Kkcoy1XtJrfDty8WBlm8=; b=MDsNmoBylJC5cahSBRYOT6AyydEQt0YV0P0I+7yqsLgveY3LENPYwb2GU6bb07xmFe Ps5lMLeQG7OytnBMzEES88nCbswouWsTm9NeXf0rsi0UY8kGp8LIzbephHzSZkkQN+sd pCG/FaCBPcXS57VY8o4vpZoIiZzHS3PVGJipXNc0J0RPXDJH87HxG/Sr9Gd25vKWzjTi F+xt5JmaNclH0QV4FXdiKRec4aYc1YPEEgnqmib6gFVzRY9BAW9/UlLEY1RuNBsrbUWx p7uQAAU4pD8mqpBE8Alkb8TRCDfJOptlF/f8ZblUX0edLFe6cYxSnVli7VuSstDLqjPX VJdQ== X-Gm-Message-State: ACgBeo3Y7c9VfyrvaCWFfNCUY5Yds1GHxAwRaguEThBlnaRkhAs7RmZj U0RwEH91Vx+d/BodSbtC6FsQQ7ucbJmwvYj0TiU= X-Google-Smtp-Source: AA6agR5JzgH/HRU3+vqczc3ryqcU2KauAJIFwwg061g0VkNaxI9tPpnmMZsHalWpxJFdEcciy7nAtzz3gIXiC0QOiZ8= X-Received: by 2002:a05:6122:d86:b0:37d:3fe:df43 with SMTP id bc6-20020a0561220d8600b0037d03fedf43mr4480989vkb.15.1661854681423; Tue, 30 Aug 2022 03:18:01 -0700 (PDT) MIME-Version: 1.0 References: <20220819031934.GH7074@brightrain.aerifal.cx> <20220823173020.GJ7074@brightrain.aerifal.cx> In-Reply-To: <20220823173020.GJ7074@brightrain.aerifal.cx> From: ardi Date: Tue, 30 Aug 2022 12:17:50 +0200 Message-ID: To: Rich Felker Cc: musl@lists.openwall.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [musl] Do you recommend using fmt_fp() and On Tue, Aug 23, 2022 at 7:30 PM Rich Felker wrote: > > See how strtod.c uses sh_fromstring and how sh_fromstring does not > define any io callbacks (so that calling __uflow would necessarily > result in a call to a null or ununitialized function pointer). From > that, it's clear that it must not be reachable (or the existing code > in musl would be broken). Thanks a lot. Understood. While in the process of adapting the code, I came across the implementation of scalbnl(), and I'm not sure if I found a mistake or if it's correct: lines 23 to 27 of src/math/scalbnl.c use MANT_DIG but hardcode it as 113 both when long double is binary128 and when it's 80bit extended (where MANT_DIG is 64). By comparison, looking at the source of the scalbn() versions for float and double, I'd say there's a mistake in the long double version, but I've never written that function myself, so I'm not in a position to affirm it for sure. Kind regards, and thanks a lot, C=C3=A9sar