From: Masanori Ogino <masanori.ogino@gmail.com>
To: musl@lists.openwall.com
Subject: Re: [PATCH] Define LONG_DOUBLE_IS_* internal macros.
Date: Tue, 8 Mar 2016 14:45:38 +0900 [thread overview]
Message-ID: <CAA-4+jfYeRLqTaMaqt6a3R91hM0wtkpLHQzTaEewUX4RJubDAA@mail.gmail.com> (raw)
In-Reply-To: <20160308050527.GA9349@brightrain.aerifal.cx>
2016-03-08 14:05 GMT+09:00 Rich Felker <dalias@libc.org>:
> On Tue, Mar 08, 2016 at 11:38:15AM +0900, OGINO Masanori wrote:
>> These macros indicate which format is used for long double with the
>> toolchain.
>>
>> Although the meaning of "LDBL_DIG_MANT == 64 && LDBL_MAX_EXP == 16384"
>> is very clear to floating-point arithmetic guys, it is nice to have
>> descriptive names to such conditions.
>
> I understand where you're coming from but I think this is opposite to
> the style preferences in musl, which are to avoid dependence on
> internal things and directly use portable conditions based on public
> interfaces where possible. The existing tests are all completely valid
> even outside musl, without depending on any musl-internal stuff. If
> the intent is not clear, perhaps some simple comments would suffice?
OK, now I understood that. I think original code is clear enough; it
seems just a matter of taste.
Thank you for your advice.
--
Masanori Ogino
prev parent reply other threads:[~2016-03-08 5:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 2:38 OGINO Masanori
2016-03-08 5:05 ` Rich Felker
2016-03-08 5:45 ` Masanori Ogino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA-4+jfYeRLqTaMaqt6a3R91hM0wtkpLHQzTaEewUX4RJubDAA@mail.gmail.com \
--to=masanori.ogino@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).