From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/9525 Path: news.gmane.org!not-for-mail From: Masanori Ogino Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Define LONG_DOUBLE_IS_* internal macros. Date: Tue, 8 Mar 2016 14:45:38 +0900 Message-ID: References: <1457404695-17281-1-git-send-email-masanori.ogino@gmail.com> <20160308050527.GA9349@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1457415957 13331 80.91.229.3 (8 Mar 2016 05:45:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 05:45:57 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-9538-gllmg-musl=m.gmane.org@lists.openwall.com Tue Mar 08 06:45:56 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1adASw-0008L0-Sq for gllmg-musl@m.gmane.org; Tue, 08 Mar 2016 06:45:54 +0100 Original-Received: (qmail 5979 invoked by uid 550); 8 Mar 2016 05:45:51 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 5958 invoked from network); 8 Mar 2016 05:45:50 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to; bh=BWye1NOzZbho/gY4C8Fh+ew22gda6RwCJbK2H35XJws=; b=PfEwbQ0548dD4GHqiq/gUxHzv6l7zSgzrDfbyzCY7D1CzlfXipob/XCWaMKaavExsp wRPLyr+PIYy0SfoCszVv7jW65GJlwAf0f24d7ohw9h+wX6z3sx8jWlAmSgSi/wnRDMir fTbO+N8ah8ltDpWhO/4QWwPj3YWO+AOT7sNPAAwdF+4XLqoRvdjiokeIZc4JHcsx0Sre /Wf2qjjwSEROvwfIH7USRY+hRnHSePQRZnA2GHO5VKnYIeb5mpHupeiqNkFLrsrxqnto IsFNWZUnS3YMzNZ30ep5ydmhMF0jLJd6m3xDjum36Cjc3jaxonhoqgHchVSAKpOYCXyP zTPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to; bh=BWye1NOzZbho/gY4C8Fh+ew22gda6RwCJbK2H35XJws=; b=LFLzVyA1B+eeRRcIe1InI8x6VF3/EoqjVVfbmu99dbNEFrr8IB+dGLJb6BIQEUypHa F/n96TSaM8DEk6dcT2owU2cRmrj7uity8HZWzyGUgwTx7dSKsnpmfljSlVtOgCGhmKdt sagzopzync4MMAsI6rtCCggyuERLdGjuVVsLymOaS/oiQRZiQ2018QQI32R2aTqaIVFc MJFMJjo5GH6blEzO7SSw35nJMwxbcCqqmawIiLUZwf0tobPzCq+liFrrOQ/ONwwT1/Tk gQd0pMDfa46iRtNoeevjNg25FDCYO4BBSoN3Ujzb85U7mv2ZHeZIYdMHn3/DpAjpG+AL SHWQ== X-Gm-Message-State: AD7BkJKuUX5fspOTOK9AHxx0t/5FMYm7nJJchvUYVLY24ZQ2+xclu33R3b+dBZv/QmiGokq+y3ZSo05a2/F+fg== X-Received: by 10.50.43.199 with SMTP id y7mr16540282igl.47.1457415938999; Mon, 07 Mar 2016 21:45:38 -0800 (PST) Original-Sender: masanoriogino@gmail.com In-Reply-To: <20160308050527.GA9349@brightrain.aerifal.cx> X-Google-Sender-Auth: rpPPfFlaw1B3UGQy5ExHnhi1BxE Xref: news.gmane.org gmane.linux.lib.musl.general:9525 Archived-At: 2016-03-08 14:05 GMT+09:00 Rich Felker : > On Tue, Mar 08, 2016 at 11:38:15AM +0900, OGINO Masanori wrote: >> These macros indicate which format is used for long double with the >> toolchain. >> >> Although the meaning of "LDBL_DIG_MANT == 64 && LDBL_MAX_EXP == 16384" >> is very clear to floating-point arithmetic guys, it is nice to have >> descriptive names to such conditions. > > I understand where you're coming from but I think this is opposite to > the style preferences in musl, which are to avoid dependence on > internal things and directly use portable conditions based on public > interfaces where possible. The existing tests are all completely valid > even outside musl, without depending on any musl-internal stuff. If > the intent is not clear, perhaps some simple comments would suffice? OK, now I understood that. I think original code is clear enough; it seems just a matter of taste. Thank you for your advice. -- Masanori Ogino