From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/10053 Path: news.gmane.org!not-for-mail From: Masanori Ogino Newsgroups: gmane.linux.lib.musl.general Subject: Re: Re: [bug-gettext] AM_GNU_GETTEXT without referring internal symbols? Date: Thu, 26 May 2016 21:53:49 +0900 Message-ID: References: Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1464267247 25839 80.91.229.3 (26 May 2016 12:54:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 26 May 2016 12:54:07 +0000 (UTC) Cc: bug-gnu-gettext@gnu.org To: musl@lists.openwall.com Original-X-From: musl-return-10066-gllmg-musl=m.gmane.org@lists.openwall.com Thu May 26 14:54:06 2016 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1b5une-0003JH-9U for gllmg-musl@m.gmane.org; Thu, 26 May 2016 14:54:06 +0200 Original-Received: (qmail 31963 invoked by uid 550); 26 May 2016 12:54:02 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 31944 invoked from network); 26 May 2016 12:54:01 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=QKCGc7djzWxxB+8llQyJQPL0oKRsh+mNxegEJHv2sRY=; b=KhSOgM1tkvz9rMDgSqgCJWXsWwlhq2UZUVBiVwlYeiofY95kTuPd+nYUISfFbLrNFi W7Vy4dMNenJyiWe4JlM1XIgpC6y6c8YsB/W/CdG1Fi5HRZQEBOxAtZjRZC8bDrQMLeNV nGnT52F1PPJmI4e+Tj8OIkhpYoV3tYMkImy0h8LG2GRzJ0M9qfG2fjUkm3N7lDPotY/7 SF7h8yZjQaiN4xYVd70h2eZCFLKzqQt78r4yO2rirbM/SvkDd1wpRnB2wK2FBRraabBC 9DTWuWwQMJtrTPpavvRA6qAfbX5AEVJIMPGJoQOp8drXKZcQra+8BMcWyk5tLalRplVq +vSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=QKCGc7djzWxxB+8llQyJQPL0oKRsh+mNxegEJHv2sRY=; b=OltXXPrRlclYdqwKNT18QjgzGb5waWLyD9XeybKymlR/mnw91M8ZFSdvZyJKinUEKC nn/AsexIAxJZsyaGLZFMYpFgZwj7p7EpwkWJEHQkr9eIp8n3ii1eCGKliofyHj/z7F1d X8vDonp2u2rs62N/AB4tM0Uwjqj2mxzrkWB3PPGo8eJGRXml4fAkB42an+MDmguhfhwT wXtLK/OlZxSBuJil0e2QN2ONnAblqnF9C7i/amO3NiekKCST0NKNCGcgyiqddSW8Jkgk D1L11mppkWE2ykdUOa0F7ggJqPkXtAHvj8O1oE9BQiKMxvXu89IE1DdqO1BdgARDDhLE W61g== X-Gm-Message-State: ALyK8tIr9BHvI1mo5Y5nPV0++csdQryX4G9CTHbkECfgbze7F6vHrIMMpFovudDqJoqRjNNF6fIMx/66ncIklQ== X-Received: by 10.157.49.76 with SMTP id v12mr6165250otd.97.1464267229308; Thu, 26 May 2016 05:53:49 -0700 (PDT) Original-Sender: masanoriogino@gmail.com In-Reply-To: X-Google-Sender-Auth: V23xDSxA6ibF9xbmdfFE-MtkUrc Xref: news.gmane.org gmane.linux.lib.musl.general:10053 Archived-At: Hello Daiki, 2016-05-26 15:09 GMT+09:00 Daiki Ueno : > Hello, > > Masanori Ogino writes: > >> 2016-04-07 11:26 GMT+09:00 Daiki Ueno : >>> Masanori Ogino writes: >>>> That is why I proposed to have a blacklist of "broken" implementations >>>> as an option. >>>> >>>> AFAIK there have already been some blacklisting in autotools e.g. >>>> checking the version of glibc to reject specific broken implementation >>>> of a function. Thus, I think it's acceptable to use a blacklist. What >>>> do you think about it? >>> >>> Yes, that sounds like a good idea. But I guess we then need to collect >>> information about incompatible implementations. In this regard I'm >>> actually not sure if the gettext-tools test coverage can be used as an >>> indicator of compatibility. >> >> Indeed. > > I was wondering if there is anything could be done in the upcoming > gettext release. Let's go back to the original explanation by Bruno: > https://lists.gnu.org/archive/html/bug-gnu-utils/2006-03/msg00011.html > where he states two things: > > 1. The purpose of the checks are excluding incompatible implementations, > e.g., NetBSD (around 1.5?) and Solaris 7 > > 2. The __GNU_GETTEXT_SUPPORTED_REVISION macro is a recent addition > > In that case, I guess we could bypass the symbol checks if > __GNU_GETTEXT_SUPPORTED_REVISION is defined, as long as broken > implementations do not define it. > > How about the attached patch? It looks essentially good to me. You can remove the "if test $gt_api_version -ge 3; then ... fi" part before where you modified too if it is not used anywhere else, I guess. Thank you for working on! -- Masanori Ogino