mailing list of musl libc
 help / color / mirror / code / Atom feed
From: "Thomas Stüfe" <thomas.stuefe@gmail.com>
To: musl@lists.openwall.com
Subject: [musl] Question about calloc, free in CPU_ALLOC and CPU_FREE
Date: Wed, 29 Jun 2022 17:49:55 +0200	[thread overview]
Message-ID: <CAA-vtUxnzh-OwpGaZd=D=i_KbYWRu-AWn6uJhQa5RGKg-dxd7g@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 815 bytes --]

Greetings,

I have a small question about the way muslc implements the CPU_ALLOC and
CPU_FREE macros.

I see them defined in sched.h as:

#define CPU_ALLOC(n) ((cpu_set_t *)calloc(1,CPU_ALLOC_SIZE(n)))
#define CPU_FREE(set) free(set)

whereas the glibc defines them as calls to functions __sched_cpu_alloc()
and __sched_cpufree():

#define __CPU_ALLOC(count) __sched_cpualloc (count)
#define __CPU_FREE(cpuset) __sched_cpufree (cpuset)

in the end both variants allocate from C-heap, but the muslc variant gets
inlined directly into the calling code. If that calling code has a function
"free" or "calloc" (okay, less likely) these get called instead. Could also
be a class local method in C++.

I realize this is not a big issue. But would it not be safer to do as the
glibc does in this case?

Thank you,

Thomas

[-- Attachment #2: Type: text/html, Size: 1131 bytes --]

             reply	other threads:[~2022-06-29 15:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 15:49 Thomas Stüfe [this message]
2022-06-29 16:11 ` Markus Wichmann
2022-06-29 16:32   ` Thomas Stüfe
2022-06-29 16:15 ` Florian Weimer
2022-06-29 16:30   ` Thomas Stüfe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA-vtUxnzh-OwpGaZd=D=i_KbYWRu-AWn6uJhQa5RGKg-dxd7g@mail.gmail.com' \
    --to=thomas.stuefe@gmail.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).