mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Lorenzo Beretta <>
To: Rich Felker <>
Subject: Re: [musl] Re: request: please detect reads from stdin with unflushed
Date: Mon, 25 Oct 2021 20:13:20 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 1970 bytes --]

I was thinking something like a warning on stderr fwiw, but I guess you're
right, I didn't consider multithreading.
Thank you for the detailed reply.

Il giorno lun 25 ott 2021 alle ore 19:25 Rich Felker <> ha

> On Mon, Oct 25, 2021 at 03:17:13PM +0200, Lorenzo Beretta wrote:
> > > Suggestion: fix those broken programs!
> >
> > I know, I know... the problem is that they work with glibc and they fail
> > silently with musl, and on top of that I've just discovered that at least
> > netbsd and openbsd do the same as glibc, ie a broken program like
> > #include <stdio.h>
> > int main(){
> >         printf("not flushed: ");
> >         char line[123];
> >         return fgets(line,sizeof line,stdin) ? 0 : 123;
> > }
> >
> > happens to work!!!
> >
> > What I'm asking is that musl (while technically correct!) helps
> > __detecting__ those programs, possibly as an option ("#ifdef
> >
> > PS
> > I'm not subscribed to this mailing list, sorry for not mentioning it the
> > first time
> There's nothing detectable here because there's nothing wrong with the
> program; the bug is in the programmer's *expectation* that the output
> be visible.
> It's possible to implement the behavior the programmer here desired,
> the optional flushing of line-buffered output streams before reading
> input. This would not help detect the bug in expectaions though; it
> would just help mask it. The reason this behavior is not present in
> musl is because it does not scale with significant numbers of stdio
> streams open, and can even produce deadlock conditions in
> multithreaded programs where there is no semantic deadlock but the
> additional flushing produces an extraneous operation on a stream in a
> way that causes deadlock.
> If you hit a program with an issue like this, it should be fairly easy
> to fix by adding fflush(stdout) or fflush(0) immediately before the
> relevant input operations.
> Rich

[-- Attachment #2: Type: text/html, Size: 2530 bytes --]

      reply	other threads:[~2021-10-25 19:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 13:17 Lorenzo Beretta
2021-10-25 17:25 ` Rich Felker
2021-10-25 18:13   ` Lorenzo Beretta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).