From: Stephen Von Takach <steve@place.technology>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com, Viv Briffa <viv@place.technology>
Subject: Re: [musl] unlink on NFS volume fails silently
Date: Wed, 9 Jul 2025 13:59:18 +1000 [thread overview]
Message-ID: <CAASffotPCJ1_8KTipytV3HjSWqK1C=VTSgtLxoCk2xNB2ccfjg@mail.gmail.com> (raw)
In-Reply-To: <20250708010811.GL1827@brightrain.aerifal.cx>
[-- Attachment #1: Type: text/plain, Size: 2014 bytes --]
Yes we traced this.
The libc unlink function on musl returned 0 for a filename on an NFS mount
that wasn't deleted.
https://www.gnu.org/software/libc/manual/html_node/Deleting-Files.html
The same call to unlink on glibc returned 0 and actually removed the file.
The issue occurs when there is a high volume of files being removed
Stephen von Takach Dukai
Engineering Lead
PlaceOS
Australia, Hong Kong, London, New York
p: +61 408 419 954
e: steve@place.technology
On Tue, 8 Jul 2025 at 11:08, Rich Felker <dalias@libc.org> wrote:
> On Sun, Jul 06, 2025 at 04:25:31PM +1000, Stephen Von Takach wrote:
> > Hi,
> >
> > We recently had to move a service from being built on alpine linux to
> > debian linux as we were getting silent failures when deleting a directory
> > with many files on an NFS volume. Basically this call to unlink was not
> > raising an error if the file failed to delete
> >
> https://github.com/crystal-lang/crystal/blob/master/src/crystal/system/unix/file.cr#L129
> >
> > We replicated the issue in an alpine container with rm -rf
> > /nfs_mount/git_repo_to_delete and it also failed to successfully delete
> all
> > the files, it did raise an error though (I assume it checked the file was
> > removed before continuing) not entirely sure.
> >
> > Both these operations succeed with glibc when using debian.
> > Looks a bit like this issue:
> > https://gitlab.alpinelinux.org/alpine/aports/-/issues/10960
>
> Assuming you actually traced and saw the unlink syscall succeed, the
> root cause here is the filesystem/kernel lying about that. Standard
> "NFS Considered Harmful" stuff.
>
> But the fact that you're seeing different behavior on Alpine is almost
> surely a matter of busybox rm vs GNU coreutils differences in how they
> behave under faulty kernel behavior. The easy solution is probably
> installing the coreutils package. Otherwise, investigate what busybox
> is doing differently and if there's a way it could be made more
> reliable in this situation.
>
> Rich
>
>
[-- Attachment #2: Type: text/html, Size: 5806 bytes --]
next prev parent reply other threads:[~2025-07-09 4:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-06 6:25 [musl] unlink on NFS volume fails silently Stephen Von Takach
2025-07-07 18:26 ` Markus Wichmann
2025-07-08 1:08 ` Rich Felker
2025-07-09 3:59 ` Stephen Von Takach [this message]
2025-07-09 18:41 ` Rich Felker
2025-07-09 23:01 ` [musl] " Stephen Von Takach
2025-07-10 0:03 ` Rich Felker
2025-07-10 4:58 ` Stephen Von Takach
2025-07-10 15:44 ` Rich Felker
2025-07-10 17:01 ` Nathan McSween
2025-07-10 17:11 ` Rich Felker
2025-07-10 21:25 ` Stephen Von Takach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAASffotPCJ1_8KTipytV3HjSWqK1C=VTSgtLxoCk2xNB2ccfjg@mail.gmail.com' \
--to=steve@place.technology \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
--cc=viv@place.technology \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).