From: Petr Hosek <phosek@google.com>
To: "musl@lists.openwall.com" <musl@lists.openwall.com>
Subject: [PATCH] don't define SHARED macro in the source
Date: Fri, 06 Nov 2015 23:46:40 +0000 [thread overview]
Message-ID: <CABBv4Tawb1qo4w5SWD6=jXG-5efZFtg00veRi+C_rY97ke7uYg@mail.gmail.com> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 391 bytes --]
When building musl with pnacl-clang compiler I found a bug: crt/rcrt1.c
defines the SHARED macro which enables the conditional block in
src/ldso/dlstart.c, this breaks for us because pnacl-clang doesn't support
shared libraries nor inline assembly. If my understanding is correct, the
SHARED macro should be (and already is) defined only in CFLAGS_ALL_SHARED.
The attached patch fixes that.
[-- Attachment #1.2: Type: text/html, Size: 419 bytes --]
[-- Attachment #2: don-t-define-SHARED-macro-in-the-source.patch --]
[-- Type: text/x-patch, Size: 611 bytes --]
From 7b1348fa1a8dd2d02a9087639c6b02ce9585aef2 Mon Sep 17 00:00:00 2001
From: Petr Hosek <phosek@chromium.org>
Date: Thu, 5 Nov 2015 21:55:20 -0800
Subject: [PATCH] don't define SHARED macro in the source
the SHARED macro should only be defined in CFLAGS_ALL_SHARED when
building musl as shared library.
---
crt/rcrt1.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/crt/rcrt1.c b/crt/rcrt1.c
index 9be117f..0ba78f8 100644
--- a/crt/rcrt1.c
+++ b/crt/rcrt1.c
@@ -1,4 +1,3 @@
-#define SHARED
#define START "_start"
#define _dlstart_c _start_c
#include "../src/ldso/dlstart.c"
--
2.6.0.rc2.230.g3dd15c0
next reply other threads:[~2015-11-06 23:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 23:46 Petr Hosek [this message]
2015-11-07 13:24 ` Szabolcs Nagy
2015-11-07 23:24 ` Petr Hosek
2015-11-08 0:58 ` Rich Felker
2015-11-08 2:17 ` Szabolcs Nagy
2015-11-08 6:46 ` Petr Hosek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABBv4Tawb1qo4w5SWD6=jXG-5efZFtg00veRi+C_rY97ke7uYg@mail.gmail.com' \
--to=phosek@google.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).