mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Sascha Brawer <sascha@brawer.ch>
To: musl@lists.openwall.com
Subject: [musl] Should fdopen() check the passed file descriptor?
Date: Thu, 4 Aug 2022 14:42:49 +0200	[thread overview]
Message-ID: <CABKQ4ESdWjkiMYGLmKan8kG5EXhXgV1kw2Da3uniGgkJ0vfeCQ@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

Dear list

Should musl’s fdopen() verify whether the passed file descriptor refers to
an open file? glibc seems to do that, whereas musl doesn’t.

According to the spec, fdopen "may" fail with EBADF if a bad file
descriptor is passed.
https://pubs.opengroup.org/onlinepubs/009696899/functions/fdopen.html

I just ran into this difference while porting some user library (libosmium,
for OpenStreetMap) to Alpine Linux which uses musl. For now I’m patching
the user library so it tests for fcntl(fd, F_GETFD) < 0 before invoking
fdopen(). But I wonder if this check shouldn’t rather be done within musl
itself. What do you think?

Thanks for cc’ing me on your thoughts, I’m not subscribed to the musl
mailing list. Best,

— Sascha Brawer, sascha@brawer.ch

[-- Attachment #2: Type: text/html, Size: 1108 bytes --]

             reply	other threads:[~2022-08-04 13:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 12:42 Sascha Brawer [this message]
2022-08-04 14:23 ` Markus Wichmann
2022-08-04 16:09   ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABKQ4ESdWjkiMYGLmKan8kG5EXhXgV1kw2Da3uniGgkJ0vfeCQ@mail.gmail.com \
    --to=sascha@brawer.ch \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).