From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HTML_MESSAGE,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 11346 invoked from network); 28 Jul 2021 15:46:45 -0000 Received: from mother.openwall.net (195.42.179.200) by inbox.vuxu.org with ESMTPUTF8; 28 Jul 2021 15:46:45 -0000 Received: (qmail 32670 invoked by uid 550); 28 Jul 2021 15:46:42 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 5209 invoked from network); 28 Jul 2021 15:01:51 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hugunin-net.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=STcvQTvu5fWchFq8L9OKBys4VOF68oMzt+zAjuBGzTU=; b=JzMo5B1rO7B6DQysEpmtHAMfDDqQMLN9EoaFwt9F6UkNWa+I+ajVuqwQ88jcEErMwj 2Y1M6DfNkQ2aPGkZs58KTovleYJnDa4rO8mwqKvMjl6V9pLPTQF15RENfzmdipoFfvp0 oGH4QYyPscqUaERnCabhJG+8dvvl9bf+faxH5djblhusxvjLjoMY4VpIcjB2A79bYUn1 3lBHTFZ7rRTqyOEWKpl6VvEtNQopcKMkSv5bktgtBSyGF9cIKKh/s83hA++ZXDw8DGgI DyE35pDPHwUPYHc4JvJ5mFSd1pwa1TzNRJl1/DIMcp2VZZsDR6IDEcoi0COdmSWv5JPA 5+LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=STcvQTvu5fWchFq8L9OKBys4VOF68oMzt+zAjuBGzTU=; b=F1Ib3bEjjJqlbF9K4urpU6uaVZdT7WNlhV3BbBJkz2x3z/usKaxqnw8cEKLl+22y24 4Bw8B7L1Z1OboTyVKdhrwy1v6dPEafDno8ISSQkNNoKTOv91YR5MMfpEM6pfMb/bi7uJ t33iyKicIKpohkSRfEfFq4k8I6D2pwUdirxOKfS4rPPzFBnkpetfIw+/mWFOnQ89nbKL PTPA+eh0lxhXT4Y/S0DHAsCyw3AGy5uUuq2+ubj2GossjMDgpfUGbrBMKYqATq4qEmfc tUWgLWmrgsh90v1aDfs8i+1+tHE4XQxnl3BxxVnPFSMII6aORX8Fav8/fXS15N0IxMV+ E3BA== X-Gm-Message-State: AOAM530uC4sUI8QXgYnJzccGZdyI+Tft++YXDgRgz9lGcGo4zQdCbHgu mKBLxk0p8kzVL6TAEFgQZOMGjXBhCLrIG5AscuelS9wo6qidww== X-Google-Smtp-Source: ABdhPJytQ85oWJjSXcEAqseMsNa/3GOUSAflANPK8+5xVFsX6zLj4WMyeRMLAd1Kvmu6E87zQxktK384MgHW5ds/rMo= X-Received: by 2002:aa7:8696:0:b029:32a:75ef:8f6c with SMTP id d22-20020aa786960000b029032a75ef8f6cmr288963pfo.69.1627484498735; Wed, 28 Jul 2021 08:01:38 -0700 (PDT) MIME-Version: 1.0 From: Jasper Hugunin Date: Wed, 28 Jul 2021 08:00:00 -0700 Message-ID: To: musl@lists.openwall.com Content-Type: multipart/alternative; boundary="0000000000006cc64805c83043ca" Subject: [musl] Bug in src/signal/block.c --0000000000006cc64805c83043ca Content-Type: text/plain; charset="UTF-8" Hello, In musl, as far as I can tell, `_NSIG` is always defined as either 65, or 128 (for all three MIPS architectures) at the bottom of `${arch}/bits/signal.h`. Meanwhile, in `src/signal/block.c`, there is a test `#if ULONG_MAX == 0xffffffff && _NSIG == 129`, which will never succeed since _NSIG will be 128 instead of 129. This seems likely to be left over from Commit: fix _NSIG and SIGRTMAX on mips . I have not demonstrated the bug, I found it by inspection of the source. My guess is that this bug causes __block_all_sigs to fail to block high real time signals on MIPS. At best, however, this test seems to be dead code. (I am not subscribed to the mailing list; please cc me directly on any responses I need to see.) My apologies if I have misunderstood the situation. Sincerely, - Jasper Hugunin --0000000000006cc64805c83043ca Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

In musl, as far as I can tell, `= _NSIG` is always defined as either 65, or 128 (for all three MIPS architect= ures) at the bottom of `${arch}/bits/signal.h`. Meanwhile, in `src/signal/b= lock.c`, there is a test `#if ULONG_MAX =3D=3D 0xffffffff && _NSIG = =3D=3D 129`, which will never succeed since _NSIG will be 128 instead of 12= 9. This seems likely to be left over from=C2=A0Commit: fix _NSIG and SIGRTMAX on mips.

I h= ave not demonstrated the bug,=C2=A0I found it by inspection of the source. = My guess is that this bug causes __block_all_sigs to fail to block high rea= l time signals on MIPS. At best, however, this test seems to be dead code.<= /div>

(I am not subscribed to the mailing list; please c= c me directly on any responses I need to see.)
My apologies if I = have misunderstood the situation.

Sincerely,
=
- Jasper Hugunin
--0000000000006cc64805c83043ca--