From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14826 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dan Gohman Newsgroups: gmane.linux.lib.musl.general Subject: [PATCH] Use fabsl instead of fabs on long double operand in floatscan.c Date: Fri, 18 Oct 2019 07:02:11 -0700 Message-ID: Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000007bf3d005952fc881" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="191751"; mail-complaints-to="usenet@blaine.gmane.org" To: musl@lists.openwall.com Original-X-From: musl-return-14842-gllmg-musl=m.gmane.org@lists.openwall.com Fri Oct 18 16:02:39 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1iLSpy-000nj1-TJ for gllmg-musl@m.gmane.org; Fri, 18 Oct 2019 16:02:39 +0200 Original-Received: (qmail 32466 invoked by uid 550); 18 Oct 2019 14:02:36 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 32430 invoked from network); 18 Oct 2019 14:02:35 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mozilla.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=HfLJ0fZdMeDNaUoCf72lgfR+Qym1IJkkMsgpq3aOiQs=; b=B0PzHZCCEO3mgWcyZjJszwP0BfWXyXCepu/wDnw0aOgGWaVogZLu/RrnsWmOEou17s p7hrjnlgQopAl97GTuulqQJqGQp26IR/Z1ByMzK9R5Tr44YZe2NKJhjjCIewoA+DX/oW H0Jlhz+S6P5lUVq3yNYF7yllGrCNR4LPxSJn8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=HfLJ0fZdMeDNaUoCf72lgfR+Qym1IJkkMsgpq3aOiQs=; b=UB62vony0Zf9bN60C8OVbF5GEUOXrUGjjIlVoVN+4T+n1pWzDY2BtEqeetj+xMk5yD O+juHP7xwKSS1tyi0hhxy7tLsuJFyY8p4XHCLy1eB3z/W/oB+J8tu4aZYXu24mQSEssv hXEDNC3YOmoYVPD0c/YcPDalXVZHc5OEaSUV+DsuYzHyWs3OEaaI3eLcNDdHorfBVmLV 4gDR4sKXkNh/H6Qhek6tw4nsDRXYp/T8PMMP54rTL0sJb2Ymr1Yqp8/PKpPjcYUXFQKy ISN8RJi3x27yu7hEg2YAfE6EkzsHVelZynmehOCF7GnvNqspAOhnopLmIWMMAz8f3wTO TIeQ== X-Gm-Message-State: APjAAAXt6XX2NPdhVpCRgBD2FIXjy0xiNxce4fdLnKstrpBo1WgSAdFS sk1IsRhMkSOekiqQLiOsCOBj+fJHXtG7Bq65AywpTVz4ZIU= X-Google-Smtp-Source: APXvYqzoNfH0yXuC+phH+4c0dz+UTN5xmwiH/aP1yk/N5JGCVPwochGrdj9/MKcEJZACtqfyP4wy4183cWbx2hlpobY= X-Received: by 2002:a02:c78b:: with SMTP id n11mr9061869jao.67.1571407343104; Fri, 18 Oct 2019 07:02:23 -0700 (PDT) Xref: news.gmane.org gmane.linux.lib.musl.general:14826 Archived-At: --0000000000007bf3d005952fc881 Content-Type: multipart/alternative; boundary="0000000000007bf3ce05952fc87f" --0000000000007bf3ce05952fc87f Content-Type: text/plain; charset="UTF-8" This fixes a compiler warning with clang: floatscan.c:304:13: warning: absolute value function 'fabs' given an argument of type 'long double' but has parameter of type 'double' which may cause truncation of value [-Wabsolute-value]. This does change the behavior of the expression because the value is no longer rounded to double, however from my reading of the code, the rounding doesn't seem intended. However, if it is, I suggest introducing an explicit cast, to document the intent. Dan --0000000000007bf3ce05952fc87f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
This fixes a compiler warning with clang:

floa= tscan.c:304:13: warning: absolute value function 'fabs' given an ar= gument of type 'long double' but has parameter of type 'double&= #39; which may cause truncation of value [-Wabsolute-value].

=
This does change the behavior of the expression because the valu= e is no longer rounded to double, however from my reading of the code, the = rounding doesn't seem intended. However, if it is, I suggest introducin= g an explicit cast, to document the intent.

Da= n
--0000000000007bf3ce05952fc87f-- --0000000000007bf3d005952fc881 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Use-fabsl-instead-of-fabs-on-long-double-in-floatsca.patch" Content-Disposition: attachment; filename="0001-Use-fabsl-instead-of-fabs-on-long-double-in-floatsca.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1w770oa0 RnJvbSAxZmVjYzUyMWRjNDNiMjUzNjZjZDRhMzA2Mjk2NGZmM2FiYzc1MDZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW4gR29obWFuIDxzdW5maXNoQG1vemlsbGEuY29tPgpEYXRl OiBGcmksIDE4IE9jdCAyMDE5IDA2OjIyOjQ5IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gVXNlIGBm YWJzbGAgaW5zdGVhZCBvZiBgZmFic2Agb24gbG9uZyBkb3VibGUgaW4gZmxvYXRzY2FuLmMKClRo aXMgZml4ZXMgYSBjb21waWxlciB3YXJuaW5nOgoKZmxvYXRzY2FuLmM6MzA0OjEzOiB3YXJuaW5n OiBhYnNvbHV0ZSB2YWx1ZSBmdW5jdGlvbiAnZmFicycgZ2l2ZW4gYW4gYXJndW1lbnQKb2YgdHlw ZSAnbG9uZyBkb3VibGUnIGJ1dCBoYXMgcGFyYW1ldGVyIG9mIHR5cGUgJ2RvdWJsZScgd2hpY2gg bWF5IGNhdXNlCnRydW5jYXRpb24gb2YgdmFsdWUgWy1XYWJzb2x1dGUtdmFsdWVdCi0tLQogc3Jj L2ludGVybmFsL2Zsb2F0c2Nhbi5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2ludGVybmFsL2Zsb2F0c2Nhbi5j IGIvc3JjL2ludGVybmFsL2Zsb2F0c2Nhbi5jCmluZGV4IDI3OGJmMjUwLi45OWExZWMyOSAxMDA2 NDQKLS0tIGEvc3JjL2ludGVybmFsL2Zsb2F0c2Nhbi5jCisrKyBiL3NyYy9pbnRlcm5hbC9mbG9h dHNjYW4uYwpAQCAtMzAxLDcgKzMwMSw3IEBAIHN0YXRpYyBsb25nIGRvdWJsZSBkZWNmbG9hdChG SUxFICpmLCBpbnQgYywgaW50IGJpdHMsIGludCBlbWluLCBpbnQgc2lnbiwgaW50IHBvCiAJeSAt PSBiaWFzOwogCiAJaWYgKChlMitMREJMX01BTlRfRElHICYgSU5UX01BWCkgPiBlbWF4LTUpIHsK LQkJaWYgKGZhYnMoeSkgPj0gQ09OQ0FUKDB4MXAsIExEQkxfTUFOVF9ESUcpKSB7CisJCWlmIChm YWJzbCh5KSA+PSBDT05DQVQoQ09OQ0FUKDB4MXAsIExEQkxfTUFOVF9ESUcpLCBsKSkgewogCQkJ aWYgKGRlbm9ybWFsICYmIGJpdHM9PUxEQkxfTUFOVF9ESUcrZTItZW1pbikKIAkJCQlkZW5vcm1h bCA9IDA7CiAJCQl5ICo9IDAuNTsKLS0gCjIuMTcuMQoK --0000000000007bf3d005952fc881--