From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/14056 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dan Gohman Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] Fix unintended global symbols in atanl.c Date: Wed, 3 Apr 2019 12:29:23 -0700 Message-ID: References: <20190403141627.GP23599@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000001bff7e0585a54643" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="248377"; mail-complaints-to="usenet@blaine.gmane.org" To: musl@lists.openwall.com Original-X-From: musl-return-14072-gllmg-musl=m.gmane.org@lists.openwall.com Wed Apr 03 21:29:53 2019 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.89) (envelope-from ) id 1hBla4-0012Hm-6L for gllmg-musl@m.gmane.org; Wed, 03 Apr 2019 21:29:52 +0200 Original-Received: (qmail 23751 invoked by uid 550); 3 Apr 2019 19:29:49 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 23729 invoked from network); 3 Apr 2019 19:29:48 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mozilla.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=bOF6oRULx3NTT30BDMAr38GJBOTNw9uynU9dJlKfRgM=; b=bWCUgae+D4rkJOwrDYrv6hb2Nfo6766YKcpM905UKtIsiT8yFqwSQCoGilL/3JbHAJ PsNY6dvWfDsmkzHus9Pb2QSb5XmLQiHw5EVOOhERRWwWuywpblpBGqV0Z2Hhx9aCIchH LdivwFZRDCXXGxMutArwT2849CNYXIC12RJ1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=bOF6oRULx3NTT30BDMAr38GJBOTNw9uynU9dJlKfRgM=; b=Xr3b4mirdif/ihSWAr4E0gxOCvhj+Bm6nQEsO6akmZoym6SwELhtvIUoBDwIHzy8Rh q0IcntOLfTfx66h57dAMMB38uQBciYg4D1FeHsYhtC5L1VvQogO7tUIGLYxdDpyW3koI dduy1Y1JRJTiK+E6cLGDuZMzeCYUjccaBjwX/HC3QPx6Ui/UetvvGhgK24FEXEMdCbv4 GNGjDJklRWIYL/rd2z/1/LKWDkVRmyXrVpJ+xTMqo3RmnAOMrdzP25mSMB0XG5MEI5tB onCfC9hy7Mh/WDMltIcph+ymsuX6CPwXJ/Ua1ULs30LR070xhqAL8X2dAh19U1jM2mR9 YWZg== X-Gm-Message-State: APjAAAVG/bjAaCwKKBps+CKOy1FdrXKcp+uCmYT/rTjFnmXUQp2D2Hul 9bxTJMHXyFBftLBlmbmKBPgj4iJ6bYs7yObP24wwhFnf X-Google-Smtp-Source: APXvYqxGCmNohkeUcG5eI/pgysY1DwU0ExcC3rohMigsiJQ/Go8fObu2i0QmotX7O3Rh1bt+3dta3vygOqvto3nlF5Q= X-Received: by 2002:a6b:8b90:: with SMTP id n138mr1438046iod.75.1554319775857; Wed, 03 Apr 2019 12:29:35 -0700 (PDT) In-Reply-To: <20190403141627.GP23599@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:14056 Archived-At: --0000000000001bff7e0585a54643 Content-Type: multipart/alternative; boundary="0000000000001bff7b0585a54641" --0000000000001bff7b0585a54641 Content-Type: text/plain; charset="UTF-8" My apologies. Here is the patch as an attachment. Dan On Wed, Apr 3, 2019 at 7:16 AM Rich Felker wrote: > On Wed, Apr 03, 2019 at 05:56:08AM -0700, Dan Gohman wrote: > > Mark atanhi, atanlo, and aT in atanl.c as static, as they're not intended > > to be part of the public API. > > > > These are already static in the LDBL_MANT_DIG == 64 code, so this patch > is > > just making the LDBL_MANT_DIG == 113 code do the same thing. > > --- > > src/math/atanl.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/src/math/atanl.c b/src/math/atanl.c > > index 79a3edb8..c3b0c926 100644 > > --- a/src/math/atanl.c > > +++ b/src/math/atanl.c > > @@ -70,21 +70,21 @@ static long double T_odd(long double x) > > #elif LDBL_MANT_DIG == 113 > > #define EXPMAN(u) ((u.i.se & 0x7fff)<<8 | u.i.top>>8) > > > > -const long double atanhi[] = { > > +static const long double atanhi[] = { > > 4.63647609000806116214256231461214397e-01L, > > 7.85398163397448309615660845819875699e-01L, > > 9.82793723247329067985710611014666038e-01L, > > 1.57079632679489661923132169163975140e+00L, > > }; > > > > -const long double atanlo[] = { > > +static const long double atanlo[] = { > > 4.89509642257333492668618435220297706e-36L, > > 2.16795253253094525619926100651083806e-35L, > > -2.31288434538183565909319952098066272e-35L, > > 4.33590506506189051239852201302167613e-35L, > > }; > > > > -const long double aT[] = { > > +static const long double aT[] = { > > 3.33333333333333333333333333333333125e-01L, > > -1.99999999999999999999999999999180430e-01L, > > 1.42857142857142857142857142125269827e-01L, > > -- > > 2.17.1 > > Your email system appears to have corrupted the patch; it does not > apply. Can you please resend as an attachment in the same git > format-patch form? > > Rich > --0000000000001bff7b0585a54641 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
My apologies. Here is the patch as an attachment.
=

Dan

On Wed, Apr 3, 2019 at 7:16 AM Rich = Felker <dalias@libc.org> wrote= :
On Wed, Apr 03= , 2019 at 05:56:08AM -0700, Dan Gohman wrote:
> Mark atanhi, atanlo, and aT in atanl.c as static, as they're not i= ntended
> to be part of the public API.
>
> These are already static in the LDBL_MANT_DIG =3D=3D 64 code, so this = patch is
> just making the LDBL_MANT_DIG =3D=3D 113 code do the same thing.
> ---
>=C2=A0 src/math/atanl.c | 6 +++---
>=C2=A0 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/math/atanl.c b/src/math/atanl.c
> index 79a3edb8..c3b0c926 100644
> --- a/src/math/atanl.c
> +++ b/src/math/atanl.c
> @@ -70,21 +70,21 @@ static long double T_odd(long double x)
>=C2=A0 #elif LDBL_MANT_DIG =3D=3D 113
>=C2=A0 #define EXPMAN(u) ((u.i.se & 0x7fff)<<8 | u.i.top>>8) >
> -const long double atanhi[] =3D {
> +static const long double atanhi[] =3D {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 4.6364760900080611621425623146121439= 7e-01L,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 7.8539816339744830961566084581987569= 9e-01L,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 9.8279372324732906798571061101466603= 8e-01L,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1.5707963267948966192313216916397514= 0e+00L,
>=C2=A0 };
>
> -const long double atanlo[] =3D {
> +static const long double atanlo[] =3D {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 4.8950964225733349266861843522029770= 6e-36L,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 2.1679525325309452561992610065108380= 6e-35L,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-2.3128843453818356590931995209806627= 2e-35L,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 4.3359050650618905123985220130216761= 3e-35L,
>=C2=A0 };
>
> -const long double aT[] =3D {
> +static const long double aT[] =3D {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 3.3333333333333333333333333333333312= 5e-01L,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-1.9999999999999999999999999999918043= 0e-01L,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 1.4285714285714285714285714212526982= 7e-01L,
> --
> 2.17.1

Your email system appears to have corrupted the patch; it does not
apply. Can you please resend as an attachment in the same git
format-patch form?

Rich
--0000000000001bff7b0585a54641-- --0000000000001bff7e0585a54643 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-unintended-global-symbols-in-atanl.c.patch" Content-Disposition: attachment; filename="0001-Fix-unintended-global-symbols-in-atanl.c.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_ju1lr6mh0 RnJvbSBhYjRkNTBlZjM0ZGYzODgyMzZlZGE0NTk0YzUyNGNjZjI0YjllMThlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEYW4gR29obWFuIDxzdW5maXNoQG1vemlsbGEuY29tPgpEYXRl OiBXZWQsIDMgQXByIDIwMTkgMDU6NDg6NTAgLTA3MDAKU3ViamVjdDogW1BBVENIXSBGaXggdW5p bnRlbmRlZCBnbG9iYWwgc3ltYm9scyBpbiBhdGFubC5jLgoKTWFyayBhdGFuaGksIGF0YW5sbywg YW5kIGFUIGluIGF0YW5sLmMgYXMgc3RhdGljLCBhcyB0aGV5J3JlIG5vdAppbnRlbmRlZCB0byBi ZSBwYXJ0IG9mIHRoZSBwdWJsaWMgQVBJLgoKVGhlc2UgYXJlIGFscmVhZHkgc3RhdGljIGluIHRo ZSBMREJMX01BTlRfRElHID09IDY0IGNvZGUsIHNvIHRoaXMKcGF0Y2ggaXMganVzdCBtYWtpbmcg dGhlIExEQkxfTUFOVF9ESUcgPT0gMTEzIGNvZGUgZG8gdGhlIHNhbWUgdGhpbmcuCi0tLQogc3Jj L21hdGgvYXRhbmwuYyB8IDYgKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCsp LCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9tYXRoL2F0YW5sLmMgYi9zcmMvbWF0 aC9hdGFubC5jCmluZGV4IDc5YTNlZGI4Li5jM2IwYzkyNiAxMDA2NDQKLS0tIGEvc3JjL21hdGgv YXRhbmwuYworKysgYi9zcmMvbWF0aC9hdGFubC5jCkBAIC03MCwyMSArNzAsMjEgQEAgc3RhdGlj IGxvbmcgZG91YmxlIFRfb2RkKGxvbmcgZG91YmxlIHgpCiAjZWxpZiBMREJMX01BTlRfRElHID09 IDExMwogI2RlZmluZSBFWFBNQU4odSkgKCh1Lmkuc2UgJiAweDdmZmYpPDw4IHwgdS5pLnRvcD4+ OCkKIAotY29uc3QgbG9uZyBkb3VibGUgYXRhbmhpW10gPSB7CitzdGF0aWMgY29uc3QgbG9uZyBk b3VibGUgYXRhbmhpW10gPSB7CiAJIDQuNjM2NDc2MDkwMDA4MDYxMTYyMTQyNTYyMzE0NjEyMTQz OTdlLTAxTCwKIAkgNy44NTM5ODE2MzM5NzQ0ODMwOTYxNTY2MDg0NTgxOTg3NTY5OWUtMDFMLAog CSA5LjgyNzkzNzIzMjQ3MzI5MDY3OTg1NzEwNjExMDE0NjY2MDM4ZS0wMUwsCiAJIDEuNTcwNzk2 MzI2Nzk0ODk2NjE5MjMxMzIxNjkxNjM5NzUxNDBlKzAwTCwKIH07CiAKLWNvbnN0IGxvbmcgZG91 YmxlIGF0YW5sb1tdID0geworc3RhdGljIGNvbnN0IGxvbmcgZG91YmxlIGF0YW5sb1tdID0gewog CSA0Ljg5NTA5NjQyMjU3MzMzNDkyNjY4NjE4NDM1MjIwMjk3NzA2ZS0zNkwsCiAJIDIuMTY3OTUy NTMyNTMwOTQ1MjU2MTk5MjYxMDA2NTEwODM4MDZlLTM1TCwKIAktMi4zMTI4ODQzNDUzODE4MzU2 NTkwOTMxOTk1MjA5ODA2NjI3MmUtMzVMLAogCSA0LjMzNTkwNTA2NTA2MTg5MDUxMjM5ODUyMjAx MzAyMTY3NjEzZS0zNUwsCiB9OwogCi1jb25zdCBsb25nIGRvdWJsZSBhVFtdID0geworc3RhdGlj IGNvbnN0IGxvbmcgZG91YmxlIGFUW10gPSB7CiAJIDMuMzMzMzMzMzMzMzMzMzMzMzMzMzMzMzMz MzMzMzMzMzMxMjVlLTAxTCwKIAktMS45OTk5OTk5OTk5OTk5OTk5OTk5OTk5OTk5OTk5OTE4MDQz MGUtMDFMLAogCSAxLjQyODU3MTQyODU3MTQyODU3MTQyODU3MTQyMTI1MjY5ODI3ZS0wMUwsCi0t IAoyLjE3LjEKCg== --0000000000001bff7e0585a54643--