From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/4691
Path: news.gmane.org!not-for-mail
From: Yves Bastide <ybastide@gmail.com>
Newsgroups: gmane.linux.lib.musl.general
Subject: src/string/strstr.c, src/string/wcsstr.c: wrong estimates for MIN(l,63)?
Date: Fri, 21 Mar 2014 15:07:22 +0100
Message-ID: <CACeDTm0jrXGjPrk=BDt_k=dnq6cgyTm-6r6Uf0ThBVkNB_RDAA@mail.gmail.com>
Reply-To: musl@lists.openwall.com
NNTP-Posting-Host: plane.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-Trace: ger.gmane.org 1395410868 656 80.91.229.3 (21 Mar 2014 14:07:48 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Fri, 21 Mar 2014 14:07:48 +0000 (UTC)
To: musl@lists.openwall.com
Original-X-From: musl-return-4695-gllmg-musl=m.gmane.org@lists.openwall.com Fri Mar 21 15:07:58 2014
Return-path: <musl-return-4695-gllmg-musl=m.gmane.org@lists.openwall.com>
Envelope-to: gllmg-musl@plane.gmane.org
Original-Received: from mother.openwall.net ([195.42.179.200])
	by plane.gmane.org with smtp (Exim 4.69)
	(envelope-from <musl-return-4695-gllmg-musl=m.gmane.org@lists.openwall.com>)
	id 1WR072-0008TG-05
	for gllmg-musl@plane.gmane.org; Fri, 21 Mar 2014 15:07:56 +0100
Original-Received: (qmail 11707 invoked by uid 550); 21 Mar 2014 14:07:55 -0000
Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm
Precedence: bulk
List-Post: <mailto:musl@lists.openwall.com>
List-Help: <mailto:musl-help@lists.openwall.com>
List-Unsubscribe: <mailto:musl-unsubscribe@lists.openwall.com>
List-Subscribe: <mailto:musl-subscribe@lists.openwall.com>
Original-Received: (qmail 11698 invoked from network); 21 Mar 2014 14:07:55 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:from:date:message-id:subject:to:content-type;
        bh=rX3kaUc39Ezx9Wq9xcUGcpQ6hQ4HGxLplKwvbNkfnUk=;
        b=MiuFN3PCclIpB8n66Z80PL1ewbDRox23MmKAMi6Scq4VM7lp9g+GRmV1yZe6vDaPvB
         /bl2MQGDlQ7Q+raZ+4Nh6+5T82FKvE+fcXEDdQNuxTA8tAOgQhRQQo4DQUZrtbpqAFGY
         8PJ5w0yPNtm0zkX5vqDOFJUFgAC/WhQzaC6t6JJXhTtBSaOjApZL1p4FlnwdPZkTuRMO
         pOwDalpNcP0W/CpBQT0pU9zO7JXB6nBpPHvs9PNJJjjnJmth8zBxshAgsDxXI35jMBL4
         uveFUBIs5O028qGfJXntvxidio/52xaYb4CYo0/1S4r6unjm5aIMibo0NR+YNyDhDBVW
         idWQ==
X-Received: by 10.58.69.20 with SMTP id a20mr173884veu.63.1395410862960; Fri,
 21 Mar 2014 07:07:42 -0700 (PDT)
Xref: news.gmane.org gmane.linux.lib.musl.general:4691
Archived-At: <http://permalink.gmane.org/gmane.linux.lib.musl.general/4691>

Hi,

twoway_strstr and twoway_wcsstr seem to contain a bogus estimation:

/* Fast estimate for MIN(l,63) */
size_t grow = l | 63;

"grow" is thus always at least 63...

Regards,

Yves