From: Alex <alexinbeijing@gmail.com>
To: musl@lists.openwall.com
Subject: Re: [PATCHv3 1/3] fix matching errors for overwritten registers in x86 CFI generation script
Date: Wed, 14 Oct 2015 12:21:05 +0200 [thread overview]
Message-ID: <CACsECNd+C1jvfke4FDVY8wJ6w8hf_m_t8efsS=pzGOkqx4r1XA@mail.gmail.com> (raw)
In-Reply-To: <20151013224204.GT8645@brightrain.aerifal.cx>
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
On Wed, Oct 14, 2015 at 12:42 AM, Rich Felker <dalias@libc.org> wrote:
> On Tue, Oct 13, 2015 at 01:28:50PM +0200, Alex Dowad wrote:
> > Here is the latest iteration. I have merged 2 previously separate
> commits, and
> > fixed up the matching of registers (for the purpose of identifying
> overwritten
> > registers).
> >
> > As usual, thanks for the feedback. AD
>
> Thanks! I'm committing them all now. I'm sorry for not catching this
> before -- I realized that the index register thing was also an
> existing bug in mov handling, not just a new bug added in the operand
> order patch, so I split it out into a separate commit. I did basic
> regression testing on i386 (making sure gdb backtrace from syscalls
> still works) and tested that the x86_64 also seems to work (it does).
Thanks!
This has been an interesting exercise so far. Is there any other arch which
you think it would be worthwhile to develop a CFI generation script for? It
should be something which has enough users to avoid problems with bitrot.
AD
[-- Attachment #2: Type: text/html, Size: 1478 bytes --]
next prev parent reply other threads:[~2015-10-14 10:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 11:28 Alex Dowad
2015-10-13 11:28 ` [PATCH 2/3] x86 CFI generation script recognizes when %ax, %ah, %al, etc. are overwritten Alex Dowad
2015-10-13 11:28 ` [PATCH 3/3] add CFI generation script for x86_64 Alex Dowad
2015-10-13 22:42 ` [PATCHv3 1/3] fix matching errors for overwritten registers in x86 CFI generation script Rich Felker
2015-10-14 10:21 ` Alex [this message]
2015-10-14 19:14 ` Rich Felker
2015-10-14 19:23 ` Alex
2015-10-14 19:27 ` Rich Felker
2015-10-14 19:44 ` Alex
2015-10-14 19:51 ` Rich Felker
2015-10-14 20:27 ` Alex
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsECNd+C1jvfke4FDVY8wJ6w8hf_m_t8efsS=pzGOkqx4r1XA@mail.gmail.com' \
--to=alexinbeijing@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).