From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/8667 Path: news.gmane.org!not-for-mail From: Alex Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCHv3 1/3] fix matching errors for overwritten registers in x86 CFI generation script Date: Wed, 14 Oct 2015 12:21:05 +0200 Message-ID: References: <1444735732-12265-1-git-send-email-alexinbeijing@gmail.com> <20151013224204.GT8645@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=047d7b3a96c29539a905220deb54 X-Trace: ger.gmane.org 1444818084 9586 80.91.229.3 (14 Oct 2015 10:21:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Oct 2015 10:21:24 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-8679-gllmg-musl=m.gmane.org@lists.openwall.com Wed Oct 14 12:21:23 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1ZmJBR-0007EF-MI for gllmg-musl@m.gmane.org; Wed, 14 Oct 2015 12:21:21 +0200 Original-Received: (qmail 30672 invoked by uid 550); 14 Oct 2015 10:21:18 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 30652 invoked from network); 14 Oct 2015 10:21:17 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=tcjxDH0rsl0cJHnEb+YqLVufoT2pZ+heoDgbgDh5jrw=; b=GBcwfacZ2Q6bluo3VP5TJ9sP/ubXzrWt1MNNEYSvDU5dxrbLYgMRt9GsX2Dd9sHLs/ hPFyC+6uKIOE0TfgzsKwBR3ihuROWG8BiFj1Wr38Jx2QKI8awdNlDCVZzdeJVJ+inN4c +nIfne4843z//pjKSVuySApoScRaJ64gv5nagiagRk/75B9GbCbWgbsHWo1MYmd5LK5j gS1qwQSgodjxEngeVd1BT+TK906GBu223qkCBjFi3vSAAVMmlUMD8rTtaJSFRVSoVIIK fYbFC5YTZTPA8SBQZQCuHXD9aR4Ti9A5KJoq+eOyUztnLAR+7vGMqkVGebxVKkwclFDQ RVlw== X-Received: by 10.50.65.8 with SMTP id t8mr117901igs.74.1444818065895; Wed, 14 Oct 2015 03:21:05 -0700 (PDT) In-Reply-To: <20151013224204.GT8645@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:8667 Archived-At: --047d7b3a96c29539a905220deb54 Content-Type: text/plain; charset=UTF-8 On Wed, Oct 14, 2015 at 12:42 AM, Rich Felker wrote: > On Tue, Oct 13, 2015 at 01:28:50PM +0200, Alex Dowad wrote: > > Here is the latest iteration. I have merged 2 previously separate > commits, and > > fixed up the matching of registers (for the purpose of identifying > overwritten > > registers). > > > > As usual, thanks for the feedback. AD > > Thanks! I'm committing them all now. I'm sorry for not catching this > before -- I realized that the index register thing was also an > existing bug in mov handling, not just a new bug added in the operand > order patch, so I split it out into a separate commit. I did basic > regression testing on i386 (making sure gdb backtrace from syscalls > still works) and tested that the x86_64 also seems to work (it does). Thanks! This has been an interesting exercise so far. Is there any other arch which you think it would be worthwhile to develop a CFI generation script for? It should be something which has enough users to avoid problems with bitrot. AD --047d7b3a96c29539a905220deb54 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On W= ed, Oct 14, 2015 at 12:42 AM, Rich Felker <dalias@libc.org> wr= ote:
On Tue, Oct 13, 201= 5 at 01:28:50PM +0200, Alex Dowad wrote:
> He= re is the latest iteration. I have merged 2 previously separate commits, an= d
> fixed up the matching of registers (for the purpose of identifying ove= rwritten
> registers).
>
> As usual, thanks for the feedback. AD

Thanks! I'm committing them all now. I'm sorry for not catch= ing this
before -- I realized that the index register thing was also an
existing bug in mov handling, not just a new bug added in the operand
order patch, so I split it out into a separate commit. I did basic
regression testing on i386 (making sure gdb backtrace from syscalls
still works) and tested that the x86_64 also seems to work (it does).

Thanks!

This has been a= n interesting exercise so far. Is there any other arch which you think it w= ould be worthwhile to develop a CFI generation script for? It should be som= ething which has enough users to avoid problems with bitrot.

=
AD
--047d7b3a96c29539a905220deb54--