From: Kyle Sanderson <kyle.leet@gmail.com>
To: musl@lists.openwall.com
Subject: Re: [Feature Request] SHA-1 HMAC
Date: Sat, 26 Oct 2013 18:30:19 -0600 [thread overview]
Message-ID: <CACsaVZKdoBQCZQFEZYu9j_JaOmivLOWK1=Nzu8e4=07iCPDdQg@mail.gmail.com> (raw)
In-Reply-To: <20131026183805.GP20515@brightrain.aerifal.cx>
[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]
Thanks for the replies! The reason why I thought it would be cool to have
SHA1-HMAC included was I had thought SHA1 was included (in the crypt/
folder). However, now that I look at it again, it's actually SHA2, which
makes the whole request bad :( I'll try my hand at porting the code from
Busybox.
Thanks for the kind responses!
Kyle.
On Sat, Oct 26, 2013 at 12:38 PM, Rich Felker <dalias@aerifal.cx> wrote:
> On Sat, Oct 26, 2013 at 02:28:48PM +0200, Szabolcs Nagy wrote:
> > * Daniel Cegie?ka <daniel.cegielka@gmail.com> [2013-10-25 21:23:03
> +0200]:
> > > Adding HMAC to musl doesn't make sense. This is only one C file, so
> > > why you just don't want to keep this in the sources of your software?
> >
> > including a source file is not optimal
>
> I think whether this is the case depends a lot on what you're doing.
> One question I always recommend asking is which will be larger and
> more work to maintain: the copied code, or the library glue? For use
> of a single hash function from a crypto lib with a complex API, just
> the glue code to setup and call the crypto lib is probably as large as
> the hash code. Then you have to consider also the build system. At
> this point we haven't even started considering the potential space for
> bugs, issues if someone uses a different implementation of the
> original crypto lib as a drop-in replacement for it (common with
> openssl), etc.
>
> So I think in this specific case, including the source file may
> actually be the optimal solution.
>
> Rich
>
[-- Attachment #2: Type: text/html, Size: 2090 bytes --]
prev parent reply other threads:[~2013-10-27 0:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 15:36 Kyle Sanderson
2013-10-25 16:00 ` Rich Felker
2013-10-25 21:08 ` Alain Toussaint
2013-10-26 2:07 ` Rich Felker
2013-11-14 6:30 ` Rob Landley
2013-10-25 19:23 ` Daniel Cegiełka
2013-10-26 12:28 ` Szabolcs Nagy
2013-10-26 18:38 ` Rich Felker
2013-10-27 0:30 ` Kyle Sanderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACsaVZKdoBQCZQFEZYu9j_JaOmivLOWK1=Nzu8e4=07iCPDdQg@mail.gmail.com' \
--to=kyle.leet@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).