From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from second.openwall.net (second.openwall.net [193.110.157.125]) by inbox.vuxu.org (Postfix) with SMTP id 87ABF27F6E for ; Wed, 12 Jun 2024 17:39:23 +0200 (CEST) Received: (qmail 32676 invoked by uid 550); 12 Jun 2024 15:39:19 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Reply-To: musl@lists.openwall.com Received: (qmail 32629 invoked from network); 12 Jun 2024 15:39:18 -0000 X-QQ-mid: bizesmtpsz2t1718206748tfjouej X-QQ-Originating-IP: HQ6kDzbS+NpPt3YxKrZGZAIgeteXdcOG7m9YMatHczk= X-QQ-SSF: 0000000000000000000000000000000 X-QQ-GoodBg: 0 X-BIZMAIL-ID: 4292441781387551708 X-Gm-Message-State: AOJu0YxDLnZKFaGLa7PpB4L5TnoCN2k/yrp6i3t/Yy1uBYl6+Neis4QF K4fkLKPnAat9kfjLnUcX/PjdjEcuKfE8NJKS/eRyAJhF/iqsD6mPDELx1Z4+U75kyWV2eMW41Qd PMaj4DS7iWgNWMEZHdtD6fVmM7xM= X-Google-Smtp-Source: AGHT+IG2wHIBTQHi8//ka+MVZkck+vqXod3A4hSQypazLYmiRNKQOThQ4c3nxR0RGxkfB52XLAZfq8a+5XhXyspPsLw= X-Received: by 2002:a81:b184:0:b0:618:498f:9dbe with SMTP id 00721157ae682-630bc6f7ee6mr158047b3.10.1718206745964; Wed, 12 Jun 2024 08:39:05 -0700 (PDT) MIME-Version: 1.0 References: <20240612151413.306650-1-mzh@mzh.io> <20240612151859.GT10433@brightrain.aerifal.cx> In-Reply-To: <20240612151859.GT10433@brightrain.aerifal.cx> From: Meng Zhuo Date: Wed, 12 Jun 2024 23:38:53 +0800 X-Gmail-Original-Message-ID: Message-ID: To: Rich Felker Cc: musl@lists.openwall.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtpsz:mzh.io:qybglogicsvrgz:qybglogicsvrgz5a-1 Subject: Re: [musl] [PATCH v2] math: add riscv64 round/roundf Sorry, I'm not familiar to mail list contribution(first time) and send another wrong patch(v3) for this. I'll fix it. Rich Felker =E4=BA=8E2024=E5=B9=B46=E6=9C=8812=E6=97=A5= =E5=91=A8=E4=B8=89 23:18=E5=86=99=E9=81=93=EF=BC=9A > > On Wed, Jun 12, 2024 at 11:14:13PM +0800, Meng Zhuo wrote: > > --- > > v1 -> v2: > > * drop =C2=B1inf check and use fabs as Rich suggested > > That is not the significant change. The significant change is fixing > completely wrong behavior on large finite inputs. > > > --- > > src/math/riscv64/round.c | 21 +++++++++++++++++++++ > > src/math/riscv64/roundf.c | 21 +++++++++++++++++++++ > > 2 files changed, 42 insertions(+) > > create mode 100644 src/math/riscv64/round.c > > create mode 100644 src/math/riscv64/roundf.c > > > > diff --git a/src/math/riscv64/round.c b/src/math/riscv64/round.c > > new file mode 100644 > > index 00000000..81991b5f > > --- /dev/null > > +++ b/src/math/riscv64/round.c > > @@ -0,0 +1,21 @@ > > +#include > > + > > +#if __riscv_flen >=3D 64 > > + > > +double round(double x) > > +{ > > + if (isnan(x)) return x; > > + if (fabs(x) >=3D 0x1p54) return x; > > Did you keep the isnan test separate to avoid raising an exception, or > for other reasons? > > Rich >