From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/8082 Path: news.gmane.org!not-for-mail From: Roman Yeryomin Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] socket.h: fix SO_* for mips Date: Thu, 2 Jul 2015 12:02:29 +0300 Message-ID: References: <1435768028-24693-1-git-send-email-roman@ubnt.com> <20150701201631.GG32532@port70.net> <20150701230415.GF1173@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1435827772 31140 80.91.229.3 (2 Jul 2015 09:02:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 2 Jul 2015 09:02:52 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-8095-gllmg-musl=m.gmane.org@lists.openwall.com Thu Jul 02 11:02:52 2015 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by plane.gmane.org with smtp (Exim 4.69) (envelope-from ) id 1ZAaOQ-0000yL-FT for gllmg-musl@m.gmane.org; Thu, 02 Jul 2015 11:02:50 +0200 Original-Received: (qmail 19947 invoked by uid 550); 2 Jul 2015 09:02:43 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Original-Received: (qmail 19929 invoked from network); 2 Jul 2015 09:02:42 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ubnt.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=CEhVVV+dDD7RYI06GsZWeIJ5kmzaM64J6NqFqMlpI6M=; b=Ag/UxMS1mDMrPp8aUCP5IbkzqdDXw3VVAoSkFHknOLuLCcpb7WbD+xOL+ZsHVWSvrm tKGYcBcd3MycDqGqH/sXuu9+i1A+HtE4TyrraiagYadzINgGa7xmMpYUOpU9Hrzg5o/R Qi7YTuht4b/rr1wecm31NNDXwv+GjkALLI65Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=CEhVVV+dDD7RYI06GsZWeIJ5kmzaM64J6NqFqMlpI6M=; b=nMRu/sI/e98B2Dru29tVYPvP06cx2Kqn03Y9wxyDflUeixa4irm1XP6gxOJpDamJMJ KmZ/pD1vjb1Jax+HZlarOtpr6s56YMQ2QFaFM/GmbVEbwjKEwUUCS77dCrvYLMygWKLx YuhUAShy7fht4MeQhUcUA61EqALzf2jHLBcqcdWAWmRRNY+2/4/Lroq+D5MqtqUiCMmo E07meTtITGMhqW/zfczdgaRhJ4XxqhXdjzgEEmd+0LtOJV4hY1WHf5JxMHLGkFdSkH8l TfPkROPevLsMiwgcDs+Xj6AziwLqsh5k5wwJcUUkMJth9Hu5qCC8EJn7eYEE1P6fygdo GrFw== X-Gm-Message-State: ALoCoQm2FsGPgqYi1isJXUa93uGxIPEtjdUZP6FAxc00EstqWK1pwhqARQ4gfGrQb1BYjpNwOMDh X-Received: by 10.43.171.202 with SMTP id nv10mr10038913icc.30.1435827749927; Thu, 02 Jul 2015 02:02:29 -0700 (PDT) In-Reply-To: <20150701230415.GF1173@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:8082 Archived-At: On Thu, Jul 2, 2015 at 2:04 AM, Rich Felker wrote: > On Thu, Jul 02, 2015 at 12:14:58AM +0300, Roman Yeryomin wrote: >> On Wed, Jul 1, 2015 at 11:16 PM, Szabolcs Nagy wrote: >> > * Roman Yeryomin [2015-07-01 19:27:08 +0300]: >> >> Signed-off-by: Roman Yeryomin >> >> --- >> >> arch/mips/bits/socket.h | 31 ++++++++++++++++++------------- >> >> arch/powerpc/bits/socket.h | 9 ++++++--- >> >> include/sys/socket.h | 6 +++--- >> >> 3 files changed, 27 insertions(+), 19 deletions(-) >> >> >> > >> >> +#define SO_ACCEPTCONN 0x1009 >> >> +#define SO_PROTOCOL 0x1028 >> >> +#define SO_DOMAIN 0x1029 >> > >> > i assume these 3 were wrong in generic sys/socket.h >> > and eveything else is ok, just reordered >> > >> >> Yes, these 3 are added to mips, powerpc and put under ifdef in >> sys/socket.h to avoid redefines. >> Other changes in mips bits/socket.h is reordering and rewriting in hex >> to be somewhat consistent and easily comparable with asm/socket.h > > OK. I think it would be good to factor this into two patches then: one > that makes the minimal change to fix the values, and another that's > pure cleanup for consistency and reordering. NP, will submit v2 > I'm somewhat skeptical of the value of cleanup since this is all > scheduled for overhaul soon, but "soon" keeps getting pushed back so > in the mean time maybe it's nice to have some cleanup anyway. :-) right :)