From: Minqiang Chen <ptpt52@gmail.com>
To: musl@lists.openwall.com
Subject: [PATCH v1] mman: fix mmap pass wrong offset to kernel
Date: Mon, 16 Oct 2017 09:09:32 +0800 [thread overview]
Message-ID: <CAE-jjv7YFQBjE1LGy2MGLBPa2enpcysnnrJw+mSkGwJKmupjAA@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
Author: Chen Minqiang <ptpt52@gmail.com>
Date: Mon Oct 16 08:57:41 2017 +0800
musl: fix mmap pass wrong offset to kernel
for example off_t x=0x8d9eb000, the x/4096 result is 0xfff8d9eb,
not 0x8d9eb as expecting
this happens on arm_cortex-a15 with gcc 6.3.x
Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
*diff --git a/src/mman/mmap.c b/src/mman/mmap.c*
*index 1592403..a09c901 100644*
*--- a/src/mman/mmap.c*
*+++ b/src/mman/mmap.c*
*@@ -27,7 +27,7 @@* void *__mmap(void *start, size_t len, int prot, int
flags, int fd, off_t off)
__vm_wait();
}
#ifdef SYS_mmap2
*- ret = __syscall(SYS_mmap2, start, len, prot, flags, fd, off/UNIT);*
*+* *ret = __syscall(SYS_mmap2, start, len, prot, flags, fd,
(unsigned long)off/UNIT);*
#else
ret = __syscall(SYS_mmap, start, len, prot, flags, fd, off);
#endif
[-- Attachment #2: Type: text/html, Size: 3093 bytes --]
next reply other threads:[~2017-10-16 1:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 1:09 Minqiang Chen [this message]
2017-10-16 11:03 ` Szabolcs Nagy
2017-10-16 16:27 ` Rich Felker
[not found] ` <94E25077-4463-454D-96BF-BA1DA9166F60@gmail.com>
2017-10-21 4:20 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-jjv7YFQBjE1LGy2MGLBPa2enpcysnnrJw+mSkGwJKmupjAA@mail.gmail.com \
--to=ptpt52@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).