From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13199 Path: news.gmane.org!.POSTED!not-for-mail From: Patrick Oppenlander Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] arm asm for vfork Date: Thu, 6 Sep 2018 17:02:14 +0200 Message-ID: References: <20180430013622.28792-1-patrick.oppenlander@gmail.com> <20180430013622.28792-2-patrick.oppenlander@gmail.com> <20180430020944.GF1392@brightrain.aerifal.cx> <20180718023526.GO1392@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1536246035 10203 195.159.176.226 (6 Sep 2018 15:00:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 6 Sep 2018 15:00:35 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-13215-gllmg-musl=m.gmane.org@lists.openwall.com Thu Sep 06 17:00:31 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fxvln-0002ZX-B0 for gllmg-musl@m.gmane.org; Thu, 06 Sep 2018 17:00:31 +0200 Original-Received: (qmail 22204 invoked by uid 550); 6 Sep 2018 15:02:37 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 22183 invoked from network); 6 Sep 2018 15:02:36 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=8uwfBNsXnNNIKJrNSrUndjnn6r8+1TrnQfpucmlKDfw=; b=hnfVySg3RMCNEyrQEBTiW7gXnYKyxcQOHwYIHQhMLInk+QYKIVvu7jCJF5Go+VjCY+ eg0Sbj3Aok+Zc9rrOcz0laBEJNs6Cz7GolIYcJize8o2M7yWL3k3TD449eFca44dzE13 0wtrRQybQHMCE0EsCCOEB0PEPyOetNVdCijLwh0HeJsH5SPUadYWpKNQsBvb7GFk0TDg jdCFZk89pVXi9KCmgZoX8LBressaumSNEj0mD/wQerQS9rFzoJLyqpdKDgys0xcXghRi ljAQoiO0r9eVamvsu80eFXKKWfUC6E3TFr4M15xq383E0X/fIvMSUCjpH9QRc2AXe87P 558Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=8uwfBNsXnNNIKJrNSrUndjnn6r8+1TrnQfpucmlKDfw=; b=iTBubradyRnx1KnPFULHrUPyOGJzEwYZNcguSthvW3eX6hzXi0nqq6ckoyLARYdN7H hOnbw6uJWNgSzTQ/DujFuQUIuYbQFQQH2wy9yQh9aPQMmXIgpP0I/qQ/u2Fc0IY+Hi5v vLCLsTI9IilDImkYN4cEmI+r4eqYdcCuxPCWh2swctuxmDVhEToZ387pl3/dUbHIKxlN 31C/uwwzNBnGlL+5uQWLciVajiMQdRM7MVKQNT3ps+apVxkeZkAGd3dCbqGXMfeEK6EC kdavnWVnqHBoSVIOacg3d8vsk1jdfbq2MKNXjSs+chPRZ4iCRVmmkSMQG17JruJ48qjf 0uvw== X-Gm-Message-State: APzg51A9swRxiMP9wOUuCQyaGyGYaKEixNKV4B2jDY+WY/y+1971H2WP 6mC2QSS837JfX5BsoQmYaigbQV9GH0ZlFJdOivRQWt06w6M= X-Google-Smtp-Source: ANB0Vda6cU9it9LsLah8MO0GuYGFxgIJCx2GLb9N52x+tQO/xHYB/qaEdBBzgilhY6JkayWfoyyCiMN/AQCi52s3Qi0= X-Received: by 2002:a2e:6c17:: with SMTP id h23-v6mr42937ljc.81.1536246145204; Thu, 06 Sep 2018 08:02:25 -0700 (PDT) In-Reply-To: Xref: news.gmane.org gmane.linux.lib.musl.general:13199 Archived-At: On Wed, Jul 18, 2018 at 6:14 AM Patrick Oppenlander wrote: > > On Wed, Jul 18, 2018 at 12:35 PM Rich Felker wrote: > > I think there needs to be a ".hidden __syscall_ret" (by de facto musl > > convention, on the line before it's used) here. It *might* be ok > > having the reference omit .hidden as long as the definition is hidden > > at link-time (which it is), but I'm not convinced the tooling won't > > complain about a branch to a destination that's not known to be > > link-time constant displacement. > > If that's the case i386, s390x, x86_64 and x32 may need attention in > vfork.s as they're doing it the same way. > > > If you have no other changes or comments I'm happy to just --amend > > that into the patch when I commit it. > > No problem with that at all. > I guess this one slipped through the cracks for 1.20. Any chance of you taking a look soon? Thanks, Patrick