From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/12788 Path: news.gmane.org!.POSTED!not-for-mail From: Patrick Oppenlander Newsgroups: gmane.linux.lib.musl.general Subject: Re: Some questions Date: Tue, 1 May 2018 12:34:13 +1000 Message-ID: References: <20180430031653.GI1392@brightrain.aerifal.cx> <20180430153112.GL1392@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0000000000005c5017056b1bce0c" X-Trace: blaine.gmane.org 1525141942 27776 195.159.176.226 (1 May 2018 02:32:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 1 May 2018 02:32:22 +0000 (UTC) Cc: musl@lists.openwall.com Original-X-From: musl-return-12804-gllmg-musl=m.gmane.org@lists.openwall.com Tue May 01 04:32:18 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fDL5V-00077X-M2 for gllmg-musl@m.gmane.org; Tue, 01 May 2018 04:32:17 +0200 Original-Received: (qmail 15560 invoked by uid 550); 1 May 2018 02:34:26 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 15541 invoked from network); 1 May 2018 02:34:25 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:cc; bh=2OUlaHu+p3Az5P7MtoLEKiwh0X1DFqGdhYSgrOgDuJ0=; b=T9BXfO1KSBksOprLWH85NdRqDBVPL4Kjj4ozvvDfRJFcLxgVSNA/4yrSD+Dwyo6Cpz dgoCa/VO79V0UITtbI0u2lKCsY72PBgafZblh8jqTKxOTSjwOmgvyi4KSlVjn0QcAyvl idHOWWacIt9riUyfvpBCW5PL+iq6MQdQ5caIaac/dLqpsqvPEwuvcskOklmH/Pdn5eRn X7uanvGm+c21JnpO7CocRS+GDnU7fXfCPt8qxC8qtH2eFkTsiQrtNRjvc+7RLpYmxwai 8sB9GEAX5MxX41dcyZP9YrOzJMtrtQHaXsW2F6DuptIHuQ7QvnKWMqLzORO91z4/KBvu B5cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:cc; bh=2OUlaHu+p3Az5P7MtoLEKiwh0X1DFqGdhYSgrOgDuJ0=; b=Y6qbxhsxQK+pHhvpqBnbsKKRxVktdfUZZJtOX5Drb+aU0SyceVmGaoOklj7jKeHOrT S+9o8evsQaWDjfZjEiEEvPBcvycwwnKmkGWjmMW2iIhwoEjy6HsRSaKI6PPNyJDcxbB2 pQG1mVZqicEylQ8NaZB0pm8wFVPOhF32wTXLaTP87gVyUsS8LMoip2hfcV3xNIk9CZlx YZ+K0pUD0KLkxhE73A8N2Ftc5FtxPaXhJPar98Gyt+m7pKSzAAr/JJUiJLzXvtznrCkY huSO3X4RGgRbJee3soeY3cgZrmT6NGCDxKKn7MHzT8RpmVnneYScxfAAWfyFfntjKkO/ BCbA== X-Gm-Message-State: ALQs6tDYCUPsDECR4TWl4t1tK3IY0YpI1OpT7ZiDHgQuGMHGyaba3cAT PuH2sEQkoc7gI/wLo0PC9bilDzT18hAvpiuYzRvb9KGq X-Google-Smtp-Source: AB8JxZruswdAFTqKa4XMRQo24jFfMMrmEmHnEpQESy8j78lXo3IKS171VedNoyTiAsYmk8M4MkyoLSGcyDMui8r9ey4= X-Received: by 2002:ac8:12c1:: with SMTP id b1-v6mr12685586qtj.164.1525142053988; Mon, 30 Apr 2018 19:34:13 -0700 (PDT) In-Reply-To: <20180430153112.GL1392@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:12788 Archived-At: --0000000000005c5017056b1bce0c Content-Type: text/plain; charset="UTF-8" On Tue, May 1, 2018 at 1:31 AM, Rich Felker wrote: > On Mon, Apr 30, 2018 at 03:29:39PM +1000, Patrick Oppenlander wrote: >> Actually, my biggest issue with getcwd is that it allocates a PATH_MAX >> sized buffer on the stack. That's painful on deeply embedded stuff. > > That's unrelated, and could/should be fixed by the attached patch I > think. Unfortunately that fails to build on arm with: src/unistd/getcwd.c: In function 'getcwd': src/unistd/getcwd.c:25:1: error: r7 cannot be used in asm here I was also having a go at resolving the stack & the buffer size issue and came up with the attached (untested) patch. Patrick --0000000000005c5017056b1bce0c Content-Type: text/x-patch; charset="US-ASCII"; name="getcwd2.diff" Content-Disposition: attachment; filename="getcwd2.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_jgn271d21 ZGlmZiAtLWdpdCBhL3NyYy91bmlzdGQvZ2V0Y3dkLmMgYi9zcmMvdW5pc3RkL2dldGN3ZC5jCmlu ZGV4IDEwM2ZiYmI1Li4zMDZkYmM0ZiAxMDA2NDQKLS0tIGEvc3JjL3VuaXN0ZC9nZXRjd2QuYwor KysgYi9zcmMvdW5pc3RkL2dldGN3ZC5jCkBAIC0zLDE3ICszLDEwIEBACiAjaW5jbHVkZSA8bGlt aXRzLmg+CiAjaW5jbHVkZSA8c3RyaW5nLmg+CiAjaW5jbHVkZSAic3lzY2FsbC5oIgorI2luY2x1 ZGUgImxpYmMuaCIKIAotY2hhciAqZ2V0Y3dkKGNoYXIgKmJ1Ziwgc2l6ZV90IHNpemUpCitzdGF0 aWMgY2hhciAqZG9fZ2V0Y3dkKGNoYXIgKmJ1Ziwgc2l6ZV90IHNpemUpCiB7Ci0JY2hhciB0bXBb UEFUSF9NQVhdOwotCWlmICghYnVmKSB7Ci0JCWJ1ZiA9IHRtcDsKLQkJc2l6ZSA9IFBBVEhfTUFY OwotCX0gZWxzZSBpZiAoIXNpemUpIHsKLQkJZXJybm8gPSBFSU5WQUw7Ci0JCXJldHVybiAwOwot CX0KIAlsb25nIHJldCA9IHN5c2NhbGwoU1lTX2dldGN3ZCwgYnVmLCBzaXplKTsKIAlpZiAocmV0 IDwgMCkKIAkJcmV0dXJuIDA7CkBAIC0yMSw1ICsxNCwzNyBAQCBjaGFyICpnZXRjd2QoY2hhciAq YnVmLCBzaXplX3Qgc2l6ZSkKIAkJZXJybm8gPSBFTk9FTlQ7CiAJCXJldHVybiAwOwogCX0KLQly ZXR1cm4gYnVmID09IHRtcCA/IHN0cmR1cChidWYpIDogYnVmOworCXJldHVybiBidWY7Cit9CisK K3N0YXRpYyBjaGFyICpnZXRjd2RfZ2xpYmMoc2l6ZV90IHNpemUpCit7CisJY2hhciB0bXBbUEFU SF9NQVhdOworCWlmICghZG9fZ2V0Y3dkKHRtcCwgc2l6ZW9mIHRtcCkpCisJCXJldHVybiAwOwor CXNpemVfdCBsZW4gPSBzdHJsZW4odG1wKSArIDE7CisJaWYgKCFzaXplKQorCQlzaXplID0gbGVu OworCWVsc2UgaWYgKHNpemUgPCBsZW4pIHsKKwkJZXJybm8gPSBFUkFOR0U7CisJCXJldHVybiAw OworCX0KKwljaGFyICpidWYgPSBtYWxsb2Moc2l6ZSk7CisJaWYgKCFidWYpIHsKKwkJZXJybm8g PSBFTk9NRU07CisJCXJldHVybiAwOworCX0KKwltZW1jcHkoYnVmLCB0bXAsIGxlbik7CisJcmV0 dXJuIGJ1ZjsKK30KKworY2hhciAqZ2V0Y3dkKGNoYXIgKmJ1Ziwgc2l6ZV90IHNpemUpCit7CisJ aWYgKCFidWYpCisJCXJldHVybiBnZXRjd2RfZ2xpYmMoc2l6ZSk7CisJaWYgKCFzaXplKSB7CisJ CWVycm5vID0gRUlOVkFMOworCQlyZXR1cm4gMDsKKwl9CisJcmV0dXJuIGRvX2dldGN3ZChidWYs IHNpemUpOwogfQo= --0000000000005c5017056b1bce0c--