From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13054 Path: news.gmane.org!.POSTED!not-for-mail From: Patrick Oppenlander Newsgroups: gmane.linux.lib.musl.general Subject: Re: [PATCH] arm asm for vfork Date: Wed, 18 Jul 2018 14:14:00 +1000 Message-ID: References: <20180430013622.28792-1-patrick.oppenlander@gmail.com> <20180430013622.28792-2-patrick.oppenlander@gmail.com> <20180430020944.GF1392@brightrain.aerifal.cx> <20180718023526.GO1392@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Trace: blaine.gmane.org 1531887142 7091 195.159.176.226 (18 Jul 2018 04:12:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 18 Jul 2018 04:12:22 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-13070-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jul 18 06:12:18 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1ffdp1-0001gn-83 for gllmg-musl@m.gmane.org; Wed, 18 Jul 2018 06:12:15 +0200 Original-Received: (qmail 8159 invoked by uid 550); 18 Jul 2018 04:14:23 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 8141 invoked from network); 18 Jul 2018 04:14:23 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=HDcWdZ6+4fjrXXdhtkazWLJ24bsbqsriEkESJvzXAZQ=; b=Eaewyoxc1gc2Bvy45W9pF7v0ScpOuX7sPFfTByUhHmi3FYtgcFhLGRgJEPoHU2qKEh MNCNomaCAwx2D0ELKFEZtwOPVqq3Axq4nbGUFEkFlvqjxX2Gl2HOpIkBq/UMHvdUmwyu J6R/gKqoOFhyAq/rSmILgy9xXMfnJkr2l9k5iZdXQxbTl/+YcKV2jQ3ysPH3Tj00p0dM gfRsTDkjq01Vp/sbqX9gGn0NrXLIkoVSWx6lTn1hsVPeSDcmc0JwE99PDi1j83LieE6l 2IBeR9nEX6Kzo9yhPuXPI/Isxeaxy0fSS6keT5iMEcy94arjuGVUSGHXwnOtJr0oPPtv lLFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=HDcWdZ6+4fjrXXdhtkazWLJ24bsbqsriEkESJvzXAZQ=; b=RBn8adXaAhpWPo+pWOpRZigFvmkQTrDZQOZm3CciELKwa3aRnmhMhPifNy12Q8523v fUvqDvvfe4DW4YSHabaLf6Ml5sk1d8xekGH8w6rNcXS0TBsTGP9AqM/BEJv4fIi8Yu5Y 8Cq62jFhP7p/HQyjFAYQAKs2QHvEOj83d2VjZEI+hTE6zMyxH0by4OGPjptUm/tsvr7N 09vHLjyNzZYPsBpTB8Jq8A0nlPiiVJWondiBotlUzFg6tv3wYI3Xw9yzR90kSYihGSGw PqeSzNZcVWxaRW4KqJJ4RKjO7qd9Iii7XZvKQjN+nT8fU6YTx5Eswhpgxga6lO/6YLVT i2bw== X-Gm-Message-State: AOUpUlEMWGZn3bYkq1Fioc4mpQaFZKnQ72pJuQuX14gjAkNC0N+xgLM7 LMumeaCI87h6GJrjuA0YyGLwzvUF+ofdsdWxdVfYCQ== X-Google-Smtp-Source: AAOMgpdoKIJsSyu8wVf5SG3URsUA7rID9sNLU8vCWLNcX4oqPAugpRjA6nAdIWkAp0nmvZemga5kJjAHLGqBlPx5Wsg= X-Received: by 2002:a19:cc0f:: with SMTP id c15-v6mr2617881lfg.145.1531887251465; Tue, 17 Jul 2018 21:14:11 -0700 (PDT) In-Reply-To: <20180718023526.GO1392@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:13054 Archived-At: On Wed, Jul 18, 2018 at 12:35 PM Rich Felker wrote: > I think there needs to be a ".hidden __syscall_ret" (by de facto musl > convention, on the line before it's used) here. It *might* be ok > having the reference omit .hidden as long as the definition is hidden > at link-time (which it is), but I'm not convinced the tooling won't > complain about a branch to a destination that's not known to be > link-time constant displacement. If that's the case i386, s390x, x86_64 and x32 may need attention in vfork.s as they're doing it the same way. > If you have no other changes or comments I'm happy to just --amend > that into the patch when I commit it. No problem with that at all. Thanks, Patrick