From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13036 Path: news.gmane.org!.POSTED!not-for-mail From: Christopher Friedt Newsgroups: gmane.linux.lib.musl.general Subject: Re: Possible oversight in setvbuf() Date: Fri, 13 Jul 2018 17:46:54 -0400 Message-ID: References: <20180713144052.GA13099@voyager> <20180713213110.GD1392@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000c7d6250570e86b87" X-Trace: blaine.gmane.org 1531518318 20271 195.159.176.226 (13 Jul 2018 21:45:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 13 Jul 2018 21:45:18 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-13052-gllmg-musl=m.gmane.org@lists.openwall.com Fri Jul 13 23:45:14 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fe5sG-00058V-A2 for gllmg-musl@m.gmane.org; Fri, 13 Jul 2018 23:45:12 +0200 Original-Received: (qmail 5676 invoked by uid 550); 13 Jul 2018 21:47:20 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 5655 invoked from network); 13 Jul 2018 21:47:19 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=VdW/rHNQP+G9U82TzIdyVn80MuOcJBQd67I0sVyWgbE=; b=F3GsnqtoteQkGf2mf7oV9tP2ktAiT5ngI+IOFaJoCYzonZ6uifoX03o1ToeYFvNdAd 8NG4Tmay045bhg5R2z76Qsu7yOpGjexsn/wrdbR8DACEyhPPM1+eFtepR+wR95tctQJ8 GlO91cn78lzbQ47zNWH+ZtiR3W6kH1HNPsQs8XQJdhdnNXwl5u318ct1TQHQVwV18h7W ideV+VcfpX9p/I2/p6Df4oxkBcVOK8orl9I1EwCvBX5PB5SvrFVh/OJZ4r/Pt0lHmapA 8G5o9nYqEPkWsm0wxubUqfGiEYwE1yuxn5swJdXP2QOxZULtKbvr0HrZkKza1DWS9FKX fHkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=VdW/rHNQP+G9U82TzIdyVn80MuOcJBQd67I0sVyWgbE=; b=oly3U+pCha1/sBzjd5UX35gk3WW7eCXGw2nPBJrwEHpAw3E6Pwk+1+Jdq5FdT7COw7 a0fDWxdX4S1NHMptTbH26lcVVzDSVRgcJj/Ex3EZzawC5zLDsySXA7Tbw0fc6gb0WJrT iIkkdzSPUUnmb4nOqDAC/ZmFxCRYchu2hVhoI+88Kace1w+yAS3MQJRFDAqQfFCsuAr1 WB0Sad22075XbPliA284GaMss8ffOOHaK7MxCG3nLRSr+27Ntha4xKISHy+FwuVdWpsi FlKiKFozxLlEvbFcHgcX9is8b/ttPpgA7pFaXyww08NC771yXpi+l++gnRUBcqiCEUgW Sj7g== X-Gm-Message-State: AOUpUlEXYhsX6baQO/IEgTcU6ky+v+H7/KTTZqx6KSLkw/Sx8Xk4Hv3X 2qnJ3Z71zGuD+Txo9WoZeGoXRTxGPdQ+8Ba6/E78sA== X-Google-Smtp-Source: AAOMgpeQ0nGN1AS58koE2N1PQl1fnhU09/sIpPGQT4iKepPVAVh16ZCRQKEUqLqgRgZIyZukN6Y8c3jqncaSdEAB/cM= X-Received: by 2002:aca:ad4f:: with SMTP id w76-v6mr9330084oie.233.1531518426533; Fri, 13 Jul 2018 14:47:06 -0700 (PDT) In-Reply-To: <20180713213110.GD1392@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:13036 Archived-At: --000000000000c7d6250570e86b87 Content-Type: text/plain; charset="UTF-8" On Fri, Jul 13, 2018, 5:31 PM Rich Felker, wrote: > One thing this highlights is that we could really use better testing > and security review process. I'll write and > Using some static analysis tool would be good too - not sure if that's in use already. A good process for adding new features is to add tests with them. Even if there is only a test for expected behaviour, at least it will catch one possible regression. > --000000000000c7d6250570e86b87 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


= On Fri, Jul 13, 2018, 5:31 PM Rich Felker, <dalias@libc.org> wrote:
One thing this highlights is that we could really use better testing
and security review process. I'll write and=C2=A0

Using some static anal= ysis tool would be good too - not sure if that's in use already.
<= div dir=3D"auto">
A good process for adding new = features is to add tests with them. Even if there is only a test for expect= ed behaviour, at least it will catch one possible regression.
--000000000000c7d6250570e86b87--