From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13021 Path: news.gmane.org!.POSTED!not-for-mail From: Christopher Friedt Newsgroups: gmane.linux.lib.musl.general Subject: Re: getaddrinfo(3) / AI_ADDRCONFIG Date: Wed, 11 Jul 2018 12:50:53 -0400 Message-ID: References: <20180710005943.GT1392@brightrain.aerifal.cx> <20180710150854.GU1392@brightrain.aerifal.cx> <20180711003816.GV1392@brightrain.aerifal.cx> <20180711012640.GW1392@brightrain.aerifal.cx> <20180711164417.GX1392@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="00000000000073904c0570bc0dbe" X-Trace: blaine.gmane.org 1531327755 27277 195.159.176.226 (11 Jul 2018 16:49:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 11 Jul 2018 16:49:15 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-13037-gllmg-musl=m.gmane.org@lists.openwall.com Wed Jul 11 18:49:11 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fdIIg-0006yX-Qc for gllmg-musl@m.gmane.org; Wed, 11 Jul 2018 18:49:10 +0200 Original-Received: (qmail 28491 invoked by uid 550); 11 Jul 2018 16:51:18 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 28473 invoked from network); 11 Jul 2018 16:51:17 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=uV+m3AoieM3XRTJFr89G/L30fo3DyA15Yc1aiLM5YBM=; b=XGZv3Ux7QSasny5QqsSHcHxFr/YUFCInCWmPC0GlKNgomiIGuFzJ/AqGc4A16BljDQ dhql+IzSafYUkHm13dLNoA06aKdYqDhAfU/algGneo64VmjYEnPEkmory+D0IlilZNeP FhI+0EZ8tlJpARHb4aRUb67T/fY5v76HLxChO76iR9LVkMaBTQ0rWNwpk1ewYYpRXKx8 6J8+ZzYTrE7JKFisONI4w1Gr6du28zwgXfKTwJyMXwAYYdQKjMFGCZjcvWz95AqxdZ8e 4xtY66E1+CHTcdDe3pH8SAMIjnSUpTE6oqw26Wu5n9Tn2N0rMR/bYXa6c3gCYQukqHXJ er5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=uV+m3AoieM3XRTJFr89G/L30fo3DyA15Yc1aiLM5YBM=; b=HTfpV+FXg2oAEtueAfkQM9i6jVEDEV26meun7UWAkS5rUmG1WLODQoJBYUnCQrBdg0 uv8lCYxD/+1q+RIhF0eoVkR3Vvpy/8wJa5Nal/r02zKH4aT5w40svKh4h4kipRKyrbwI oMDFOBxg/X2E9UhzV0qie4loH01WqgTkErMs/93qD94IZi6SIAJwNcIxXLxXoRV6FIld QBu4ekpppfHQJrfQ/Y0OIKww23U7zgbA325p9xm9DBFFmY+/epwTqqT064kxvG0kaR55 Z8crBO7pUn+1wFJkTfvZ/cDd3fzIs0uYYAV2nmLPNjq4BwPeHTdK3cbM8IzrAUkLNlT0 N0Rw== X-Gm-Message-State: AOUpUlGi/4F+3Nxv92Pf18sDYHQ2HV45vg4R2PelwJkFJla4MNHUQmDG EaIp+Z4QmKNZH7KF8uDJQR7m29eqizzwsbTb1frUrQ== X-Google-Smtp-Source: AAOMgpcE317xDNICqjiIt7S3WD/SZdGOebsLB8LMwx9puIf1J/vF9wzDlzAy/38Vj50O2Hy7NPcmnSmVKLYVY5R7H60= X-Received: by 2002:aca:af15:: with SMTP id y21-v6mr67076oie.324.1531327865391; Wed, 11 Jul 2018 09:51:05 -0700 (PDT) In-Reply-To: <20180711164417.GX1392@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:13021 Archived-At: --00000000000073904c0570bc0dbe Content-Type: text/plain; charset="UTF-8" On Wed, Jul 11, 2018, 12:44 PM Rich Felker, wrote: > On Wed, Jul 11, 2018 at 06:12:31AM -0400, Christopher Friedt wrote: > > On Tue, Jul 10, 2018 at 9:26 PM Rich Felker wrote: > > > Pulling in large amounts of additional code and O(n) runtime cost > > > > Latest patch [1] addresses > > > > 1) not ignoring loopback > > 2) using routability of udp packets vs O(n) lookup on network interfaces > > > > Any other concerns, Rich? > > You seem to have deleted the original patch and replaced it with a new > Some lists prefer patches to be inline. I wasn't sure if you wanted the attachment. That clarifies that. With that said, it still makes sprawling changes and intraduces a > gratuitous new file with external interface for something that > fundamentally takes only a few lines in one place and no external > interface at all. Formatting is also I'll put it directly inside of getaddrinfo. inconsistent with musl (spaces > after opening and before closing paren, etc.). Ok, will reformat. And addition of the > nonstandard EAI_NODATA is an independent change that, if it makes > sense at all, needs to be discussed Right. What error would you prefer? C --00000000000073904c0570bc0dbe Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


= On Wed, Jul 11, 2018, 12:44 PM Rich Felker, <dalias@libc.org> wrote:
On Wed, Jul 11, 2018 at 06:12:31AM -0400, Christopher Friedt wrote:
> On Tue, Jul 10, 2018 at 9:26 PM Rich Felker <dalias@libc.org> w= rote:
> > Pulling in large amounts of additional code and O(n) runtime cost=
>
> Latest patch [1] addresses
>
> 1) not ignoring loopback
> 2) using routability of udp packets vs O(n) lookup on network interfac= es
>
> Any other concerns, Rich?

You seem to have deleted the original patch and replaced it with a new
<= /blockquote>


<= /div>
Some lists prefer patches to be inline. I wasn't= sure if you wanted the attachment. That clarifies that.

With that said, it still makes sprawling changes and intraduces a
gratuitous new file with external interface for something that
fundamentally takes only a few lines in one place and no external
interface at all. Formatting is also

I'll put it directly inside of getaddr= info.

inconsistent with musl (spaces<= br> after opening and before closing paren, etc.).

Ok, will reformat.

And addition of the
nonstandard EAI_NODATA is an independent change that, if it makes
sense at all, needs to be discussed

Right. What error would you prefer?

C
--00000000000073904c0570bc0dbe--