mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Christopher Friedt <chrisfriedt@gmail.com>
To: musl@lists.openwall.com
Subject: getaddrinfo(3) / AI_ADDRCONFIG
Date: Mon, 9 Jul 2018 11:16:04 -0400	[thread overview]
Message-ID: <CAF4BF-S7VOBq9YnaN3gu7N==aujkfytgPN6qiXXKyHjO=gn-xw@mail.gmail.com> (raw)

Hi list,

I have a patch for getaddrinfo(3) so that AI_ADDRCONFIG is properly
supported. Currently, if user code passes in the aforementioned flag,
there is no check to see whether a non-loopback network interface is
configured with the specified (or unspecified) address family before
returning results, which is what getaddrinfo(3) should do according to
[1].

As a result of the current behaviour, musl's getaddrinfo(3) would
return e.g. "::1" to user code even when no interfaces (including lo)
were configured with IPv6 addresses. I've documented this to some
extent here [2].

Please see the patch at [3] for my fix. Any feedback is welcome. The
patch It applies against master and 1.1.19, but possibly other
releases.

C

[1] http://man7.org/linux/man-pages/man3/getaddrinfo.3.html
[2] https://issues.apache.org/jira/browse/THRIFT-4594
[3] https://patch-diff.githubusercontent.com/raw/cfriedt/musl/pull/1
https://patch-diff.githubusercontent.com/raw/cfriedt/musl/pull/1.diff


             reply	other threads:[~2018-07-09 15:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09 15:16 Christopher Friedt [this message]
2018-07-09 22:38 ` Rich Felker
2018-07-10  0:11   ` Christopher Friedt
2018-07-10  0:59     ` Rich Felker
2018-07-10 12:05       ` Christopher Friedt
2018-07-10 15:08         ` Rich Felker
2018-07-10 23:21           ` Christopher Friedt
2018-07-10 23:30             ` Christopher Friedt
2018-07-10 23:42               ` Christopher Friedt
2018-07-11  0:38               ` Rich Felker
2018-07-11  1:01                 ` Christopher Friedt
2018-07-11  1:26                   ` Rich Felker
2018-07-11 10:12                     ` Christopher Friedt
2018-07-11 16:44                       ` Rich Felker
2018-07-11 16:50                         ` Christopher Friedt
2018-07-11 17:00                           ` Rich Felker
2018-07-12  1:20                             ` Christopher Friedt
2018-07-13  1:49                               ` Rich Felker
2018-07-13  2:53                                 ` Christopher Friedt
2018-07-14  2:31                                   ` Rich Felker
2018-07-14 23:53                                     ` Christopher Friedt
2018-07-15  0:07                                       ` Rich Felker
2018-07-15  0:19                                         ` Rich Felker
2018-07-15  0:52                                           ` Rich Felker
2018-07-15  1:17                                             ` Christopher Friedt
2018-07-19  0:14                                               ` Christopher Friedt
2018-07-19  0:49                                                 ` Rich Felker
2018-07-19  0:57                                                   ` Christopher Friedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAF4BF-S7VOBq9YnaN3gu7N==aujkfytgPN6qiXXKyHjO=gn-xw@mail.gmail.com' \
    --to=chrisfriedt@gmail.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).