From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.org/gmane.linux.lib.musl.general/13023 Path: news.gmane.org!.POSTED!not-for-mail From: Christopher Friedt Newsgroups: gmane.linux.lib.musl.general Subject: Re: getaddrinfo(3) / AI_ADDRCONFIG Date: Wed, 11 Jul 2018 21:20:20 -0400 Message-ID: References: <20180710150854.GU1392@brightrain.aerifal.cx> <20180711003816.GV1392@brightrain.aerifal.cx> <20180711012640.GW1392@brightrain.aerifal.cx> <20180711164417.GX1392@brightrain.aerifal.cx> <20180711170034.GY1392@brightrain.aerifal.cx> Reply-To: musl@lists.openwall.com NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="00000000000059124a0570c32b7b" X-Trace: blaine.gmane.org 1531358321 12884 195.159.176.226 (12 Jul 2018 01:18:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 12 Jul 2018 01:18:41 +0000 (UTC) To: musl@lists.openwall.com Original-X-From: musl-return-13039-gllmg-musl=m.gmane.org@lists.openwall.com Thu Jul 12 03:18:37 2018 Return-path: Envelope-to: gllmg-musl@m.gmane.org Original-Received: from mother.openwall.net ([195.42.179.200]) by blaine.gmane.org with smtp (Exim 4.84_2) (envelope-from ) id 1fdQFg-0003Fm-Sc for gllmg-musl@m.gmane.org; Thu, 12 Jul 2018 03:18:37 +0200 Original-Received: (qmail 9586 invoked by uid 550); 12 Jul 2018 01:20:44 -0000 Mailing-List: contact musl-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Original-Received: (qmail 9567 invoked from network); 12 Jul 2018 01:20:43 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=R4HXCutDyjVK1cdMDH8vTP9COCP3aNFLQEdDRdMislY=; b=Dj5UuO+BP8GoKO5ORrJwWcAQ2OuB6DOF8WofuGc0ZrEGu026ZJ0X4lYAegg22MWZp0 YEzK9NHyjWaD9Ud0LTcLPSBpFOU/E/DO60T8mQECwIUx7Ky19da0xv3VdRfrm4zAntlF f6TEEA0H8QqjZB8rjsn5r7Yh0Xf1ylaa0KeZhyMq1S1PZeiXdHjYquw0ix3NhgomrWAl vssrmph6vAZ4fleGskahdo5P4baL2Yeq1oTUFKdwlGRV/xMNS4u2JWwUKuccUbXhOc2/ lMLqer21wBr2SSMnCazL8JlJXRpBQdf/rSPv+/9fp17OfXePgy6FLaU1gUgZdbw0dgLg bQdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=R4HXCutDyjVK1cdMDH8vTP9COCP3aNFLQEdDRdMislY=; b=qzGdMfmOOiue4w12YrW7Uz6RSJt6pQc7t7KpKDaWgvG1y7l+8pcpiYPif01TgkQqgO OQ4jD6IA0wNDI6SCL8KOkxyS+i7Ll6p3GhNu/yIbz3JPgNVLEnJknYN1wUL8R0dpDi/u VnCjwBM3nd61Q4xFOMGVjI1LjZ/pCBaS+FyyElbduXfKmG+KVgkKEdoMjTiWAhiv4OaX lYfYTpnHNp7zRYRrKcAC+7px/NRB1uoFFJEM20J9plsRYvmJAODalec8ZC5j6x1tx6A0 ES6PheQvndmAUktM9FD7nbRmS1KAvOP8xBYwZZm3JPPBNr96urnR95ty0LG5WyFUsrRG FaXg== X-Gm-Message-State: AOUpUlGLHCUjqAfNaEQfek10pqQcphHDqEBaYmp7onbk/3pBqnZ80H/g rjPWvJslYj4jNWDt4NQtaV5QqQkhdKnjdFaPjat7Kw== X-Google-Smtp-Source: AAOMgpdl0Y2s/WEHuF9//BQzcpygUYERVHjAmJDXk+2PYhBP+gituQI/xPdlQclM48rlKnbjDSL0FbDUlIIzjfjlDug= X-Received: by 2002:aca:4d87:: with SMTP id a129-v6mr226325oib.256.1531358431732; Wed, 11 Jul 2018 18:20:31 -0700 (PDT) In-Reply-To: <20180711170034.GY1392@brightrain.aerifal.cx> Xref: news.gmane.org gmane.linux.lib.musl.general:13023 Archived-At: --00000000000059124a0570c32b7b Content-Type: text/plain; charset="UTF-8" On Wed, Jul 11, 2018 at 1:00 PM Rich Felker wrote: > It could probably go inside __lookup_name, but maybe in getaddrinfo is > better since that would avoid linking it for gethostbyname, etc. > (which don't need it). Done > > inconsistent with musl (spaces > > > after opening and before closing paren, etc.). Done > I think the one mandated by POSIX is EAI_NONAME ("The name does not > resolve for the supplied parameters"). Done --00000000000059124a0570c32b7b Content-Type: application/octet-stream; name="v3.diff" Content-Disposition: attachment; filename="v3.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jjhv84ki0 ZGlmZiAtLWdpdCBhL3NyYy9uZXR3b3JrL2dldGFkZHJpbmZvLmMgYi9zcmMvbmV0d29yay9nZXRh ZGRyaW5mby5jCmluZGV4IGI5NDM5Zjc3Li43MjI3NmRkYyAxMDA2NDQKLS0tIGEvc3JjL25ldHdv cmsvZ2V0YWRkcmluZm8uYworKysgYi9zcmMvbmV0d29yay9nZXRhZGRyaW5mby5jCkBAIC0xLDgg KzEsMTAgQEAKKyNpbmNsdWRlIDxzdGRib29sLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+CiAjaW5j bHVkZSA8c3lzL3NvY2tldC5oPgogI2luY2x1ZGUgPG5ldGluZXQvaW4uaD4KICNpbmNsdWRlIDxu ZXRkYi5oPgogI2luY2x1ZGUgPHN0cmluZy5oPgorI2luY2x1ZGUgPHVuaXN0ZC5oPgogI2luY2x1 ZGUgImxvb2t1cC5oIgogCiBpbnQgZ2V0YWRkcmluZm8oY29uc3QgY2hhciAqcmVzdHJpY3QgaG9z dCwgY29uc3QgY2hhciAqcmVzdHJpY3Qgc2VydiwgY29uc3Qgc3RydWN0IGFkZHJpbmZvICpyZXN0 cmljdCBoaW50LCBzdHJ1Y3QgYWRkcmluZm8gKipyZXN0cmljdCByZXMpCkBAIC0xMCw3ICsxMiw3 IEBAIGludCBnZXRhZGRyaW5mbyhjb25zdCBjaGFyICpyZXN0cmljdCBob3N0LCBjb25zdCBjaGFy ICpyZXN0cmljdCBzZXJ2LCBjb25zdCBzdHJ1CiAJc3RydWN0IHNlcnZpY2UgcG9ydHNbTUFYU0VS VlNdOwogCXN0cnVjdCBhZGRyZXNzIGFkZHJzW01BWEFERFJTXTsKIAljaGFyIGNhbm9uWzI1Nl0s ICpvdXRjYW5vbjsKLQlpbnQgbnNlcnZzLCBuYWRkcnMsIG5haXMsIGNhbm9uX2xlbiwgaSwgaiwg azsKKwlpbnQgbnNlcnZzLCBuYWRkcnMsIG5haXMsIGNhbm9uX2xlbiwgaSwgaiwgaywgZmQsIHI7 CiAJaW50IGZhbWlseSA9IEFGX1VOU1BFQywgZmxhZ3MgPSAwLCBwcm90byA9IDAsIHNvY2t0eXBl ID0gMDsKIAlzdHJ1Y3QgYWlidWYgewogCQlzdHJ1Y3QgYWRkcmluZm8gYWk7CkBAIC0xOSw2ICsy MSwxMSBAQCBpbnQgZ2V0YWRkcmluZm8oY29uc3QgY2hhciAqcmVzdHJpY3QgaG9zdCwgY29uc3Qg Y2hhciAqcmVzdHJpY3Qgc2VydiwgY29uc3Qgc3RydQogCQkJc3RydWN0IHNvY2thZGRyX2luNiBz aW42OwogCQl9IHNhOwogCX0gKm91dDsKKwlzdHJ1Y3QgYWRkcmNvbmZpZyB7CisJCWJvb2wgYWZf aW5ldDsKKwkJYm9vbCBhZl9pbmV0NjsKKwl9IGFkZHJjb25maWc7CisJc3RydWN0IHNvY2thZGRy X3N0b3JhZ2Ugc2FzOwogCiAJaWYgKCFob3N0ICYmICFzZXJ2KSByZXR1cm4gRUFJX05PTkFNRTsK IApAQCAtMzMsNiArNDAsMzUgQEAgaW50IGdldGFkZHJpbmZvKGNvbnN0IGNoYXIgKnJlc3RyaWN0 IGhvc3QsIGNvbnN0IGNoYXIgKnJlc3RyaWN0IHNlcnYsIGNvbnN0IHN0cnUKIAkJaWYgKChmbGFn cyAmIG1hc2spICE9IGZsYWdzKQogCQkJcmV0dXJuIEVBSV9CQURGTEFHUzsKIAorCQlpZiAoZmxh Z3MgJiBBSV9BRERSQ09ORklHKSB7CisJCQkqKChzdHJ1Y3Qgc29ja2FkZHJfaW4gKikoJnNhcykp ID0gKHN0cnVjdCBzb2NrYWRkcl9pbil7CisJCQkJLnNpbl9mYW1pbHkgPSBBRl9JTkVULAorCQkJ CS5zaW5fcG9ydCA9IGh0b25zKDQyKSwKKwkJCQkuc2luX2FkZHIuc19hZGRyID0gSU5BRERSX0xP T1BCQUNLLAorCQkJfTsKKwkJCWFkZHJjb25maWcuYWZfaW5ldCA9IGZhbHNlOworCQkJciA9IHNv Y2tldChBRl9JTkVULCBTT0NLX0RHUkFNLCAwKTsKKwkJCWlmICgtMSAhPSByKSB7CisJCQkJZmQg PSByOworCQkJCXIgPSBjb25uZWN0KGZkLCAoc3RydWN0IHNvY2thZGRyICopICYgc2FzLCBzaXpl b2YoIHN0cnVjdCBzb2NrYWRkcl9pbiApKTsKKwkJCQlhZGRyY29uZmlnLmFmX2luZXQgPSAwID09 IHI7CisJCQkJY2xvc2UoZmQpOworCQkJfQorCQkJKigoc3RydWN0IHNvY2thZGRyX2luNiAqKSgm c2FzKSkgPSAoc3RydWN0IHNvY2thZGRyX2luNil7CisJCQkJLnNpbjZfZmFtaWx5ID0gQUZfSU5F VDYsCisJCQkJLnNpbjZfcG9ydCA9IGh0b25zKDQyKSwKKwkJCQkuc2luNl9hZGRyID0gSU42QURE Ul9MT09QQkFDS19JTklULAorCQkJfTsKKwkJCWFkZHJjb25maWcuYWZfaW5ldDYgPSBmYWxzZTsK KwkJCXIgPSBzb2NrZXQoQUZfSU5FVDYsIFNPQ0tfREdSQU0sIDApOworCQkJaWYgKC0xICE9IHIp IHsKKwkJCQlmZCA9IHI7CisJCQkJciA9IGNvbm5lY3QoZmQsIChzdHJ1Y3Qgc29ja2FkZHIgKikg JiBzYXMsIHNpemVvZihzdHJ1Y3Qgc29ja2FkZHJfaW42KSk7CisJCQkJYWRkcmNvbmZpZy5hZl9p bmV0NiA9IDAgPT0gcjsKKwkJCQljbG9zZShmZCk7CisJCQl9CisJCX0KKwogCQlzd2l0Y2ggKGZh bWlseSkgewogCQljYXNlIEFGX0lORVQ6CiAJCWNhc2UgQUZfSU5FVDY6CkBAIC02MSwzMCArOTcs NDMgQEAgaW50IGdldGFkZHJpbmZvKGNvbnN0IGNoYXIgKnJlc3RyaWN0IGhvc3QsIGNvbnN0IGNo YXIgKnJlc3RyaWN0IHNlcnYsIGNvbnN0IHN0cnUKIAkJb3V0Y2Fub24gPSAwOwogCX0KIAotCWZv ciAoaz1pPTA7IGk8bmFkZHJzOyBpKyspIGZvciAoaj0wOyBqPG5zZXJ2czsgaisrLCBrKyspIHsK LQkJb3V0W2tdLmFpID0gKHN0cnVjdCBhZGRyaW5mbyl7Ci0JCQkuYWlfZmFtaWx5ID0gYWRkcnNb aV0uZmFtaWx5LAotCQkJLmFpX3NvY2t0eXBlID0gcG9ydHNbal0uc29ja3R5cGUsCi0JCQkuYWlf cHJvdG9jb2wgPSBwb3J0c1tqXS5wcm90bywKLQkJCS5haV9hZGRybGVuID0gYWRkcnNbaV0uZmFt aWx5ID09IEFGX0lORVQKLQkJCQk/IHNpemVvZihzdHJ1Y3Qgc29ja2FkZHJfaW4pCi0JCQkJOiBz aXplb2Yoc3RydWN0IHNvY2thZGRyX2luNiksCi0JCQkuYWlfYWRkciA9ICh2b2lkICopJm91dFtr XS5zYSwKLQkJCS5haV9jYW5vbm5hbWUgPSBvdXRjYW5vbiwKLQkJCS5haV9uZXh0ID0gJm91dFtr KzFdLmFpIH07CisJZm9yIChrPWk9MDsgaTxuYWRkcnM7IGkrKykgZm9yIChqPTA7IGo8bnNlcnZz OyBqKyspIHsKIAkJc3dpdGNoIChhZGRyc1tpXS5mYW1pbHkpIHsKIAkJY2FzZSBBRl9JTkVUOgor CQkJaWYgKChmbGFncyAmIEFJX0FERFJDT05GSUcpICYmICFhZGRyY29uZmlnLmFmX2luZXQpIHsK KwkJCQluYWlzLS07CisJCQkJY29udGludWU7CisJCQl9CiAJCQlvdXRba10uc2Euc2luLnNpbl9m YW1pbHkgPSBBRl9JTkVUOwogCQkJb3V0W2tdLnNhLnNpbi5zaW5fcG9ydCA9IGh0b25zKHBvcnRz W2pdLnBvcnQpOwogCQkJbWVtY3B5KCZvdXRba10uc2Euc2luLnNpbl9hZGRyLCAmYWRkcnNbaV0u YWRkciwgNCk7CiAJCQlicmVhazsKIAkJY2FzZSBBRl9JTkVUNjoKKwkJCWlmICgoZmxhZ3MgJiBB SV9BRERSQ09ORklHICkgJiYgIWFkZHJjb25maWcuYWZfaW5ldDYpIHsKKwkJCQluYWlzLS07CisJ CQkJY29udGludWU7CisJCQl9CiAJCQlvdXRba10uc2Euc2luNi5zaW42X2ZhbWlseSA9IEFGX0lO RVQ2OwogCQkJb3V0W2tdLnNhLnNpbjYuc2luNl9wb3J0ID0gaHRvbnMocG9ydHNbal0ucG9ydCk7 CiAJCQlvdXRba10uc2Euc2luNi5zaW42X3Njb3BlX2lkID0gYWRkcnNbaV0uc2NvcGVpZDsKIAkJ CW1lbWNweSgmb3V0W2tdLnNhLnNpbjYuc2luNl9hZGRyLCAmYWRkcnNbaV0uYWRkciwgMTYpOwot CQkJYnJlYWs7CQkJCisJCQlicmVhazsKIAkJfQorCQlvdXRba10uYWkgPSAoc3RydWN0IGFkZHJp bmZvKXsKKwkJCS5haV9mYW1pbHkgPSBhZGRyc1tpXS5mYW1pbHksCisJCQkuYWlfc29ja3R5cGUg PSBwb3J0c1tqXS5zb2NrdHlwZSwKKwkJCS5haV9wcm90b2NvbCA9IHBvcnRzW2pdLnByb3RvLAor CQkJLmFpX2FkZHJsZW4gPSBhZGRyc1tpXS5mYW1pbHkgPT0gQUZfSU5FVAorCQkJCT8gc2l6ZW9m KHN0cnVjdCBzb2NrYWRkcl9pbikKKwkJCQk6IHNpemVvZihzdHJ1Y3Qgc29ja2FkZHJfaW42KSwK KwkJCS5haV9hZGRyID0gKHZvaWQgKikmb3V0W2tdLnNhLAorCQkJLmFpX2Nhbm9ubmFtZSA9IG91 dGNhbm9uLAorCQkJLmFpX25leHQgPSAmb3V0W2srMV0uYWkgfTsKKwkJaysrOworCX0KKwlpZiAo IG5haXMgPCAxICkgeworCQlmcmVlKCBvdXQgKTsKKwkJcmV0dXJuIEVBSV9OT05BTUU7CiAJfQog CW91dFtuYWlzLTFdLmFpLmFpX25leHQgPSAwOwogCSpyZXMgPSAmb3V0LT5haTsK --00000000000059124a0570c32b7b--