From: "Érico Rolim" <erico.erc@gmail.com>
To: mtk.manpages@gmail.com
Cc: linux-man@vger.kernel.org, musl@lists.openwall.com, ericonr@disroot.org
Subject: [musl] [PATCH v2] posix_fallocate.3: add EOPNOTSUPP error code.
Date: Sun, 13 Sep 2020 12:49:48 -0300 [thread overview]
Message-ID: <CAFDeuWM5Bu1Hq7FFUBvoxHJfEUTD=FDK35aJUQEYFGyCnx37NQ@mail.gmail.com> (raw)
In-Reply-To: <20200913141808.GM3265@brightrain.aerifal.cx>
As can be seen in
https://git.musl-libc.org/cgit/musl/tree/src/fcntl/posix_fallocate.c?id=73cc775bee53300c7cf759f37580220b18ac13d3
musl libc returns the syscall's errors directly, which means it doesn't
perform the same emulation as glibc, and can return EOPNOTSUPP to an
application, which isnt't listed in ERRORS.
---
This patch replaces "[patch] posix_fallocate.3: add note about error
codes for musl." from
https://lore.kernel.org/linux-man/CAFDeuWPmWWHatxnZ9HsYN2fp3gagHOKCsKmVDj0F6us9XWKwFQ@mail.gmail.com/T/#t
posix_fallocate(3p) doesn't list EOPNOTSUPP as an error that can be
returned to applications. Should it be noted in the man page that this
is something added/required by Linux? (I might be mistaken regarding
this assumption).
man3/posix_fallocate.3 | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/man3/posix_fallocate.3 b/man3/posix_fallocate.3
index 58338d673..125bcc12b 100644
--- a/man3/posix_fallocate.3
+++ b/man3/posix_fallocate.3
@@ -98,6 +98,13 @@ There is not enough space left on the device
containing the file
referred to by
.IR fd .
.TP
+.B EOPNOTSUPP
+The filesystem containing the file referred to by
+.IR fd
+does not support this operation.
+This error code can be returned by libc's that don't perform the
+emulation shown in NOTES, such as musl libc.
+.TP
.B ESPIPE
.I fd
refers to a pipe.
--
2.28.0
next prev parent reply other threads:[~2020-09-13 16:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 8:06 [musl] [patch] posix_fallocate.3: add note about error codes for musl Érico Rolim
2020-09-13 14:18 ` Rich Felker
2020-09-13 15:49 ` Érico Rolim [this message]
2020-10-26 23:21 ` [musl] Re: [PATCH v3] posix_fallocate.3: add EOPNOTSUPP error code Érico Rolim
2020-10-27 7:02 ` Michael Kerrisk (man-pages)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFDeuWM5Bu1Hq7FFUBvoxHJfEUTD=FDK35aJUQEYFGyCnx37NQ@mail.gmail.com' \
--to=erico.erc@gmail.com \
--cc=ericonr@disroot.org \
--cc=linux-man@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).