From: Peter Maydell <peter.maydell@linaro.org>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com, QEMU Developers <qemu-devel@nongnu.org>,
microblaze-linux@lists.itee.uq.edu.au,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Subject: Re: Bogus struct stat64 for qemu-microblaze (user emulation)?
Date: Wed, 16 Jul 2014 09:36:23 +0100 [thread overview]
Message-ID: <CAFEAcA-9-CfWn9YG+QnNS0p+SfT73RgaJdqxnXmuYcQ4rWAQ3A@mail.gmail.com> (raw)
In-Reply-To: <20140716040233.GA25975@brightrain.aerifal.cx>
On 16 July 2014 05:02, Rich Felker <dalias@libc.org> wrote:
> The qemu-microblaze definition of struct stat64 seems to mismatch the
> kernel definition, which is using asm-generic/stat.h. See:
>
> http://git.qemu.org/?p=qemu.git;a=blob;f=linux-user/syscall_defs.h;h=c9e6323905486452f518102bf40ba73143c9d601;hb=HEAD#l1469
> http://git.qemu.org/?p=qemu.git;a=blob;f=linux-user/syscall.c;h=a50229d0d72fc68966515fcf2bc308b833a3c032;hb=HEAD#l4949
>
> This seems to be causing a truncated-to-32-bit inode number to be
> stored in the location where st_ino should reside, and a spurious copy
> of the inode number to be written in a unused slot at the end of the
> structure.
Sounds quite plausible -- we've had issues with other archs
not having correct stat struct definitions in QEMU. I don't
suppose anybody's done much testing of the microblaze
linux-user code.
> Is my analysis correct? Stefan Kristiansson and I found this while
> working on the or1k port of musl libc, where it seems our structure
> for the existing microblaze port is wrongly aligned with the qemu
> definition rather than the definition the real kernel is using. Before
> I try correcting this on our side, I want to make sure we're working
> with the right version.
I would definitely trust the kernel definition, not QEMU's!
thanks
-- PMM
next prev parent reply other threads:[~2014-07-16 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-16 4:02 Rich Felker
2014-07-16 8:36 ` Peter Maydell [this message]
2014-07-16 15:59 ` Re: [Qemu-devel] " Rich Felker
[not found] ` <20140716155957.GL17402-C3MtFaGISjmo6RMmaWD+6Sb1p8zYI1N1@public.gmane.org>
2014-07-17 23:39 ` [Qemu-devel] [musl] " Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-9-CfWn9YG+QnNS0p+SfT73RgaJdqxnXmuYcQ4rWAQ3A@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=dalias@libc.org \
--cc=microblaze-linux@lists.itee.uq.edu.au \
--cc=musl@lists.openwall.com \
--cc=qemu-devel@nongnu.org \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).